Skip to contentSkip to conversation

What happened to the sb writeback list (aka sync efficiency) fix?

DISCUSSION Holger Hoffstätte 3 participants 8 messages Jun 20, 2016 – Jun 22, 2016 VFS

lore
Share & tools
lore
#0 lore raw

Once upon a time there was this fine patch set called "improve sync efficiency with sb inode wb list" [1]
by Brian Foster, who fixed up the original version by Josef Bacik.

I've been running with this since then and it seems to work flawlessly, yet it doesn't seem that this ever got merged..does anybody know why?

Waiman Long has been working on something similar with his per-CPU lists, but those patches naturally collide a bit, so I'm wondering what's what.

Fwiw the effect of the wb list on systems with many cached inodes is phenomal; it would be a shame if this went unmerged.

thanks,
Holger

[1] http://thread.gmane.org/gmane.linux.file-systems/103940

#1 lore raw
Quoted 8 lines · Holger Hoffst�tte

Once upon a time there was this fine patch set called "improve sync efficiency with sb inode wb list" [1]
by Brian Foster, who fixed up the original version by Josef Bacik.

I've been running with this since then and it seems to work flawlessly, yet it doesn't seem that this ever got merged..does anybody know why?

Quoted 7 lines

Waiman Long has been working on something similar with his per-CPU lists, but those patches naturally collide a bit, so I'm wondering what's what.

Fwiw the effect of the wb list on systems with many cached inodes is phenomal; it would be a shame if this went unmerged.

FWIW, the latest version posted was v7:

http://thread.gmane.org/gmane.linux.file-systems/104078

Thanks for the testing feedback. Unfortunately, I've not really heard any feedback on getting this merged. I'm not sure the previous version(s) by Josef and Dave got much traction either. :(

Brian

Quoted 9 lines

thanks,
Holger

[1] http://thread.gmane.org/gmane.linux.file-systems/103940

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 13 lines · Brian Foster
Quoted 12 lines · Holger Hoffstätte

Once upon a time there was this fine patch set called "improve sync efficiency with sb inode wb list" [1]
by Brian Foster, who fixed up the original version by Josef Bacik.

I've been running with this since then and it seems to work flawlessly, yet it doesn't seem that this ever got merged..does anybody know why?

Waiman Long has been working on something similar with his per-CPU lists, but those patches naturally collide a bit, so I'm wondering what's what.

Quoted 7 lines
Quoted 3 lines

Fwiw the effect of the wb list on systems with many cached inodes is phenomal; it would be a shame if this went unmerged.

FWIW, the latest version posted was v7:

http://thread.gmane.org/gmane.linux.file-systems/104078

Ah yes..that was a comment update so I didn't merge it.

Quoted 3 lines

Thanks for the testing feedback. Unfortunately, I've not really heard any feedback on getting this merged. I'm not sure the previous version(s) by Josef and Dave got much traction either. :(

The early versions by Josef had a lockdep issue, which your version apparently fixed. I've not had a single problem with it..but that admittedly doesn't mean anything. At some point I tried merging it with the per-CPU list patches (for fun :) but that turned out a bit too hairy for me.

cheers,
Holger

reviewer
#3 lore raw
In reply to Brian Foster
Quoted 17 lines · Brian Foster
Quoted 8 lines · Holger Hoffst�tte

Once upon a time there was this fine patch set called "improve sync efficiency with sb inode wb list" [1]
by Brian Foster, who fixed up the original version by Josef Bacik.

I've been running with this since then and it seems to work flawlessly, yet it doesn't seem that this ever got merged..does anybody know why?

Quoted 7 lines

Waiman Long has been working on something similar with his per-CPU lists, but those patches naturally collide a bit, so I'm wondering what's what.

Fwiw the effect of the wb list on systems with many cached inodes is phenomal; it would be a shame if this went unmerged.

Quoted 7 lines

FWIW, the latest version posted was v7:

http://thread.gmane.org/gmane.linux.file-systems/104078

Thanks for the testing feedback. Unfortunately, I've not really heard any feedback on getting this merged. I'm not sure the previous version(s) by Josef and Dave got much traction either. :(

Actually it would be a pitty to have this dropped. Please rebase & resend the patches and send them to AKPM asking him to merge them because Al isn't replying... That should make things moving.

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
#4 lore raw
Quoted 22 lines · Jan Kara
Quoted 21 lines · Brian Foster
Quoted 8 lines · Holger Hoffst�tte

Once upon a time there was this fine patch set called "improve sync efficiency with sb inode wb list" [1]
by Brian Foster, who fixed up the original version by Josef Bacik.

I've been running with this since then and it seems to work flawlessly, yet it doesn't seem that this ever got merged..does anybody know why?

Quoted 7 lines

Waiman Long has been working on something similar with his per-CPU lists, but those patches naturally collide a bit, so I'm wondering what's what.

Fwiw the effect of the wb list on systems with many cached inodes is phenomal; it would be a shame if this went unmerged.

FWIW, the latest version posted was v7:

http://thread.gmane.org/gmane.linux.file-systems/104078

Quoted 8 lines
Quoted 3 lines

Thanks for the testing feedback. Unfortunately, I've not really heard any feedback on getting this merged. I'm not sure the previous version(s) by Josef and Dave got much traction either. :(

Actually it would be a pitty to have this dropped. Please rebase & resend the patches and send them to AKPM asking him to merge them because Al isn't replying... That should make things moving.

Sure, it rebases clean so I can post a v8 after I get a chance to run some regression tests.

Holger,

Care to offer a Tested-by?

Brian

Quoted 8 lines

Honza

Signature · 6 lines
Jan Kara <[email protected]>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
author Tested-by
#5 lore raw
Quoted 32 lines · Brian Foster
Quoted 22 lines · Jan Kara
Quoted 21 lines · Brian Foster
Quoted 8 lines · Holger Hoffstätte

Once upon a time there was this fine patch set called "improve sync efficiency with sb inode wb list" [1]
by Brian Foster, who fixed up the original version by Josef Bacik.

I've been running with this since then and it seems to work flawlessly, yet it doesn't seem that this ever got merged..does anybody know why?

Quoted 7 lines

Waiman Long has been working on something similar with his per-CPU lists, but those patches naturally collide a bit, so I'm wondering what's what.

Fwiw the effect of the wb list on systems with many cached inodes is phenomal; it would be a shame if this went unmerged.

FWIW, the latest version posted was v7:

http://thread.gmane.org/gmane.linux.file-systems/104078

Quoted 8 lines
Quoted 3 lines

Thanks for the testing feedback. Unfortunately, I've not really heard any feedback on getting this merged. I'm not sure the previous version(s) by Josef and Dave got much traction either. :(

Actually it would be a pitty to have this dropped. Please rebase & resend the patches and send them to AKPM asking him to merge them because Al isn't replying... That should make things moving.

Quoted 6 lines

Sure, it rebases clean so I can post a v8 after I get a chance to run some regression tests.

Holger,

Care to offer a Tested-by?

My pleasure:

I did this on my custom 4.4.x++ frankenkernel, but I don't see why it wouldn't work on mainline.

cheers,
Holger

#6 lore raw
Quoted 36 lines · Holger Hoffst�tte
Quoted 35 lines · Brian Foster
Quoted 22 lines · Jan Kara
Quoted 21 lines · Brian Foster
Quoted 8 lines · Holger Hoffst�tte

Once upon a time there was this fine patch set called "improve sync efficiency with sb inode wb list" [1]
by Brian Foster, who fixed up the original version by Josef Bacik.

I've been running with this since then and it seems to work flawlessly, yet it doesn't seem that this ever got merged..does anybody know why?

Quoted 7 lines

Waiman Long has been working on something similar with his per-CPU lists, but those patches naturally collide a bit, so I'm wondering what's what.

Fwiw the effect of the wb list on systems with many cached inodes is phenomal; it would be a shame if this went unmerged.

FWIW, the latest version posted was v7:

http://thread.gmane.org/gmane.linux.file-systems/104078

Quoted 8 lines
Quoted 3 lines

Thanks for the testing feedback. Unfortunately, I've not really heard any feedback on getting this merged. I'm not sure the previous version(s) by Josef and Dave got much traction either. :(

Actually it would be a pitty to have this dropped. Please rebase & resend the patches and send them to AKPM asking him to merge them because Al isn't replying... That should make things moving.

Sure, it rebases clean so I can post a v8 after I get a chance to run some regression tests.

Quoted 8 lines
Quoted 3 lines

Holger,

Care to offer a Tested-by?

My pleasure:

Should this be "holger.hoffstatte@..." (note the dropped 'e')? I got a return to sender for the above on my recent post. Probably not worth resending, but you could reply to the post on-list with an accurate email and I'll fix it up locally as well...

Brian

Quoted 10 lines

I did this on my custom 4.4.x++ frankenkernel, but I don't see why it wouldn't work on mainline.

cheers,
Holger

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author Tested-by
#7 lore raw
Quoted 41 lines · Brian Foster
Quoted 40 lines · Holger Hoffstätte
Quoted 38 lines · Brian Foster
Quoted 22 lines · Jan Kara
Quoted 21 lines · Brian Foster
Quoted 8 lines · Holger Hoffstätte

Once upon a time there was this fine patch set called "improve sync efficiency with sb inode wb list" [1]
by Brian Foster, who fixed up the original version by Josef Bacik.

I've been running with this since then and it seems to work flawlessly, yet it doesn't seem that this ever got merged..does anybody know why?

Quoted 7 lines

Waiman Long has been working on something similar with his per-CPU lists, but those patches naturally collide a bit, so I'm wondering what's what.

Fwiw the effect of the wb list on systems with many cached inodes is phenomal; it would be a shame if this went unmerged.

FWIW, the latest version posted was v7:

http://thread.gmane.org/gmane.linux.file-systems/104078

Quoted 8 lines
Quoted 3 lines

Thanks for the testing feedback. Unfortunately, I've not really heard any feedback on getting this merged. I'm not sure the previous version(s) by Josef and Dave got much traction either. :(

Actually it would be a pitty to have this dropped. Please rebase & resend the patches and send them to AKPM asking him to merge them because Al isn't replying... That should make things moving.

Sure, it rebases clean so I can post a v8 after I get a chance to run some regression tests.

Holger,

Care to offer a Tested-by?

Quoted 8 lines
Quoted 3 lines

My pleasure:

Should this be "holger.hoffstatte@..." (note the dropped 'e')? I got a return to sender for the above on my recent post. Probably not worth resending, but you could reply to the post on-list with an accurate email and I'll fix it up locally as well...

I'm confused, that's all. It should be:

Trying to ditch gmail and too many different addresses. Sorry for the confusion..I made the same mistake somewhere else. :(

Holger