drm: fix send_vblank_event use-after-free error
Subsystems (2)
PATCH 1/1 drm: fix send_vblank_event use-after-free error
The drm_pending_event can be freed by drm_send_event_locked, as a result we should call trace_drm_vblank_event_delivered before this to avoid hitting a user-after-free error when accessing the pid member:
[ 378.438497] BUG: KASAN: use-after-free in send_vblank_event+0xf0/0x310 [drm] at addr ffff8801ac7e50a0 [ 378.438500] Read of size 4 by task Xorg/1562 [ 378.438501] ============================================================================= [ 378.438504] BUG kmalloc-128 (Tainted: G B ): kasan: bad access detected [ 378.438506] -----------------------------------------------------------------------------
[ 378.438509] INFO: Freed in 0x10001309c age=18446737369265680575 cpu=0 pid=0 [ 378.438541] drm_send_event_locked+0x207/0x2f0 [drm] [ 378.438544] __slab_free+0x24c/0x650 [ 378.438546] kfree+0x3a2/0x760 [ 378.438578] drm_send_event_locked+0x207/0x2f0 [drm] [ 378.438610] send_vblank_event+0xb7/0x310 [drm] [ 378.438643] drm_crtc_send_vblank_event+0x130/0x1f0 [drm] [ 378.438722] intel_atomic_commit_tail+0x23b5/0x53f0 [i915] [ 378.438802] intel_atomic_commit+0xbae/0x12f0 [i915] [ 378.438839] drm_atomic_commit+0xb0/0x120 [drm] [ 378.438855] drm_atomic_helper_connector_dpms+0x339/0x5d0 [drm_kms_helper] [ 378.438891] drm_mode_obj_set_property_ioctl+0x8f1/0xcc0 [drm] [ 378.438927] drm_mode_connector_property_set_ioctl+0xf3/0x170 [drm] [ 378.438959] drm_ioctl+0x2d7/0xae0 [drm] [ 378.438962] do_vfs_ioctl+0x1c9/0x1280 [ 378.438964] SyS_ioctl+0x79/0x90 [ 378.438967] entry_SYSCALL_64_fastpath+0x1a/0xa4
--- drivers/gpu/drm/drm_irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_irq.c +2 -2
@@ -994,10 +994,10 @@ static void send_vblank_event(struct drm_device *dev, e->event.tv_sec = now->tv_sec; e->event.tv_usec = now->tv_usec; -drm_send_event_locked (dev, &e->base); -trace_drm_vblank_event_delivered (e->base.pid, e->pipe, e->event.sequence); + +drm_send_event_locked (dev, &e->base); }/**
Signature · 6 lines
2.5.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Ro.CI.BAT: warning for drm: fix send_vblank_event use-after-free error
== Series Details ==
== Series Details ==
Series: drm: fix send_vblank_event use-after-free error
URL : https://patchwork.freedesktop.org/series/8939/
State : warning
== Summary ==
Series 8939v1 drm: fix send_vblank_event use-after-free error
http://patchwork.freedesktop.org/api/1.0/series/8939/revisions/1/mbox
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
skip -> DMESG-WARN (ro-bdw-i5-5250u)
Subgroup suspend-read-crc-pipe-c:
skip -> DMESG-WARN (ro-bdw-i5-5250u)ro-bdw-i5-5250u total:223 pass:195 dwarn:3 dfail:0 fail:2 skip:23 ro-bdw-i7-5600u total:223 pass:183 dwarn:0 dfail:0 fail:2 skip:38 ro-bsw-n3050 total:223 pass:170 dwarn:0 dfail:0 fail:4 skip:49 ro-byt-n2820 total:223 pass:171 dwarn:0 dfail:0 fail:5 skip:47 ro-hsw-i3-4010u total:223 pass:188 dwarn:0 dfail:0 fail:2 skip:33 ro-hsw-i7-4770r total:223 pass:188 dwarn:0 dfail:0 fail:2 skip:33 ro-ilk-i7-620lm total:223 pass:148 dwarn:0 dfail:0 fail:3 skip:72 ro-ilk1-i5-650 total:218 pass:148 dwarn:0 dfail:0 fail:3 skip:67 ro-ivb-i7-3770 total:223 pass:179 dwarn:0 dfail:0 fail:2 skip:42 ro-ivb2-i7-3770 total:223 pass:183 dwarn:0 dfail:0 fail:2 skip:38 ro-skl3-i5-6260u total:223 pass:199 dwarn:1 dfail:0 fail:2 skip:21 ro-snb-i7-2620M total:223 pass:172 dwarn:0 dfail:0 fail:3 skip:48
ro-bdw-i7-5557U failed to connect after reboot
Results at /archive/results/CI_IGT_test/RO_Patchwork_1242/
9bb3a64 drm-intel-nightly: 2016y-06m-20d-14h-58m-45s UTC integration manifest ca52fa3 drm: fix send_vblank_event use-after-free error
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 28 lines · Matthew Auld
The
drm_pending_eventcan be freed bydrm_send_event_locked, as a result we should calltrace_drm_vblank_event_deliveredbefore this to avoid hitting a user-after-free error when accessing the pid member:[ 378.438497] BUG: KASAN: use-after-free in send_vblank_event+0xf0/0x310 [drm] at addr ffff8801ac7e50a0 [ 378.438500] Read of size 4 by task Xorg/1562 [ 378.438501] ============================================================================= [ 378.438504] BUG kmalloc-128 (Tainted: G B ): kasan: bad access detected [ 378.438506] -----------------------------------------------------------------------------[ 378.438509] INFO: Freed in 0x10001309c age=18446737369265680575 cpu=0 pid=0 [ 378.438541] drm_send_event_locked+0x207/0x2f0 [drm] [ 378.438544] __slab_free+0x24c/0x650 [ 378.438546] kfree+0x3a2/0x760 [ 378.438578] drm_send_event_locked+0x207/0x2f0 [drm] [ 378.438610] send_vblank_event+0xb7/0x310 [drm] [ 378.438643] drm_crtc_send_vblank_event+0x130/0x1f0 [drm] [ 378.438722] intel_atomic_commit_tail+0x23b5/0x53f0 [i915] [ 378.438802] intel_atomic_commit+0xbae/0x12f0 [i915] [ 378.438839] drm_atomic_commit+0xb0/0x120 [drm] [ 378.438855] drm_atomic_helper_connector_dpms+0x339/0x5d0 [drm_kms_helper] [ 378.438891] drm_mode_obj_set_property_ioctl+0x8f1/0xcc0 [drm] [ 378.438927] drm_mode_connector_property_set_ioctl+0xf3/0x170 [drm] [ 378.438959] drm_ioctl+0x2d7/0xae0 [drm] [ 378.438962] do_vfs_ioctl+0x1c9/0x1280 [ 378.438964] SyS_ioctl+0x79/0x90 [ 378.438967] entry_SYSCALL_64_fastpath+0x1a/0xa4
Quoted 3 lines
Cc Daniel Vetter <[email protected]>Signed-off-by Matthew Auld <[email protected]>
Nice catch, applied to drm-misc.
Thanks, Daniel
Quoted 28 lines
--- drivers/gpu/drm/drm_irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_irq.c +2
-2@@ -994,10 +994,10 @@ static void send_vblank_event(struct drm_device *dev, e->event.tv_sec = now->tv_sec; e->event.tv_usec = now->tv_usec; -drm_send_event_locked (dev, &e->base); -trace_drm_vblank_event_delivered (e->base.pid, e->pipe, e->event.sequence); + +drm_send_event_locked (dev, &e->base); }/** Signature · 6 lines
2.5.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx