Skip to contentSkip to conversation

clk: at91: make of_sama5d2_clk_generated_setup() static

PATCH New Ben Dooks 3 participants 3 messages Jun 7, 2016 – Jun 21, 2016

Subsystems (2)
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 clk: at91: make of_sama5d2_clk_generated_setup() static

The of_sama5d2_clk_generated_setup() is not exported outside of the driver, so make it static to fix the warning about it being not static:

drivers/clk/at91/clk-generated.c:270:13: warning: symbol 'of_sama5d2_clk_generated_setup' was not declared. Should it be static?

---
Cc: Boris Brezillon <[email protected]>
Cc: Michael Turquette <[email protected]>
Cc: Stephen Boyd <[email protected]>
Cc: linux-clk at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org

---
 drivers/clk/at91/clk-generated.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/at91/clk-generated.c +1 -1
index e1aa210..7f6bec8 100644
@@ -267,7 +267,7 @@ at91_clk_register_generated(struct regmap *regmap,  spinlock_t *lock, const char
 	return clk;
 }
 
-void __init of_sama5d2_clk_generated_setup(struct device_node *np)
+static void __init of_sama5d2_clk_generated_setup(struct device_node *np)
 {
 	int num;
 	u32 id;
Signature · 1 line
2.8.1
#1 lore raw

PATCH 1/1 clk: at91: make of_sama5d2_clk_generated_setup() static

Quoted 7 lines · On Tue, 7 Jun 2016 17:38:09 +0100 Ben Dooks <[email protected]> wrote:

The of_sama5d2_clk_generated_setup() is not exported outside of the driver, so make it static to fix the warning about it being not static:

drivers/clk/at91/clk-generated.c:270:13: warning: symbol 'of_sama5d2_clk_generated_setup' was not declared. Should it be static?

Quoted 23 lines

---
Cc: Boris Brezillon <[email protected]>
Cc: Michael Turquette <[email protected]>
Cc: Stephen Boyd <[email protected]>
Cc: linux-clk at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org

---
 drivers/clk/at91/clk-generated.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/at91/clk-generated.c +1 -1
index e1aa210..7f6bec8 100644
@@ -267,7 +267,7 @@ at91_clk_register_generated(struct regmap *regmap,  spinlock_t *lock, const char
 	return clk;
 }
 
-void __init of_sama5d2_clk_generated_setup(struct device_node *np)
+static void __init of_sama5d2_clk_generated_setup(struct device_node *np)
 {
 	int num;
 	u32 id;
Signature · 3 lines
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Applied
#2 lore raw

PATCH 1/1 clk: at91: make of_sama5d2_clk_generated_setup() static

In reply to Ben Dooks
Quoted 8 lines · Ben Dooks

The of_sama5d2_clk_generated_setup() is not exported outside of the driver, so make it static to fix the warning about it being not static:

drivers/clk/at91/clk-generated.c:270:13: warning: symbol 'of_sama5d2_clk_generated_setup' was not declared. Should it be static?

---

Applied to clk-next

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project