Skip to contentSkip to conversation

clk: iproc: fix missing include of clk-iproc.h

PATCH New Ben Dooks 3 participants 3 messages Jun 7, 2016 – Jun 21, 2016

Subsystems (2)
Common clk Broadcom iproc Arm architecture
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 clk: iproc: fix missing include of clk-iproc.h

Fix the implicit declaration of iproc_armpll_setup() by including clk-iproc.h which defines it. Fixes the warning:

drivers/clk/bcm/clk-iproc-armpll.c:242:13: warning: symbol 'iproc_armpll_setup' was not declared. Should it be static?

Signed-off-by Ben Dooks <[email protected]>

---
Cc: Michael Turquette <[email protected]>
Cc: Stephen Boyd <[email protected]>
Cc: Ray Jui <[email protected]>
Cc: Jon Mason <[email protected]>
Cc: linux-clk at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
Cc: bcm-kernel-feedback-list at broadcom.com

---
 drivers/clk/bcm/clk-iproc-armpll.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/clk/bcm/clk-iproc-armpll.c +2 -0
index a196ee2..698c507 100644
@@ -20,6 +20,8 @@
 #include <linux/clkdev.h>
 #include <linux/of_address.h>
 
+#include "clk-iproc.h"
+
 #define IPROC_CLK_MAX_FREQ_POLICY                    0x3
 #define IPROC_CLK_POLICY_FREQ_OFFSET                 0x008
 #define IPROC_CLK_POLICY_FREQ_POLICY_FREQ_SHIFT      8
Signature · 1 line
2.8.1
#1 lore raw

PATCH 1/1 clk: iproc: fix missing include of clk-iproc.h

Hi Ben,

Quoted 24 lines · Ben Dooks

Fix the implicit declaration of iproc_armpll_setup() by including clk-iproc.h which defines it. Fixes the warning:

drivers/clk/bcm/clk-iproc-armpll.c:242:13: warning: symbol 'iproc_armpll_setup' was not declared. Should it be static?

Signed-off-by Ben Dooks <[email protected]>

---
Cc: Michael Turquette <[email protected]>
Cc: Stephen Boyd <[email protected]>
Cc: Ray Jui <[email protected]>
Cc: Jon Mason <[email protected]>
Cc: linux-clk at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
Cc: bcm-kernel-feedback-list at broadcom.com

---
 drivers/clk/bcm/clk-iproc-armpll.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/clk/bcm/clk-iproc-armpll.c +0 -0
index a196ee2..698c507 100644

drivers/clk/bcm/clk-iproc-armpll.c line 27

Quoted 8 lines
drivers/clk/bcm/clk-iproc-armpll.c +2 -0
@@ -20,6 +20,8 @@
 #include <linux/clkdev.h>
 #include <linux/of_address.h>
 
+#include "clk-iproc.h"
+
 #define IPROC_CLK_MAX_FREQ_POLICY                    0x3
 #define IPROC_CLK_POLICY_FREQ_OFFSET                 0x008
 #define IPROC_CLK_POLICY_FREQ_POLICY_FREQ_SHIFT      8

Looks good.

Acked-by Ray Jui <[email protected]>

Thanks,

Ray

Applied
#2 lore raw

PATCH 1/1 clk: iproc: fix missing include of clk-iproc.h

In reply to Ben Dooks
Quoted 7 lines · Ben Dooks

Fix the implicit declaration of iproc_armpll_setup() by including clk-iproc.h which defines it. Fixes the warning:

drivers/clk/bcm/clk-iproc-armpll.c:242:13: warning: symbol 'iproc_armpll_setup' was not declared. Should it be static?

Signed-off-by Ben Dooks <[email protected]>

---

Applied to clk-next

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project