Skip to contentSkip to conversation

ARM: imx6: fix static declaration in include/soc/imx/cpuidle.h

PATCH New Ben Dooks 2 participants 2 messages Jun 17, 2016 – Jun 21, 2016 Arm i.MX and Layerscape

lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH v2 1/1 ARM: imx6: fix static declaration in include/soc/imx/cpuidle.h

If both CONFIG_CPU_IDLE or CONFIG_SOC_IMX6Q are not set then the imx6q_cpuidle_fec_irqs_used() and other functions should be marked static inline to avoid the following warnings whilst building drivers/net/ethernet/freescale:

include/soc/imx/cpuidle.h:21:6: warning: symbol 'imx6q_cpuidle_fec_irqs_used' was not declared. Should it be static? include/soc/imx/cpuidle.h:22:6: warning: symbol 'imx6q_cpuidle_fec_irqs_unused' was not declared. Should it be static?

---
V2..V1: fix missing use of inline part
---
Cc: Fabio Estevam <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: linux-arm-kernel at lists.infradead.org

---
 include/soc/imx/cpuidle.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/soc/imx/cpuidle.h +2 -2
index 986a482..8e7743d 100644
@@ -18,8 +18,8 @@
 void imx6q_cpuidle_fec_irqs_used(void);
 void imx6q_cpuidle_fec_irqs_unused(void);
 #else
-void imx6q_cpuidle_fec_irqs_used(void) { }
-void imx6q_cpuidle_fec_irqs_unused(void) { }
+static inline void imx6q_cpuidle_fec_irqs_used(void) { }
+static inline void imx6q_cpuidle_fec_irqs_unused(void) { }
 #endif
 
 #endif /* __SOC_IMX_CPUIDLE_H__ */
Signature · 1 line
2.8.1
Applied
#1 lore raw

PATCH v2 1/1 ARM: imx6: fix static declaration in include/soc/imx/cpuidle.h

Quoted 9 lines · Ben Dooks

If both CONFIG_CPU_IDLE or CONFIG_SOC_IMX6Q are not set then the imx6q_cpuidle_fec_irqs_used() and other functions should be marked static inline to avoid the following warnings whilst building drivers/net/ethernet/freescale:

include/soc/imx/cpuidle.h:21:6: warning: symbol 'imx6q_cpuidle_fec_irqs_used' was not declared. Should it be static? include/soc/imx/cpuidle.h:22:6: warning: symbol 'imx6q_cpuidle_fec_irqs_unused' was not declared. Should it be static?

Applied, thanks.