sf: Disable 4-KB erase command for SPANSION S25FS128

PATCH New Michael Trimarchi 3 participants 9 messages Jun 22, 2016 – Aug 6, 2016 Memory technology devices (MTD)

Share & tools

Michael Trimarchi

author

2016-06-22 07:58 UTC #0 lore raw

PATCH 1/1 sf: Disable 4-KB erase command for SPANSION S25FS128

The S25FS128 is part of S25FS-S family physical sectors may be configured as a hybrid combination of eight 4-kB parameter sectors at the top or bottom of the address space with all but one of the remaining sectors being uniform size. This rework a bit commit

80c1bfd2332e71dfe669cac53ba06b7435a7ca39

and add this jedec part number

Signed-off-by Michael Trimarchi <[email protected]>

---
 drivers/mtd/spi/spi_flash.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

drivers/mtd/spi/spi_flash.c +16 -2

index 64d4e0f..c993588 100644
@@ -972,6 +972,21 @@ int spi_flash_decode_fdt(const void *blob, struct spi_flash *flash)
 #endif /* CONFIG_IS_ENABLED(OF_CONTROL) */
 
 #ifdef CONFIG_SPI_FLASH_SPANSION
+
+inline int is_spansion_s25fss_family(u16 jedec, u16 ext_jedec)
+{
+	switch (jedec) {
+	case 0x0219:
+	case 0x0220:
+	case 0x2018:
+		if ((ext_jedec & 0xff00) == 0x4d00)
+			return 1;
+	default:;
+	}
+
+	return 0;
+}
+
 static int spansion_s25fss_disable_4KB_erase(struct spi_slave *spi)
 {
 	u8 cmd[4];

@@ -1072,8 +1087,7 @@ int spi_flash_scan(struct spi_flash *flash)
 	 * sector that is not overlaid by the parameter sectors.
 	 * The uniform sector erase command has no effect on parameter sectors.
 	 */
-	if ((jedec == 0x0219 || (jedec == 0x0220)) &&
-	    (ext_jedec & 0xff00) == 0x4d00) {
+	if (is_spansion_s25fss_family(jedec, ext_jedec)) {
 		int ret;
 		u8 id[6];

Signature · 1 line

2.9.0

Yao Yuan

2016-06-22 10:00 UTC #1 lore raw

PATCH 1/1 sf: Disable 4-KB erase command for SPANSION S25FS128

Quoted 42 lines · Michael Trimarchi

The S25FS128 is part of S25FS-S family physical sectors may be configured as a hybrid combination of eight 4-kB parameter sectors at the top or bottom of the address space with all but one of the remaining sectors being uniform size. This rework a bit commit
80c1bfd2332e71dfe669cac53ba06b7435a7ca39
and add this jedec part number
Signed-off-by Michael Trimarchi <[email protected]>
---
 drivers/mtd/spi/spi_flash.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)
drivers/mtd/spi/spi_flash.c index renamed from drivers/mtd/spi/spi_flash.c +0 -0
64d4e0f..c993588 100644
drivers/mtd/spi/spi_flash.c +0 -0
@@ -972,6 +972,21 @@ int spi_flash_decode_fdt(const void *blob, struct
spi_flash *flash) #endif /* CONFIG_IS_ENABLED(OF_CONTROL) */
#ifdef CONFIG_SPI_FLASH_SPANSION
drivers/mtd/spi/spi_flash.c +14 -0
+
+inline int is_spansion_s25fss_family(u16 jedec, u16 ext_jedec) {
+	switch (jedec) {
+	case 0x0219:
+	case 0x0220:
+	case 0x2018:
+		if ((ext_jedec & 0xff00) == 0x4d00)
+			return 1;
+	default:;
+	}
+
+	return 0;
+}
+
 static int spansion_s25fss_disable_4KB_erase(struct spi_slave *spi)  {
 	u8 cmd[4];
@@ -1072,8 +1087,7 @@ int spi_flash_scan(struct spi_flash *flash)
 	 * sector that is not overlaid by the parameter sectors.
 	 * The uniform sector erase command has no effect on parameter
sectors.

drivers/mtd/spi/spi_flash.c

Quoted 8 lines

drivers/mtd/spi/spi_flash.c +1 -3

 	 */
-	if ((jedec == 0x0219 || (jedec == 0x0220)) &&
-	    (ext_jedec & 0xff00) == 0x4d00) {
+	if (is_spansion_s25fss_family(jedec, ext_jedec)) {
 		int ret;
 		u8 id[6];
 
--

Hi Michael,
From some datasheet for spansion flash,
it seems all the spansion S25FS family should disable 4kb. So how about just judge the idcode[0]?

Like:

drivers/mtd/spi/spi_flash.c +1 -2

index 64d4e0f..cfe3649 100644
@@ -1072,8 +1072,7 @@ int spi_flash_scan(struct spi_flash *flash)
         * sector that is not overlaid by the parameter sectors.
         * The uniform sector erase command has no effect on parameter sectors.
         */
-       if ((jedec == 0x0219 || (jedec == 0x0220)) &&
-           (ext_jedec & 0xff00) == 0x4d00) {
+       if (idcode[0] == SPI_FLASH_CFI_MFR_SPANSION) {
                int ret;
                u8 id[6];

How about your think?

Michael Trimarchi

author

2016-06-22 10:06 UTC #2 lore raw

PATCH 1/1 sf: Disable 4-KB erase command for SPANSION S25FS128

Quoted 50 lines · Yao Yuan

Quoted 49 lines · Michael Trimarchi
The S25FS128 is part of S25FS-S family physical sectors may be configured as a hybrid combination of eight 4-kB parameter sectors at the top or bottom of the address space with all but one of the remaining sectors being uniform size. This rework a bit commit
80c1bfd2332e71dfe669cac53ba06b7435a7ca39
and add this jedec part number
Signed-off-by Michael Trimarchi <[email protected]>
---
 drivers/mtd/spi/spi_flash.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)
drivers/mtd/spi/spi_flash.c index renamed from drivers/mtd/spi/spi_flash.c +0 -0
64d4e0f..c993588 100644
drivers/mtd/spi/spi_flash.c +0 -0
@@ -972,6 +972,21 @@ int spi_flash_decode_fdt(const void *blob, struct
spi_flash *flash) #endif /* CONFIG_IS_ENABLED(OF_CONTROL) */
#ifdef CONFIG_SPI_FLASH_SPANSION
drivers/mtd/spi/spi_flash.c +14 -0
+
+inline int is_spansion_s25fss_family(u16 jedec, u16 ext_jedec) {
+	switch (jedec) {
+	case 0x0219:
+	case 0x0220:
+	case 0x2018:
+		if ((ext_jedec & 0xff00) == 0x4d00)
+			return 1;
+	default:;
+	}
+
+	return 0;
+}
+
 static int spansion_s25fss_disable_4KB_erase(struct spi_slave *spi)  {
 	u8 cmd[4];
@@ -1072,8 +1087,7 @@ int spi_flash_scan(struct spi_flash *flash)
 	 * sector that is not overlaid by the parameter sectors.
 	 * The uniform sector erase command has no effect on parameter
sectors.
drivers/mtd/spi/spi_flash.c +1 -2
 	 */
-	if ((jedec == 0x0219 || (jedec == 0x0220)) &&
-	    (ext_jedec & 0xff00) == 0x4d00) {
+	if (is_spansion_s25fss_family(jedec, ext_jedec)) {
 		int ret;
 		u8 id[6];

Quoted 7 lines

Quoted 1 line
--
Hi Michael,
From some datasheet for spansion flash,
it seems all the spansion S25FS family should disable 4kb. So how about just judge the idcode[0]?

I understand your point but I don't have enough part number and I can only to test on this one. I will verify this patch too and put my review and drop my personal one. Anyway can you ask if the first 0x8000 are considered by boot rom? I'm trying to boot from qspi an imx7d board and I create the parameter using the files/qspi-nor-spansion-s25fl128s-config but not sure if I need to flash from 0x400 or from 0x8400. And then I think that bootloader should go from 0x1000 or from 0x9000 correct?
Then from BOOT_FROM I choose qspi but what is the DEFAULT_ADDRESS 0x1000 or 0x400?

Quoted 16 lines

Like:

drivers/mtd/spi/spi_flash.c +1 -2

index 64d4e0f..cfe3649 100644
@@ -1072,8 +1072,7 @@ int spi_flash_scan(struct spi_flash *flash)
         * sector that is not overlaid by the parameter sectors.
         * The uniform sector erase command has no effect on parameter sectors.
         */
-       if ((jedec == 0x0219 || (jedec == 0x0220)) &&
-           (ext_jedec & 0xff00) == 0x4d00) {
+       if (idcode[0] == SPI_FLASH_CFI_MFR_SPANSION) {
                int ret;
                u8 id[6];

Quoted 1 line

How about your think?

For me is fine if you are sure

Michael

Quoted 3 lines

Signature · 4 lines

| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |

Yao Yuan

2016-06-22 10:14 UTC #3 lore raw

PATCH 1/1 sf: Disable 4-KB erase command for SPANSION S25FS128

Quoted 60 lines · Michael Trimarchi

Quoted 51 lines · Yao Yuan
Quoted 50 lines · Michael Trimarchi
The S25FS128 is part of S25FS-S family physical sectors may be configured as a hybrid combination of eight 4-kB parameter sectors at the top or bottom of the address space with all but one of the remaining sectors being uniform size. This rework a bit commit
80c1bfd2332e71dfe669cac53ba06b7435a7ca39
and add this jedec part number
Signed-off-by Michael Trimarchi <[email protected]>
---
 drivers/mtd/spi/spi_flash.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)
(quoted diff) +0 -0
b/drivers/mtd/spi/spi_flash.c index
64d4e0f..c993588 100644
drivers/mtd/spi/spi_flash.c +0 -0
@@ -972,6 +972,21 @@ int spi_flash_decode_fdt(const void *blob,
struct spi_flash *flash) #endif /* CONFIG_IS_ENABLED(OF_CONTROL) */
#ifdef CONFIG_SPI_FLASH_SPANSION
drivers/mtd/spi/spi_flash.c +14 -0
+
+inline int is_spansion_s25fss_family(u16 jedec, u16 ext_jedec) {
+	switch (jedec) {
+	case 0x0219:
+	case 0x0220:
+	case 0x2018:
+		if ((ext_jedec & 0xff00) == 0x4d00)
+			return 1;
+	default:;
+	}
+
+	return 0;
+}
+
 static int spansion_s25fss_disable_4KB_erase(struct spi_slave *spi)  {
 	u8 cmd[4];
@@ -1072,8 +1087,7 @@ int spi_flash_scan(struct spi_flash *flash)
 	 * sector that is not overlaid by the parameter sectors.
 	 * The uniform sector erase command has no effect on parameter
sectors.
drivers/mtd/spi/spi_flash.c +1 -2
 	 */
-	if ((jedec == 0x0219 || (jedec == 0x0220)) &&
-	    (ext_jedec & 0xff00) == 0x4d00) {
+	if (is_spansion_s25fss_family(jedec, ext_jedec)) {
 		int ret;
 		u8 id[6];
Quoted 7 lines
Quoted 1 line
--
Hi Michael,
From some datasheet for spansion flash, it seems all the spansion S25FS family should disable 4kb.
So how about just judge the idcode[0]?

Quoted 10 lines

I understand your point but I don't have enough part number and I can only to test on this one. I will verify this patch too and put my review and drop my personal one. Anyway can you ask if the first 0x8000 are considered by boot rom? I'm trying to boot from qspi an imx7d board and I create the parameter using the files/qspi-nor-spansion-s25fl128s-config but not sure if I need to flash from 0x400 or from 0x8400. And then I think that bootloader should go from 0x1000 or from 0x9000 correct?
Then from BOOT_FROM I choose qspi but what is the DEFAULT_ADDRESS 0x1000 or 0x400?

I'm not sure what's the offset for imx7d, but for NXP LS series SOC. The RCW_PBI offset: 0x0
The Uboot offset is defined by RCW_PBI code.(Such as 0x10000)

Quoted 31 lines

Quoted 16 lines

Like:

drivers/mtd/spi/spi_flash.c +1 -2

index 64d4e0f..cfe3649 100644
@@ -1072,8 +1072,7 @@ int spi_flash_scan(struct spi_flash *flash)
         * sector that is not overlaid by the parameter sectors.
         * The uniform sector erase command has no effect on parameter sectors.
         */
-       if ((jedec == 0x0219 || (jedec == 0x0220)) &&
-           (ext_jedec & 0xff00) == 0x4d00) {
+       if (idcode[0] == SPI_FLASH_CFI_MFR_SPANSION) {
                int ret;
                u8 id[6];

Quoted 1 line

How about your think?

For me is fine if you are sure

Michael

Quoted 3 lines

| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |

Michael Trimarchi

author

2016-06-22 10:55 UTC #4 lore raw

[U-Boot] Booting imx7d from qspi using spansion flash (WAS Re: [PATCH] sf: Disable 4-KB erase command for SPANSION S25FS128)

Hi Ye.Li

Quoted 72 lines · Yao Yuan

Quoted 60 lines · Michael Trimarchi
Quoted 51 lines · Yao Yuan
Quoted 50 lines · Michael Trimarchi
The S25FS128 is part of S25FS-S family physical sectors may be configured as a hybrid combination of eight 4-kB parameter sectors at the top or bottom of the address space with all but one of the remaining sectors being uniform size. This rework a bit commit
80c1bfd2332e71dfe669cac53ba06b7435a7ca39
and add this jedec part number
Signed-off-by Michael Trimarchi <[email protected]>
---
 drivers/mtd/spi/spi_flash.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)
(quoted diff) +0 -0
b/drivers/mtd/spi/spi_flash.c index
64d4e0f..c993588 100644
drivers/mtd/spi/spi_flash.c +0 -0
@@ -972,6 +972,21 @@ int spi_flash_decode_fdt(const void *blob,
struct spi_flash *flash) #endif /* CONFIG_IS_ENABLED(OF_CONTROL) */
#ifdef CONFIG_SPI_FLASH_SPANSION
drivers/mtd/spi/spi_flash.c +14 -0
+
+inline int is_spansion_s25fss_family(u16 jedec, u16 ext_jedec) {
+	switch (jedec) {
+	case 0x0219:
+	case 0x0220:
+	case 0x2018:
+		if ((ext_jedec & 0xff00) == 0x4d00)
+			return 1;
+	default:;
+	}
+
+	return 0;
+}
+
 static int spansion_s25fss_disable_4KB_erase(struct spi_slave *spi)  {
 	u8 cmd[4];
@@ -1072,8 +1087,7 @@ int spi_flash_scan(struct spi_flash *flash)
 	 * sector that is not overlaid by the parameter sectors.
 	 * The uniform sector erase command has no effect on parameter
sectors.
drivers/mtd/spi/spi_flash.c +1 -2
 	 */
-	if ((jedec == 0x0219 || (jedec == 0x0220)) &&
-	    (ext_jedec & 0xff00) == 0x4d00) {
+	if (is_spansion_s25fss_family(jedec, ext_jedec)) {
 		int ret;
 		u8 id[6];
Quoted 7 lines
Quoted 1 line
--
Hi Michael,
From some datasheet for spansion flash, it seems all the spansion S25FS family should disable 4kb.
So how about just judge the idcode[0]?
Quoted 10 lines
I understand your point but I don't have enough part number and I can only to test on this one. I will verify this patch too and put my review and drop my personal one. Anyway can you ask if the first 0x8000 are considered by boot rom? I'm trying to boot from qspi an imx7d board and I create the parameter using the files/qspi-nor-spansion-s25fl128s-config but not sure if I need to flash from 0x400 or from 0x8400. And then I think that bootloader should go from 0x1000 or from 0x9000 correct?
Then from BOOT_FROM I choose qspi but what is the DEFAULT_ADDRESS 0x1000 or 0x400?

Quoted 4 lines

I'm not sure what's the offset for imx7d, but for NXP LS series SOC. The RCW_PBI offset: 0x0
The Uboot offset is defined by RCW_PBI code.(Such as 0x10000)

I have seen that the booting from QSPI come from you. Do you have an idea about imx7d booting from QSPI?

Michael

Quoted 31 lines

Quoted 16 lines

Like:

drivers/mtd/spi/spi_flash.c +1 -2

index 64d4e0f..cfe3649 100644
@@ -1072,8 +1072,7 @@ int spi_flash_scan(struct spi_flash *flash)
         * sector that is not overlaid by the parameter sectors.
         * The uniform sector erase command has no effect on parameter sectors.
         */
-       if ((jedec == 0x0219 || (jedec == 0x0220)) &&
-           (ext_jedec & 0xff00) == 0x4d00) {
+       if (idcode[0] == SPI_FLASH_CFI_MFR_SPANSION) {
                int ret;
                u8 id[6];

Quoted 1 line

How about your think?

For me is fine if you are sure

Michael

Quoted 3 lines

| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |

Signature · 4 lines

| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |

Jagan Teki

2016-08-06 14:37 UTC #5 lore raw

PATCH 1/1 sf: Disable 4-KB erase command for SPANSION S25FS128

In reply to Yao Yuan

Quoted 61 lines · Yao Yuan

Quoted 60 lines · Michael Trimarchi
Quoted 58 lines · Yao Yuan
Quoted 46 lines · Michael Trimarchi
The S25FS128 is part of S25FS-S family physical sectors may be configured as a hybrid combination of eight 4-kB parameter sectors at the top or bottom of the address space with all but one of the remaining sectors being uniform size. This rework a bit commit
80c1bfd2332e71dfe669cac53ba06b7435a7ca39
and add this jedec part number
Signed-off-by Michael Trimarchi <[email protected]>
---
 drivers/mtd/spi/spi_flash.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)
(quoted diff) +0 -0
b/drivers/mtd/spi/spi_flash.c index
64d4e0f..c993588 100644
drivers/mtd/spi/spi_flash.c +0 -0
@@ -972,6 +972,21 @@ int spi_flash_decode_fdt(const void *blob,
struct spi_flash *flash) #endif /* CONFIG_IS_ENABLED(OF_CONTROL) */
#ifdef CONFIG_SPI_FLASH_SPANSION
drivers/mtd/spi/spi_flash.c +14 -0
+
+inline int is_spansion_s25fss_family(u16 jedec, u16 ext_jedec) {
+ switch (jedec) {
+ case 0x0219:
+ case 0x0220:
+ case 0x2018:
+         if ((ext_jedec & 0xff00) == 0x4d00)
+                 return 1;
+ default:;
+ }
+
+ return 0;
+}
+
 static int spansion_s25fss_disable_4KB_erase(struct spi_slave *spi)  {
  u8 cmd[4];
@@ -1072,8 +1087,7 @@ int spi_flash_scan(struct spi_flash *flash)
   * sector that is not overlaid by the parameter sectors.
   * The uniform sector erase command has no effect on parameter
sectors.
*/
- if ((jedec == 0x0219 || (jedec == 0x0220)) &&
- (ext_jedec & 0xff00) == 0x4d00) {
Quoted 5 lines
+ if (is_spansion_s25fss_family(jedec, ext_jedec)) {
          int ret;
          u8 id[6];
--
Hi Michael,
From some datasheet for spansion flash, it seems all the spansion S25FS family should disable 4kb.
So how about just judge the idcode[0]?

Quoted 10 lines

Quoted 10 lines
I understand your point but I don't have enough part number and I can only to test on this one. I will verify this patch too and put my review and drop my personal one. Anyway can you ask if the first 0x8000 are considered by boot rom? I'm trying to boot from qspi an imx7d board and I create the parameter using the files/qspi-nor-spansion-s25fl128s-config but not sure if I need to flash from 0x400 or from 0x8400. And then I think that bootloader should go from 0x1000 or from 0x9000 correct?
Then from BOOT_FROM I choose qspi but what is the DEFAULT_ADDRESS 0x1000 or 0x400?

Don't understand either does this "Disable 4-KB erase command for SPANSION S25FS-S family" (spansion_s25fss_disable_4KB_erase) is an issue workaround or something like hybrid configuration feature for spansion parts?

thanks!

Signature · 4 lines

Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

Michael Trimarchi

author

2016-08-06 14:40 UTC #6 lore raw

PATCH 1/1 sf: Disable 4-KB erase command for SPANSION S25FS128

Quoted 73 lines · Jagan Teki

Quoted 61 lines · Yao Yuan
Quoted 60 lines · Michael Trimarchi
Quoted 58 lines · Yao Yuan
Quoted 46 lines · Michael Trimarchi
The S25FS128 is part of S25FS-S family physical sectors may be configured as a hybrid combination of eight 4-kB parameter sectors at the top or bottom of the address space with all but one of the remaining sectors being uniform size. This rework a bit commit
80c1bfd2332e71dfe669cac53ba06b7435a7ca39
and add this jedec part number
Signed-off-by Michael Trimarchi <[email protected]>
---
 drivers/mtd/spi/spi_flash.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)
(quoted diff) +0 -0
b/drivers/mtd/spi/spi_flash.c index
64d4e0f..c993588 100644
drivers/mtd/spi/spi_flash.c +0 -0
@@ -972,6 +972,21 @@ int spi_flash_decode_fdt(const void *blob,
struct spi_flash *flash) #endif /* CONFIG_IS_ENABLED(OF_CONTROL) */
#ifdef CONFIG_SPI_FLASH_SPANSION
drivers/mtd/spi/spi_flash.c +14 -0
+
+inline int is_spansion_s25fss_family(u16 jedec, u16 ext_jedec) {
+ switch (jedec) {
+ case 0x0219:
+ case 0x0220:
+ case 0x2018:
+         if ((ext_jedec & 0xff00) == 0x4d00)
+                 return 1;
+ default:;
+ }
+
+ return 0;
+}
+
 static int spansion_s25fss_disable_4KB_erase(struct spi_slave *spi)  {
  u8 cmd[4];
@@ -1072,8 +1087,7 @@ int spi_flash_scan(struct spi_flash *flash)
   * sector that is not overlaid by the parameter sectors.
   * The uniform sector erase command has no effect on parameter
sectors.
*/
- if ((jedec == 0x0219 || (jedec == 0x0220)) &&
- (ext_jedec & 0xff00) == 0x4d00) {
Quoted 5 lines
+ if (is_spansion_s25fss_family(jedec, ext_jedec)) {
          int ret;
          u8 id[6];
--
Hi Michael,
From some datasheet for spansion flash, it seems all the spansion S25FS family should disable 4kb.
So how about just judge the idcode[0]?
Quoted 10 lines
Quoted 10 lines
I understand your point but I don't have enough part number and I can only to test on this one. I will verify this patch too and put my review and drop my personal one. Anyway can you ask if the first 0x8000 are considered by boot rom? I'm trying to boot from qspi an imx7d board and I create the parameter using the files/qspi-nor-spansion-s25fl128s-config but not sure if I need to flash from 0x400 or from 0x8400. And then I think that bootloader should go from 0x1000 or from 0x9000 correct?
Then from BOOT_FROM I choose qspi but what is the DEFAULT_ADDRESS 0x1000 or 0x400?

Quoted 5 lines

Don't understand either does this "Disable 4-KB erase command for SPANSION S25FS-S family" (spansion_s25fss_disable_4KB_erase) is an issue workaround or something like hybrid configuration feature for spansion parts?

Please refer here.

Michael

Quoted 6 lines

thanks!
--
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

Signature · 11 lines

| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: S25FS-S_Prog_Guide_AN.pdf
Type: application/pdf
Size: 606238 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160806/c81f0989/attachment-0001.pdf>

Jagan Teki

2016-08-06 15:08 UTC #7 lore raw

PATCH 1/1 sf: Disable 4-KB erase command for SPANSION S25FS128

Quoted 12 lines · Michael Trimarchi

Quoted 12 lines
Quoted 11 lines
Quoted 11 lines
I understand your point but I don't have enough part number and I can only to test on this one. I will verify this patch too and put my review and drop my personal one. Anyway can you ask if the first 0x8000 are considered by boot rom? I'm trying to boot from qspi an imx7d board and I create the parameter using the files/qspi-nor-spansion-s25fl128s-config but not sure if I need to flash from 0x400 or from 0x8400. And then I think that bootloader should go from 0x1000 or from 0x9000 correct?
Then from BOOT_FROM I choose qspi but what is the DEFAULT_ADDRESS 0x1000 or 0x400?

Quoted 7 lines

Quoted 5 lines
Don't understand either does this "Disable 4-KB erase command for SPANSION S25FS-S family" (spansion_s25fss_disable_4KB_erase) is an issue workaround or something like hybrid configuration feature for spansion parts?
Please refer here.

Thanks for the pdf, So the lower 8 4k sectors are unaffected even if we do sector erase(d8h)? What if we do 4k erase(20h) whole flash all effected?

thanks!

Signature · 4 lines

Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

Michael Trimarchi

author

2016-08-06 15:14 UTC #8 lore raw

PATCH 1/1 sf: Disable 4-KB erase command for SPANSION S25FS128

Quoted 20 lines · Jagan Teki

Quoted 18 lines · Michael Trimarchi
Quoted 17 lines
Quoted 11 lines
Quoted 11 lines
I understand your point but I don't have enough part number and I can only to test on this one. I will verify this patch too and put my review and drop my personal one. Anyway can you ask if the first 0x8000 are considered by boot rom? I'm trying to boot from qspi an imx7d board and I create the parameter using the files/qspi-nor-spansion-s25fl128s-config but not sure if I need to flash from 0x400 or from 0x8400. And then I think that bootloader should go from 0x1000 or from 0x9000 correct?
Then from BOOT_FROM I choose qspi but what is the DEFAULT_ADDRESS 0x1000 or 0x400?
Don't understand either does this "Disable 4-KB erase command for SPANSION S25FS-S family" (spansion_s25fss_disable_4KB_erase) is an issue workaround or something like hybrid configuration feature for spansion parts?

Quoted 5 lines

Quoted 1 line
Please refer here.
Thanks for the pdf, So the lower 8 4k sectors are unaffected even if we do sector erase(d8h)? What if we do 4k erase(20h) whole flash all effected?

1) correct
2) I need to check

If we send this command we just remap it in the same way

Michael

Quoted 7 lines

thanks!
--
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

Signature · 4 lines

| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |