Skip to contentSkip to conversation

nft shell tests

DISCUSSION Pablo Neira Ayuso 2 participants 3 messages Jun 23, 2016 netfilter

lore
Share & tools
lore

Pablo Neira Ayuso

author maintainer
#0 lore raw

Hi Arturo,

I think it would be good if the run-test.sh script uses the binary in this tree, just like nft-tests.py. Instead of using the one that is available on the system.

Let me know, thanks.

#1 lore raw
Quoted 7 lines · Pablo Neira Ayuso

Hi Arturo,

I think it would be good if the run-test.sh script uses the binary in this tree, just like nft-tests.py. Instead of using the one that is available on the system.

Let me know, thanks.

You can use arbitrary binaries passing the NFT variable:

% NFT=../../src/nft ./run-tests.sh

would you like to change the behaviour to use the nft binary from src/ by default?

Signature · 5 lines
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
author maintainer
#2 lore raw
Quoted 7 lines · Arturo Borrero Gonzalez
Quoted 6 lines · Pablo Neira Ayuso

Hi Arturo,

I think it would be good if the run-test.sh script uses the binary in this tree, just like nft-tests.py. Instead of using the one that is available on the system.

Quoted 8 lines
Quoted 1 line

Let me know, thanks.

You can use arbitrary binaries passing the NFT variable:

% NFT=../../src/nft ./run-tests.sh

would you like to change the behaviour to use the nft binary from src/ by default?

I think it's a good default to use the nft binary from src/

Otherwise, if you forget to 'make install' you may end up testing something else :)

This would be very useful for continuous integration as we don't need to install the binary itself on the test infrastructure to run the tests.