Skip to contentSkip to conversation

net: wireless: add brcm80211 drivers

DISCUSSION Dan Carpenter 1 participant 2 messages Jun 27, 2016

lore
Share & tools
lore
#0 lore raw

Hello Arend van Spriel,

The patch 5b435de0d786: "net: wireless: add brcm80211 drivers" from Oct 5, 2011, leads to the following static checker warning:

	drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:26460 wlc_phy_rxcal_radio_setup_nphy()
	warn: mask and shift to zero

drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c
26452 } else {
26453 pi->tx_rx_cal_radio_saveregs[4] =
26454 read_radio_reg(pi,
26455 RADIO_2056_RX_LNAA_TUNE
26456 | RADIO_2056_RX0);
26457
26458 offtune_val =
26459 (pi->tx_rx_cal_radio_saveregs
26460 [2] & 0xF0) >> 8;

This is obviously nonsense code, but I have no idea what was intended.

26461 offtune_val =
26462 (offtune_val <= 0x7) ? 0xF : 0;

This is perhaps a bug fix/work around for the earlier line.

26463
26464 mod_radio_reg(pi,

 26465                                                        RADIO_2056_RX_LNAA_TUNE |
 26466                                                        RADIO_2056_RX0, 0xF0,
 26467                                                        (offtune_val << 8));

26468 }

regards,
dan carpenter

#1 lore raw

There were a some others as well:

drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:26511 wlc_phy_rxcal_radio_setup_nphy() warn: mask and shift to zero drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:26585 wlc_phy_rxcal_radio_setup_nphy() warn: mask and shift to zero drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:26635 wlc_phy_rxcal_radio_setup_nphy() warn: mask and shift to zero

regards,
dan carpenter