Skip to contentSkip to conversation

be2net: signedness bug in be_msix_enable()

PATCH Applied Dan Carpenter 3 participants 3 messages Jun 29, 2016 – Jun 30, 2016

Subsystems (4)
Networking Network drivers Kernel janitors Emulex 10Gbps NIC BE2, BE3-r, Lancer, Skyhawk-R driver (be2net)
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 be2net: signedness bug in be_msix_enable()

"num_vec" needs to be signed for the error handling to work.

Fixes e261768e9e39 ('be2net: support asymmetric rx/tx queue counts')
Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/emulex/benet/be_main.c +2 -1
index 1873c74..1f16e73 100644
@@ -3251,8 +3251,9 @@ static void be_msix_disable(struct be_adapter *adapter)
 
 static int be_msix_enable(struct be_adapter *adapter)
 {
-	unsigned int i, num_vec, max_roce_eqs;
+	unsigned int i, max_roce_eqs;
 	struct device *dev = &adapter->pdev->dev;
+	int num_vec;
 
 	/* If RoCE is supported, program the max number of vectors that
 	 * could be used for NIC and RoCE, else, just program the number
Acked-by on v1 1/1
#1 lore raw

Review

Quoted 9 lines

-----Original Message-----
From: Dan Carpenter [mailto:[email protected]]

"num_vec" needs to be signed for the error handling to work.

Fixes e261768e9e39 ('be2net: support asymmetric rx/tx queue counts')
Signed-off-by Dan Carpenter <[email protected]>
(quoted diff) +0 -0

b/drivers/net/ethernet/emulex/benet/be_main.c

drivers/net/ethernet/emulex/benet/be_main.c static void be_msix_disable(struct be_adapter

Quoted 4 lines

index 1873c74..1f16e73 100644

drivers/net/ethernet/emulex/benet/be_main.c +0 -0
@@ -3251,8 +3251,9 @@ static void be_msix_disable(struct be_adapter

*adapter)

drivers/net/ethernet/emulex/benet/be_main.c static void be_msix_disable(struct be_adapter *adapter) · line 3257

Quoted 7 lines
drivers/net/ethernet/emulex/benet/be_main.c +2 -1
 static int be_msix_enable(struct be_adapter *adapter)  {
-	unsigned int i, num_vec, max_roce_eqs;
+	unsigned int i, max_roce_eqs;
 	struct device *dev = &adapter->pdev->dev;
+	int num_vec;

Oops...thanks for catching this! This must go into net-next.

Acked-by Sathya Perla <[email protected]>