Skip to contentSkip to conversation

dt-bindings: clock: rk3188-cru-common: remove CLK_NR_CLKS

PATCH Applied Johan Jonker 3 participants 5 messages Jun 27, 2024 – Jul 4, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: clock: rk3188-cru-common: remove CLK_NR_CLKS

CLK_NR_CLKS should not be part of the binding.
Remove since the kernel code no longer uses it.

---
 include/dt-bindings/clock/rk3188-cru-common.h | 2 --
 1 file changed, 2 deletions(-)
include/dt-bindings/clock/rk3188-cru-common.h +0 -2
index afad90680fce..01e14ab252a7 100644
@@ -132,8 +132,6 @@
 #define HCLK_VDPU		472
 #define HCLK_HDMI		473
 
-#define CLK_NR_CLKS		(HCLK_HDMI + 1)
-
 /* soft-reset indices */
 #define SRST_MCORE		2
 #define SRST_CORE0		3

--
2.39.2

#1 lore raw
Quoted 2 lines · Johan Jonker

CLK_NR_CLKS should not be part of the binding.
Remove since the kernel code no longer uses it.

Please wrap neither too early nor over the limit. Not one sentence per line.

Quoted 11 lines
---
 include/dt-bindings/clock/rk3188-cru-common.h | 2 --
 1 file changed, 2 deletions(-)
include/dt-bindings/clock/rk3188-cru-common.h +0 -0
index afad90680fce..01e14ab252a7 100644

include/dt-bindings/clock/rk3188-cru-common.h line 135

Quoted 4 lines
include/dt-bindings/clock/rk3188-cru-common.h +0 -1
@@ -132,8 +132,6 @@
 #define HCLK_VDPU		472
 #define HCLK_HDMI		473
 
-#define CLK_NR_CLKS		(HCLK_HDMI + 1)

I still see it as being used in linux-next. Some explanation is missing.

Best regards,
Krzysztof

maintainer
#2 lore raw

Hi Krzysztof,

Am Freitag, 28. Juni 2024, 09:27:14 CEST schrieb Krzysztof Kozlowski:

Quoted 22 lines · Johan Jonker
Quoted 2 lines

CLK_NR_CLKS should not be part of the binding.
Remove since the kernel code no longer uses it.

Please wrap neither too early nor over the limit. Not one sentence per line.

Quoted 14 lines
---
 include/dt-bindings/clock/rk3188-cru-common.h | 2 --
 1 file changed, 2 deletions(-)
include/dt-bindings/clock/rk3188-cru-common.h +0 -0
index afad90680fce..01e14ab252a7 100644
@@ -132,8 +132,6 @@
 #define HCLK_VDPU		472
 #define HCLK_HDMI		473
 
Quoted 3 lines

include/dt-bindings/clock/rk3188-cru-common.h line 135

Quoted 1 line
include/dt-bindings/clock/rk3188-cru-common.h +0 -1
-#define CLK_NR_CLKS		(HCLK_HDMI + 1)

I still see it as being used in linux-next. Some explanation is missing.

I think me applying Johan's patch [0] removing the constant's usage, simply overlapped with yesterday's next-creation.

[0] https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=for-next&id=ec2265dc91307622e43a7d602c3ea425da6f5de1

#3 lore raw
Quoted 25 lines · Heiko Stübner

Hi Krzysztof,

Am Freitag, 28. Juni 2024, 09:27:14 CEST schrieb Krzysztof Kozlowski:

Quoted 22 lines · Johan Jonker
Quoted 2 lines

CLK_NR_CLKS should not be part of the binding.
Remove since the kernel code no longer uses it.

Please wrap neither too early nor over the limit. Not one sentence per line.

Quoted 14 lines
---
 include/dt-bindings/clock/rk3188-cru-common.h | 2 --
 1 file changed, 2 deletions(-)
include/dt-bindings/clock/rk3188-cru-common.h +0 -0
index afad90680fce..01e14ab252a7 100644
@@ -132,8 +132,6 @@
 #define HCLK_VDPU		472
 #define HCLK_HDMI		473
 
Quoted 7 lines
Quoted 3 lines

include/dt-bindings/clock/rk3188-cru-common.h line 135

Quoted 1 line
include/dt-bindings/clock/rk3188-cru-common.h +0 -1
-#define CLK_NR_CLKS		(HCLK_HDMI + 1)

I still see it as being used in linux-next. Some explanation is missing.

I think me applying Johan's patch [0] removing the constant's usage, simply overlapped with yesterday's next-creation.

These should be sent in one patchset, which makes it obvious. Splitting does not help...

Best regards,
Krzysztof

maintainer Applied
#4 lore raw
In reply to Johan Jonker
Quoted 4 lines · Johan Jonker

CLK_NR_CLKS should not be part of the binding.
Remove since the kernel code no longer uses it.

Applied, thanks!

[1/1] dt-bindings: clock: rk3188-cru-common: remove CLK_NR_CLKS

      commit: d89e8096957e35742c9922d3f6628f24de0d6163

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>