Skip to contentSkip to conversation

drm/i915/bxt: Export pooled eu info to userspace

PATCH New Arun Siluvery 4 participants 7 messages Jul 1, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/bxt: Export pooled eu info to userspace

Pooled EU is a bxt only feature and kernel changes are already merged. This feature is not yet exposed to userspace as the support was not yet available. Beignet team expressed interest and added patches to use this.

Since we now have a user and patches to use them, expose them from the kernel side as well.

[1] https://lists.freedesktop.org/archives/beignet/2016-June/007698.html
[2] https://lists.freedesktop.org/archives/beignet/2016-June/007699.html

Cc Winiarski, Michal <[email protected]>
Cc Zou, Nanhai <[email protected]>
Cc Yang, Rong R <[email protected]>
Cc Tim Gore <[email protected]>
Cc Jeff McGee <[email protected]>
---
 drivers/gpu/drm/i915/i915_drv.c | 6 ++++++
 include/uapi/drm/i915_drm.h     | 2 ++
 2 files changed, 8 insertions(+)
drivers/gpu/drm/i915/i915_drv.c +6 -0
index c580e24..8a26740 100644
@@ -365,6 +365,12 @@ static int i915_getparam(struct drm_device *dev, void *data,
 	case I915_PARAM_HAS_EXEC_SOFTPIN:
 		value = 1;
 		break;
+	case I915_PARAM_HAS_POOLED_EU:
+		value = HAS_POOLED_EU(dev);
+		break;
+	case I915_PARAM_MIN_EU_IN_POOL:
+		value = INTEL_INFO(dev)->min_eu_in_pool;
+		break;
 	default:
 		DRM_DEBUG("Unknown parameter %d\n", param->param);
 		return -EINVAL;
include/uapi/drm/i915_drm.h +2 -0
index c17d63d..905880d 100644
@@ -361,6 +361,8 @@ typedef struct drm_i915_irq_wait {
 #define I915_PARAM_HAS_GPU_RESET	 35
 #define I915_PARAM_HAS_RESOURCE_STREAMER 36
 #define I915_PARAM_HAS_EXEC_SOFTPIN	 37
+#define I915_PARAM_HAS_POOLED_EU	 38
+#define I915_PARAM_HAS_MIN_EU_IN_POOL	 39
 
 typedef struct drm_i915_getparam {
 	__s32 param;
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Ro.CI.BAT: failure for drm/i915/bxt: Export pooled eu info to userspace

== Series Details ==

== Series Details ==

Series: drm/i915/bxt: Export pooled eu info to userspace
URL : https://patchwork.freedesktop.org/series/9367/
State : failure

== Summary ==

  CC      drivers/acpi/acpica/uthex.o
  CC      drivers/acpi/acpica/utids.o
  CC      drivers/acpi/acpica/utinit.o
  CC      drivers/acpi/acpica/utlock.o
  CC      drivers/acpi/acpica/utmath.o
  CC      drivers/acpi/acpica/utmutex.o
  CC      drivers/acpi/acpica/utnonansi.o
  CC      drivers/acpi/acpica/utmisc.o
  CC      drivers/acpi/acpica/utobject.o
  CC      drivers/acpi/acpica/utosi.o
  CC      drivers/acpi/acpica/utownerid.o
  CC      drivers/acpi/acpica/utpredef.o
  CC      drivers/acpi/acpica/utresrc.o
  CC      drivers/acpi/acpica/utstate.o
  CC      drivers/acpi/acpica/utstring.o
  CC      drivers/acpi/acpica/utxface.o
  CC      drivers/acpi/acpica/utxferror.o
  CC      drivers/acpi/acpica/utxfinit.o
  CC      drivers/acpi/acpica/utxfmutex.o
  LD      lib/built-in.o
  LD      net/ipv6/ipv6.o
  AR      lib/lib.a
  LD      drivers/acpi/acpica/acpi.o
  LD      net/ipv6/built-in.o
  LD      drivers/acpi/acpica/built-in.o
  LD      net/built-in.o
  LD      drivers/acpi/built-in.o

Makefile:985: recipe for target 'drivers' failed
make: *** [drivers] Error 2
make: *** Waiting for unfinished jobs....

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

PATCH 1/1 drm/i915/bxt: Export pooled eu info to userspace

In reply to Arun Siluvery

Pooled EU is a bxt only feature and kernel changes are already merged. This feature is not yet exposed to userspace as the support was not yet available. Beignet team expressed interest and added patches to use this.

Since we now have a user and patches to use them, expose them from the kernel side as well.

v2: fix compile error

[1] https://lists.freedesktop.org/archives/beignet/2016-June/007698.html
[2] https://lists.freedesktop.org/archives/beignet/2016-June/007699.html

Cc Winiarski, Michal <[email protected]>
Cc Zou, Nanhai <[email protected]>
Cc Yang, Rong R <[email protected]>
Cc Tim Gore <[email protected]>
Cc Jeff McGee <[email protected]>
---
 drivers/gpu/drm/i915/i915_drv.c | 6 ++++++
 include/uapi/drm/i915_drm.h     | 2 ++
 2 files changed, 8 insertions(+)
drivers/gpu/drm/i915/i915_drv.c +6 -0
index c580e24..8a26740 100644
@@ -365,6 +365,12 @@ static int i915_getparam(struct drm_device *dev, void *data,
 	case I915_PARAM_HAS_EXEC_SOFTPIN:
 		value = 1;
 		break;
+	case I915_PARAM_HAS_POOLED_EU:
+		value = HAS_POOLED_EU(dev);
+		break;
+	case I915_PARAM_MIN_EU_IN_POOL:
+		value = INTEL_INFO(dev)->min_eu_in_pool;
+		break;
 	default:
 		DRM_DEBUG("Unknown parameter %d\n", param->param);
 		return -EINVAL;
include/uapi/drm/i915_drm.h +2 -0
index c17d63d..a642bbc 100644
@@ -361,6 +361,8 @@ typedef struct drm_i915_irq_wait {
 #define I915_PARAM_HAS_GPU_RESET	 35
 #define I915_PARAM_HAS_RESOURCE_STREAMER 36
 #define I915_PARAM_HAS_EXEC_SOFTPIN	 37
+#define I915_PARAM_HAS_POOLED_EU	 38
+#define I915_PARAM_MIN_EU_IN_POOL	 39
 
 typedef struct drm_i915_getparam {
 	__s32 param;
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Acked-by on v1 1/1
#3 lore raw
Quoted 12 lines · Arun Siluvery

Pooled EU is a bxt only feature and kernel changes are already merged. This feature is not yet exposed to userspace as the support was not yet available. Beignet team expressed interest and added patches to use this.

Since we now have a user and patches to use them, expose them from the kernel side as well.

v2: fix compile error

[1] https://lists.freedesktop.org/archives/beignet/2016-June/007698.html
[2] https://lists.freedesktop.org/archives/beignet/2016-June/007699.html

Quoted 6 lines
Cc Winiarski, Michal <[email protected]>
Cc Zou, Nanhai <[email protected]>
Cc Yang, Rong R <[email protected]>
Cc Tim Gore <[email protected]>
Cc Jeff McGee <[email protected]>

-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw
Quoted 13 lines · Chris Wilson
Quoted 12 lines · Arun Siluvery

Pooled EU is a bxt only feature and kernel changes are already merged. This feature is not yet exposed to userspace as the support was not yet available. Beignet team expressed interest and added patches to use this.

Since we now have a user and patches to use them, expose them from the kernel side as well.

v2: fix compile error

[1] https://lists.freedesktop.org/archives/beignet/2016-June/007698.html
[2] https://lists.freedesktop.org/archives/beignet/2016-June/007699.html

Quoted 8 lines
Quoted 6 lines
Cc Winiarski, Michal <[email protected]>
Cc Zou, Nanhai <[email protected]>
Cc Yang, Rong R <[email protected]>
Cc Tim Gore <[email protected]>
Cc Jeff McGee <[email protected]>

-Chris

Thanks Chris.

Daniel, Tvrtko,

Could you please check this and merge?

regards
Arun

Quoted 1 line

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
Quoted 22 lines · Arun Siluvery
Quoted 21 lines · Chris Wilson
Quoted 20 lines · Arun Siluvery

Pooled EU is a bxt only feature and kernel changes are already merged. This
feature is not yet exposed to userspace as the support was not yet available. Beignet team expressed interest and added patches to use this.

Since we now have a user and patches to use them, expose them from the kernel side as well.

v2: fix compile error

[1] https://lists.freedesktop.org/archives/beignet/2016-June/007698.html
[2] https://lists.freedesktop.org/archives/beignet/2016-June/007699.html

Cc Winiarski, Michal <[email protected]>
Cc Zou, Nanhai <[email protected]>
Cc Yang, Rong R <[email protected]>
Cc Tim Gore <[email protected]>
Cc Jeff McGee <[email protected]>
Quoted 8 lines
Quoted 2 lines

-Chris

Thanks Chris.

Daniel, Tvrtko,

Could you please check this and merge?

Merged to dinq with Jani's ack.

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

✓ Ro.CI.BAT: success for drm/i915/bxt: Export pooled eu info to userspace (rev2)

In reply to Arun Siluvery
== Series Details ==

== Series Details ==

Series: drm/i915/bxt: Export pooled eu info to userspace (rev2)
URL : https://patchwork.freedesktop.org/series/9367/
State : success

== Summary ==

Series 9367v2 drm/i915/bxt: Export pooled eu info to userspace
http://patchwork.freedesktop.org/api/1.0/series/9367/revisions/2/mbox

Test kms_pipe_crc_basic:

        Subgroup nonblocking-crc-pipe-b:
                skip       -> PASS       (fi-skl-i5-6260u)
        Subgroup suspend-read-crc-pipe-c:
                incomplete -> PASS       (fi-hsw-i7-4770k)
fi-hsw-i7-4770k  total:229  pass:196  dwarn:0   dfail:0   fail:0   skip:33 
fi-kbl-qkkr      total:229  pass:160  dwarn:28  dfail:1   fail:0   skip:40 
fi-skl-i5-6260u  total:229  pass:204  dwarn:0   dfail:0   fail:0   skip:25 
fi-skl-i7-6700k  total:229  pass:190  dwarn:0   dfail:0   fail:0   skip:39 
fi-snb-i7-2600   total:229  pass:176  dwarn:0   dfail:0   fail:0   skip:53 
ro-bdw-i7-5557U  total:229  pass:204  dwarn:1   dfail:1   fail:0   skip:23 
ro-bdw-i7-5600u  total:229  pass:190  dwarn:0   dfail:1   fail:0   skip:38 
ro-bsw-n3050     total:229  pass:177  dwarn:0   dfail:1   fail:2   skip:49 
ro-byt-n2820     total:229  pass:180  dwarn:0   dfail:1   fail:3   skip:45 
ro-hsw-i3-4010u  total:229  pass:197  dwarn:0   dfail:1   fail:0   skip:31 
ro-hsw-i7-4770r  total:229  pass:197  dwarn:0   dfail:1   fail:0   skip:31 
ro-ilk-i7-620lm  total:229  pass:157  dwarn:0   dfail:1   fail:1   skip:70 
ro-ilk1-i5-650   total:224  pass:157  dwarn:0   dfail:1   fail:1   skip:65 
ro-ivb-i7-3770   total:229  pass:188  dwarn:0   dfail:1   fail:0   skip:40 
ro-ivb2-i7-3770  total:229  pass:192  dwarn:0   dfail:1   fail:0   skip:36 
ro-skl3-i5-6260u total:229  pass:208  dwarn:1   dfail:1   fail:0   skip:19 
ro-snb-i7-2620M  total:229  pass:179  dwarn:0   dfail:1   fail:1   skip:48 

ro-bdw-i5-5250u failed to connect after reboot

Results at /archive/results/CI_IGT_test/RO_Patchwork_1357/

ee2057a drm-intel-nightly: 2016y-07m-01d-08h-52m-58s UTC integration manifest 7761c2c drm/i915/bxt: Export pooled eu info to userspace

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx