drm/mediatek/mtk_mipi_tx: checking the wrong variable
Subsystems (4)
PATCH 1/1 drm/mediatek/mtk_mipi_tx: checking the wrong variable
We should be checking "phy_provider" here not "phy".
Fixes 2e54c14e310f ('drm/mediatek: Add DSI sub driver')
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/mediatek/mtk_mipi_tx.c +1 -1
@@ -431,7 +431,7 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev)phy_set_drvdata (phy, mipi_tx); phy_provider =devm_of_phy_provider_register (dev, of_phy_simple_xlate); -if (IS_ERR (phy)) { +if (IS_ERR (phy_provider)) { ret =PTR_ERR (phy_provider);return ret; }
Quoted 5 lines · Dan Carpenter
We should be checking "
phy_provider" here not "phy".Fixes 2e54c14e310f ('drm/mediatek: Add DSI sub driver')Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Matthias Brugger <[email protected]>
Quoted 14 lines
drivers/gpu/drm/mediatek/mtk_mipi_tx.c +1
-1@@ -431,7 +431,7 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev)phy_set_drvdata (phy, mipi_tx); phy_provider =devm_of_phy_provider_register (dev, of_phy_simple_xlate); -if (IS_ERR (phy)) { +if (IS_ERR (phy_provider)) { ret =PTR_ERR (phy_provider);return ret; }
Daniel Vetter
AppliedQuoted 10 lines · Matthias Brugger
Quoted 5 lines · Dan Carpenter
We should be checking "
phy_provider" here not "phy".Fixes 2e54c14e310f ('drm/mediatek: Add DSI sub driver')Signed-off-by Dan Carpenter <[email protected]>Reviewed-by Matthias Brugger <[email protected]>
Applied to drm-misc, thanks.
-Daniel
Quoted 19 lines
Quoted 7 lines
drivers/gpu/drm/mediatek/mtk_mipi_tx.c +0
-0drivers/gpu/drm/mediatek/mtk_mipi_tx.c static int mtk_mipi_tx_probe(struct platform_device *pdev) · line 437
Quoted 8 lines
drivers/gpu/drm/mediatek/mtk_mipi_tx.c +1
-1@@ -431,7 +431,7 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev)phy_set_drvdata (phy, mipi_tx); phy_provider =devm_of_phy_provider_register (dev, of_phy_simple_xlate); -if (IS_ERR (phy)) { +if (IS_ERR (phy_provider)) { ret =PTR_ERR (phy_provider);return ret; }_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch