Skip to contentSkip to conversation

drm/amdgpu: remove unneeded conversions to bool

PATCH In review Andrew F. Davis 2 participants 3 messages Jul 1, 2016 – Jul 4, 2016

Subsystems (2)
DRM drivers Radeon and amdgpu DRM drivers
lore
Share & tools
lore

Andrew F. Davis

author
#0 lore raw

PATCH 1/2 drm/amdgpu: remove unneeded conversions to bool

Found with scripts/coccinelle/misc/boolconv.cocci.

Signed-off-by Andrew F. Davis <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c  |  8 ++++----
 drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c  |  4 ++--
 drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c |  4 ++--
 drivers/gpu/drm/amd/amdgpu/vi.c        | 14 +++++++-------
 4 files changed, 15 insertions(+), 15 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +4 -4
index 1a5cbaf..f3c8c37 100644
@@ -5144,13 +5144,13 @@ static int gfx_v8_0_set_powergating_state(void *handle,
 	case CHIP_POLARIS11:
 		if (adev->pg_flags & AMD_PG_SUPPORT_GFX_SMG)
 			polaris11_enable_gfx_static_mg_power_gating(adev,
-					state == AMD_PG_STATE_GATE ? true : false);
+					state == AMD_PG_STATE_GATE);
 		else if (adev->pg_flags & AMD_PG_SUPPORT_GFX_DMG)
 			polaris11_enable_gfx_dynamic_mg_power_gating(adev,
-					state == AMD_PG_STATE_GATE ? true : false);
+					state == AMD_PG_STATE_GATE);
 		else
 			polaris11_enable_gfx_quick_mg_power_gating(adev,
-					state == AMD_PG_STATE_GATE ? true : false);
+					state == AMD_PG_STATE_GATE);
 		break;
 	default:
 		break;

@@ -5583,7 +5583,7 @@ static int gfx_v8_0_set_clockgating_state(void *handle,
 	case CHIP_CARRIZO:
 	case CHIP_STONEY:
 		gfx_v8_0_update_gfx_clock_gating(adev,
-						 state == AMD_CG_STATE_GATE ? true : false);
+						 state == AMD_CG_STATE_GATE);
 		break;
 	default:
 		break;
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c +2 -2
index 9945d5b..6c3c730 100644
@@ -1406,9 +1406,9 @@ static int gmc_v8_0_set_clockgating_state(void *handle,
 	switch (adev->asic_type) {
 	case CHIP_FIJI:
 		fiji_update_mc_medium_grain_clock_gating(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		fiji_update_mc_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		break;
 	default:
 		break;
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c +2 -2
index 532ea88..e57cab6 100644
@@ -1547,9 +1547,9 @@ static int sdma_v3_0_set_clockgating_state(void *handle,
 	case CHIP_CARRIZO:
 	case CHIP_STONEY:
 		sdma_v3_0_update_sdma_medium_grain_clock_gating(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		sdma_v3_0_update_sdma_medium_grain_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		break;
 	default:
 		break;
drivers/gpu/drm/amd/amdgpu/vi.c +7 -7
index a65c960..d3404ef 100644
@@ -1393,22 +1393,22 @@ static int vi_common_set_clockgating_state(void *handle,
 	switch (adev->asic_type) {
 	case CHIP_FIJI:
 		vi_update_bif_medium_grain_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		vi_update_hdp_medium_grain_clock_gating(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		vi_update_hdp_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		vi_update_rom_medium_grain_clock_gating(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		break;
 	case CHIP_CARRIZO:
 	case CHIP_STONEY:
 		vi_update_bif_medium_grain_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		vi_update_hdp_medium_grain_clock_gating(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		vi_update_hdp_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		break;
 	default:
 		break;
Signature · 1 line
2.9.0
author
#1 lore raw

PATCH 2/2 drm/amd/powerplay: remove unneeded conversions to bool

Found with scripts/coccinelle/misc/boolconv.cocci.

Signed-off-by Andrew F. Davis <[email protected]>
---
 drivers/gpu/drm/amd/powerplay/amd_powerplay.c         | 2 +-
 drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/amd_powerplay.c +1 -1
index e629f8a..e5f2596 100644
@@ -299,7 +299,7 @@ static int pp_set_powergating_state(void *handle,
 
 	/* Enable/disable GFX per cu powergating through SMU */
 	return hwmgr->hwmgr_func->enable_per_cu_power_gating(hwmgr,
-			state == AMD_PG_STATE_GATE ? true : false);
+			state == AMD_PG_STATE_GATE);
 }
 
 static int pp_suspend(void *handle)
drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c +1 -1
index efb77ed..dd8050d 100644
@@ -147,7 +147,7 @@ int phm_enable_dynamic_state_management(struct pp_hwmgr *hwmgr)
 				NULL, NULL);
 	}
 
-	enabled = ret == 0 ? true : false;
+	enabled = ret == 0;
 
 	cgs_notify_dpm_enabled(hwmgr->device, enabled);
Signature · 1 line
2.9.0
#2 lore raw
In reply to Andrew F. Davis

Am 01.07.2016 um 16:22 schrieb Andrew F. Davis:

Quoted 3 lines

Found with scripts/coccinelle/misc/boolconv.cocci.

Signed-off-by Andrew F. Davis <[email protected]>

For both patches Reviewed-by: Christian König <[email protected]>.

Quoted 93 lines
---
  drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c  |  8 ++++----
  drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c  |  4 ++--
  drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c |  4 ++--
  drivers/gpu/drm/amd/amdgpu/vi.c        | 14 +++++++-------
  4 files changed, 15 insertions(+), 15 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +4 -4
index 1a5cbaf..f3c8c37 100644
@@ -5144,13 +5144,13 @@ static int gfx_v8_0_set_powergating_state(void *handle,
  	case CHIP_POLARIS11:
  		if (adev->pg_flags & AMD_PG_SUPPORT_GFX_SMG)
  			polaris11_enable_gfx_static_mg_power_gating(adev,
-					state == AMD_PG_STATE_GATE ? true : false);
+					state == AMD_PG_STATE_GATE);
  		else if (adev->pg_flags & AMD_PG_SUPPORT_GFX_DMG)
  			polaris11_enable_gfx_dynamic_mg_power_gating(adev,
-					state == AMD_PG_STATE_GATE ? true : false);
+					state == AMD_PG_STATE_GATE);
  		else
  			polaris11_enable_gfx_quick_mg_power_gating(adev,
-					state == AMD_PG_STATE_GATE ? true : false);
+					state == AMD_PG_STATE_GATE);
  		break;
  	default:
  		break;

@@ -5583,7 +5583,7 @@ static int gfx_v8_0_set_clockgating_state(void *handle,
  	case CHIP_CARRIZO:
  	case CHIP_STONEY:
  		gfx_v8_0_update_gfx_clock_gating(adev,
-						 state == AMD_CG_STATE_GATE ? true : false);
+						 state == AMD_CG_STATE_GATE);
  		break;
  	default:
  		break;
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c +2 -2
index 9945d5b..6c3c730 100644
@@ -1406,9 +1406,9 @@ static int gmc_v8_0_set_clockgating_state(void *handle,
  	switch (adev->asic_type) {
  	case CHIP_FIJI:
  		fiji_update_mc_medium_grain_clock_gating(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
  		fiji_update_mc_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
  		break;
  	default:
  		break;
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c +2 -2
index 532ea88..e57cab6 100644
@@ -1547,9 +1547,9 @@ static int sdma_v3_0_set_clockgating_state(void *handle,
  	case CHIP_CARRIZO:
  	case CHIP_STONEY:
  		sdma_v3_0_update_sdma_medium_grain_clock_gating(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
  		sdma_v3_0_update_sdma_medium_grain_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
  		break;
  	default:
  		break;
drivers/gpu/drm/amd/amdgpu/vi.c +4 -5
index a65c960..d3404ef 100644
@@ -1393,22 +1393,22 @@ static int vi_common_set_clockgating_state(void *handle,
  	switch (adev->asic_type) {
  	case CHIP_FIJI:
  		vi_update_bif_medium_grain_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
  		vi_update_hdp_medium_grain_clock_gating(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
  		vi_update_hdp_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
  		vi_update_rom_medium_grain_clock_gating(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
  		break;
  	case CHIP_CARRIZO:
  	case CHIP_STONEY:
  		vi_update_bif_medium_grain_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);

drivers/gpu/drm/amd/amdgpu/vi.c static int vi_common_set_clockgating_state(void *handle, · line 1414

Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/vi.c +3 -2
+				state == AMD_CG_STATE_GATE);
  		vi_update_hdp_medium_grain_clock_gating(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
  		vi_update_hdp_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
  		break;
  	default:
  		break;

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel