PNP: make pnpbios core explicitly non-modular
PATCH 1/1 PNP: make pnpbios core explicitly non-modular
The Kconfig currently controlling compilation of this code is:
config PNPBIOS
bool "Plug and Play BIOS support"
...meaning that it currently is not being built as a module by anyone.
Lets remove the couple traces of modularity, so that when reading the driver there is no doubt it is builtin-only.
Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit.
--- drivers/pnp/pnpbios/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/pnp/pnpbios/core.c +1 -2
@@ -46,7 +46,6 @@*/ #include <linux/types.h> -#include <linux/module.h> #include <linux/init.h> #include <linux/linkage.h> #include <linux/kernel.h>
@@ -586,6 +585,6 @@ static int __init pnpbios_thread_init(void) }/* Start the kernel thread later: */ -module_init (pnpbios_thread_init); +device_initcall (pnpbios_thread_init);EXPORT_SYMBOL (pnpbios_protocol);
Signature · 1 line
2.6.1
Rafael J. Wysocki
AppliedQuoted 7 lines · Paul Gortmaker
The
Kconfigcurrently controlling compilation of this code is:config PNPBIOS
bool "Plug and Play BIOS support"...meaning that it currently is not being built as a module by anyone.
Quoted 8 lines
Lets remove the couple traces of modularity, so that when reading the driver there is no doubt it is builtin-only.
Since
module_inittranslates todevice_initcallin the non-modular case, the init ordering remains unchanged with this commit.Cc "Rafael J. Wysocki" <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>
Applied, thanks!