Skip to contentSkip to conversation

drm/tegra: sor: Double free on error

PATCH In review Dan Carpenter 2 participants 2 messages Jul 4, 2016 – Jul 6, 2016

Subsystems (4)
DRM drivers Kernel janitors Tegra architecture support DRM drivers for NVIDIA Tegra
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 drm/tegra: sor: Double free on error

"brick" is allocated with devm_kzalloc() so freeing it with kfree() leads to a double free. We can just delete it.

Fixes a7ba8310c7f5 ('drm/tegra: sor: Implement sor1_brick clock')
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/tegra/sor.c +1 -6
index 8425eda..e750ced 100644
@@ -345,7 +345,6 @@ static struct clk *tegra_clk_sor_brick_register(struct tegra_sor *sor,
 {
 	struct tegra_clk_sor_brick *brick;
 	struct clk_init_data init;
-	struct clk *clk;
 
 	brick = devm_kzalloc(sor->dev, sizeof(*brick), GFP_KERNEL);
 	if (!brick)

@@ -361,11 +360,7 @@ static struct clk *tegra_clk_sor_brick_register(struct tegra_sor *sor,
 
 	brick->hw.init = &init;
 
-	clk = devm_clk_register(sor->dev, &brick->hw);
-	if (IS_ERR(clk))
-		kfree(brick);
-
-	return clk;
+	return devm_clk_register(sor->dev, &brick->hw);
 }
 
 static int tegra_sor_dp_train_fast(struct tegra_sor *sor,