Skip to contentSkip to conversation

staging: dgnc: remove redundant NULL check for brd

PATCH RESEND In review Daeseok Youn 1 participant 1 message Jul 6, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 7/15 staging: dgnc: remove redundant NULL check for brd

the "brd" value cannot be NULL in dgnc_finalize_board_init(). Because "brd" as a parameter of this function was already checked for NULL.

the dgnc_finalize_board_init() as a static function was called only from dgnc_found_board() function and brd->magic value was assigned once in dgnc_found_board(). So it doesn't need to check for DGNC_BOARD_MAGIC value.

---
RESEND: This patch was not merged for a long time, if there is any reason why this patch could NOT be merged into staging tree, let me know. There were no comment for this patch.
I cannot understand why this patch have to wait long time to merge. And I also sent emails to mailing-lists for reminding this patch... please let me know, what is the problem to merge this patch into staging tree.

 drivers/staging/dgnc/dgnc_driver.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/dgnc/dgnc_driver.c +0 -3
index af2e835..22257d2 100644
@@ -579,9 +579,6 @@ static int dgnc_finalize_board_init(struct dgnc_board *brd)
 {
 	int rc = 0;
 
-	if (!brd || brd->magic != DGNC_BOARD_MAGIC)
-		return -ENODEV;
-
 	if (brd->irq) {
 		rc = request_irq(brd->irq, brd->bd_ops->intr,
 				 IRQF_SHARED, "DGNC", brd);
Signature · 1 line
1.9.1