Skip to contentSkip to conversation

staging: dgnc: remove useless variable 'intr_rx'

PATCH RESEND In review Daeseok Youn 1 participant 1 message Jul 6, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 12/15 staging: dgnc: remove useless variable 'intr_rx'

The 'intr_rx' variable was used only for increasing. So the 'intr_rx' variable is not useful for this driver.

---
RESEND: This patch was not merged for a long time, if there is any reason why this patch could NOT be merged into staging tree, let me know. There were no comment for this patch.
I cannot understand why this patch have to wait long time to merge. And I also sent emails to mailing-lists for reminding this patch... please let me know, what is the problem to merge this patch into staging tree.

 drivers/staging/dgnc/dgnc_cls.c    | 1 -
 drivers/staging/dgnc/dgnc_driver.h | 1 -
 drivers/staging/dgnc/dgnc_neo.c    | 2 --
 3 files changed, 4 deletions(-)
drivers/staging/dgnc/dgnc_cls.c +0 -1
index 088b546..31fcf04 100644
@@ -584,7 +584,6 @@ static inline void cls_parse_isr(struct dgnc_board *brd, uint port)
 		/* Receive Interrupt pending */
 		if (isr & (UART_IIR_RDI | UART_IIR_RDI_TIMEOUT)) {
 			/* Read data from uart -> queue */
-			brd->intr_rx++;
 			ch->ch_intr_rx++;
 			cls_copy_data_from_uart_to_queue(ch);
 			dgnc_check_queue_flow_control(ch);
drivers/staging/dgnc/dgnc_driver.h +0 -1
index a8d823b..914130d 100644
@@ -183,7 +183,6 @@ struct dgnc_board {
 	uint		nasync;		/* Number of ports on card */
 
 	uint		irq;		/* Interrupt request number */
-	ulong		intr_rx;	/* Count of interrupts */
 
 	ulong		membase;	/* Start of base memory of the card */
 	ulong		membase_end;	/* End of base memory of the card */
drivers/staging/dgnc/dgnc_neo.c +0 -2
index 5f3eacdf..f99c0db 100644
@@ -399,7 +399,6 @@ static inline void neo_parse_isr(struct dgnc_board *brd, uint port)
 
 		if (isr & (UART_17158_IIR_RDI_TIMEOUT | UART_IIR_RDI)) {
 			/* Read data from uart -> queue */
-			brd->intr_rx++;
 			ch->ch_intr_rx++;
 			neo_copy_data_from_uart_to_queue(ch);
 
@@ -515,7 +514,6 @@ static inline void neo_parse_lsr(struct dgnc_board *brd, uint port)
 	ch->ch_cached_lsr |= linestatus;
 
 	if (ch->ch_cached_lsr & UART_LSR_DR) {
-		brd->intr_rx++;
 		ch->ch_intr_rx++;
 		/* Read data from uart -> queue */
 		neo_copy_data_from_uart_to_queue(ch);
Signature · 1 line
1.9.1