Skip to contentSkip to conversation

staging: dgnc: remove useless variable 'ch_intr_modem'

PATCH RESEND In review Daeseok Youn 1 participant 1 message Jul 6, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 13/15 staging: dgnc: remove useless variable 'ch_intr_modem'

The 'ch_intr_modem' variable was used only for increasing. So the 'ch_intr_modem' variable is not useful for this driver.

---
RESEND: This patch was not merged for a long time, if there is any reason why this patch could NOT be merged into staging tree, let me know. There were no comment for this patch.
I cannot understand why this patch have to wait long time to merge. And I also sent emails to mailing-lists for reminding this patch... please let me know, what is the problem to merge this patch into staging tree.

 drivers/staging/dgnc/dgnc_cls.c    | 9 ---------
 drivers/staging/dgnc/dgnc_driver.h | 1 -
 drivers/staging/dgnc/dgnc_neo.c    | 1 -
 3 files changed, 11 deletions(-)
drivers/staging/dgnc/dgnc_cls.c +0 -9
index 31fcf04..b9955be 100644
@@ -599,15 +599,6 @@ static inline void cls_parse_isr(struct dgnc_board *brd, uint port)
 			cls_copy_data_from_queue_to_uart(ch);
 		}
 
-		/* CTS/RTS change of state */
-		if (isr & UART_IIR_CTSRTS) {
-			ch->ch_intr_modem++;
-			/*
-			 * Don't need to do anything, the cls_parse_modem
-			 * below will grab the updated modem signals.
-			 */
-		}
-
 		/* Parse any modem signal changes */
 		cls_parse_modem(ch, readb(&ch->ch_cls_uart->msr));
 	}
drivers/staging/dgnc/dgnc_driver.h +0 -1
index 914130d..1063388 100644
@@ -377,7 +377,6 @@ struct channel_t {
 	ulong		ch_xon_sends;	/* Count of xons transmitted */
 	ulong		ch_xoff_sends;	/* Count of xoffs transmitted */
 
-	ulong		ch_intr_modem;	/* Count of interrupts */
 	ulong		ch_intr_tx;	/* Count of interrupts */
 	ulong		ch_intr_rx;	/* Count of interrupts */
 
drivers/staging/dgnc/dgnc_neo.c +0 -1
index f99c0db..9b3264c 100644
@@ -450,7 +450,6 @@ static inline void neo_parse_isr(struct dgnc_board *brd, uint port)
 			 * If we get here, this means the hardware is doing auto flow control.
 			 * Check to see whether RTS/DTR or CTS/DSR caused this interrupt.
 			 */
-			ch->ch_intr_modem++;
 			cause = readb(&ch->ch_neo_uart->mcr);
 			/* Which pin is doing auto flow? RTS or DTR? */
 			if ((cause & 0x4) = 0) {
Signature · 1 line
1.9.1