staging: dgnc: remove useless variable 'ch_intr_tx'
Subsystems (2)
PATCH RESEND 14/15 staging: dgnc: remove useless variable 'ch_intr_tx'
The 'ch_intr_tx' variable was used only for increasing. So the 'ch_intr_tx' variable is not useful for this driver.
Signed-off-by Daeseok Youn <[email protected]>
---
RESEND: This patch was not merged for a long time, if there is any reason why this patch could NOT be merged into staging tree, let me know. There were no comment for this patch.
I cannot understand why this patch have to wait long time to merge. And I also sent emails to mailing-lists for reminding this patch... please let me know, what is the problem to merge this patch into staging tree.
drivers/staging/dgnc/dgnc_cls.c | 1 - drivers/staging/dgnc/dgnc_driver.h | 1 - drivers/staging/dgnc/dgnc_neo.c | 3 --- 3 files changed, 5 deletions(-)
drivers/staging/dgnc/dgnc_cls.c +0 -1
@@ -594,7 +594,6 @@ static inline void cls_parse_isr(struct dgnc_board *brd, uint port)/* Transfer data (if any) from Write Queue -> UART. */ spin_lock_irqsave (&ch->ch_lock, flags); ch->ch_flags |= (CH_TX_FIFO_EMPTY |CH_TX_FIFO_LWM ); - ch->ch_intr_tx++;spin_unlock_irqrestore (&ch->ch_lock, flags);cls_copy_data_from_queue_to_uart (ch); }
drivers/staging/dgnc/dgnc_driver.h +0 -1
@@ -377,7 +377,6 @@ struct channel_t {ulong ch_xon_sends;/* Count of xons transmitted */ ulong ch_xoff_sends;/* Count of xoffs transmitted */ -ulong ch_intr_tx;/* Count of interrupts */ ulong ch_intr_rx;/* Count of interrupts */ /* /proc/<board>/<channel> entries */
drivers/staging/dgnc/dgnc_neo.c +0 -3
@@ -409,7 +409,6 @@ static inline void neo_parse_isr(struct dgnc_board *brd, uint port) }if (isr &UART_IIR_THRI ) { - ch->ch_intr_tx++;/* Transfer data (if any) from Write Queue -> UART. */ spin_lock_irqsave (&ch->ch_lock, flags); ch->ch_flags |= (CH_TX_FIFO_EMPTY |CH_TX_FIFO_LWM );
@@ -546,7 +545,6 @@ static inline void neo_parse_lsr(struct dgnc_board *brd, uint port) }if (linestatus &UART_LSR_THRE ) { - ch->ch_intr_tx++;spin_lock_irqsave (&ch->ch_lock, flags); ch->ch_flags |= (CH_TX_FIFO_EMPTY |CH_TX_FIFO_LWM );spin_unlock_irqrestore (&ch->ch_lock, flags);
@@ -554,7 +552,6 @@ static inline void neo_parse_lsr(struct dgnc_board *brd, uint port)/* Transfer data (if any) from Write Queue -> UART. */ neo_copy_data_from_queue_to_uart (ch); }else if (linestatus &UART_17158_TX_AND_FIFO_CLR ) { - ch->ch_intr_tx++;spin_lock_irqsave (&ch->ch_lock, flags); ch->ch_flags |= (CH_TX_FIFO_EMPTY |CH_TX_FIFO_LWM );spin_unlock_irqrestore (&ch->ch_lock, flags);
Signature · 1 line
1.9.1