staging: dgnc: remove useless variable 'ch_intr_rx'
Subsystems (2)
PATCH RESEND 15/15 staging: dgnc: remove useless variable 'ch_intr_rx'
The 'ch_intr_rx' variable was used only for increasing. So the 'ch_intr_rx' variable is not useful for this driver.
Signed-off-by Daeseok Youn <[email protected]>
---
RESEND: This patch was not merged for a long time, if there is any reason why this patch could NOT be merged into staging tree, let me know. There were no comment for this patch.
I cannot understand why this patch have to wait long time to merge. And I also sent emails to mailing-lists for reminding this patch... please let me know, what is the problem to merge this patch into staging tree.
drivers/staging/dgnc/dgnc_cls.c | 1 - drivers/staging/dgnc/dgnc_driver.h | 2 -- drivers/staging/dgnc/dgnc_neo.c | 2 -- 3 files changed, 5 deletions(-)
drivers/staging/dgnc/dgnc_cls.c +0 -1
@@ -584,7 +584,6 @@ static inline void cls_parse_isr(struct dgnc_board *brd, uint port)/* Receive Interrupt pending */ if (isr & (UART_IIR_RDI |UART_IIR_RDI_TIMEOUT )) {/* Read data from uart -> queue */ - ch->ch_intr_rx++;cls_copy_data_from_uart_to_queue (ch);dgnc_check_queue_flow_control (ch); }
drivers/staging/dgnc/dgnc_driver.h +0 -2
@@ -377,8 +377,6 @@ struct channel_t {ulong ch_xon_sends;/* Count of xons transmitted */ ulong ch_xoff_sends;/* Count of xoffs transmitted */ -ulong ch_intr_rx;/* Count of interrupts */ -/* /proc/<board>/<channel> entries */ struct proc_dir_entry *proc_entry_pointer;struct dgnc_proc_entry *dgnc_channel_table;
drivers/staging/dgnc/dgnc_neo.c +0 -2
@@ -399,7 +399,6 @@ static inline void neo_parse_isr(struct dgnc_board *brd, uint port)if (isr & (UART_17158_IIR_RDI_TIMEOUT |UART_IIR_RDI )) {/* Read data from uart -> queue */ - ch->ch_intr_rx++;neo_copy_data_from_uart_to_queue (ch);/* Call our tty layer to enforce queue flow control if needed. */
@@ -512,7 +511,6 @@ static inline void neo_parse_lsr(struct dgnc_board *brd, uint port) ch->ch_cached_lsr |= linestatus;if (ch->ch_cached_lsr &UART_LSR_DR ) { - ch->ch_intr_rx++;/* Read data from uart -> queue */ neo_copy_data_from_uart_to_queue (ch);spin_lock_irqsave (&ch->ch_lock, flags);
Signature · 1 line
1.9.1