bnxt: fix a condition
Subsystems (4)
PATCH 1/1 bnxt: fix a condition
This code generates as static checker warning because htons(ETH_P_IPV6) is always true. From the context it looks like the && was intended to be !=.
Fixes 94758f8de037 ('bnxt_en: Add GRO logic for BCM5731X chips.')
Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/broadcom/bnxt/bnxt.c +1 -1
@@ -997,7 +997,7 @@ static struct sk_buff *bnxt_gro_func_5731x(struct bnxt_tpa_info *tpa_info,* correct protocol ID, it must be a loopback packet where * the offsets are off by 4. */ -if (proto !=htons (ETH_P_IP ) && proto &&htons (ETH_P_IPV6 )) +if (proto !=htons (ETH_P_IP ) && proto !=htons (ETH_P_IPV6 )) loopback = true; }if (loopback) {
Quoted 6 lines · Dan Carpenter
This code generates as static checker warning because
htons(ETH_P_IPV6)is always true. From the context it looks like the && was intended to be !=.Fixes 94758f8de037 ('bnxt_en: Add GRO logic for BCM5731X chips.')Signed-off-by Dan Carpenter <[email protected]>
Thanks. The fix is correct.
Acked-by Michael Chan <[email protected]>
From: Dan Carpenter <[email protected]>
Date: Thu, 7 Jul 2016 11:23:09 +0300
Quoted 6 lines
This code generates as static checker warning because
htons(ETH_P_IPV6)is always true. From the context it looks like the && was intended to be !=.Fixes 94758f8de037 ('bnxt_en: Add GRO logic for BCM5731X chips.')Signed-off-by Dan Carpenter <[email protected]>
Applied.