hostfs: freeing an ERR_PTR in hostfs_fill_sb_common()

PATCH New Dan Carpenter 1 participant 1 message Jul 13, 2016

Subsystems (2)

Kernel janitors User-mode Linux (UML)

lore

Share & tools

lore

Dan Carpenter

author

2016-07-13 10:12 UTC #0 lore raw

PATCH 1/1 hostfs: freeing an ERR_PTR in hostfs_fill_sb_common()

We can't pass error pointers to kfree() or it causes an oops.

Fixes 52b209f7b848 ('get rid of hostfs_read_inode()')

Signed-off-by Dan Carpenter <[email protected]>

fs/hostfs/hostfs_kern.c +4 -3

index 5c57654..90e46cd 100644
@@ -959,10 +959,11 @@ static int hostfs_fill_sb_common(struct super_block *sb, void *d, int silent)
 
 	if (S_ISLNK(root_inode->i_mode)) {
 		char *name = follow_link(host_root_path);
-		if (IS_ERR(name))
+		if (IS_ERR(name)) {
 			err = PTR_ERR(name);
-		else
-			err = read_name(root_inode, name);
+			goto out_put;
+		}
+		err = read_name(root_inode, name);
 		kfree(name);
 		if (err)
 			goto out_put;