KVM: PPC: fix a sanity check

PATCH Applied Dan Carpenter 3 participants 3 messages Jul 14, 2016 – Sep 27, 2016

Subsystems (4)

KVM PowerPC Kernel janitors KVM PowerPC

lore

Share & tools

lore

Dan Carpenter

author

2016-07-14 10:15 UTC #0 lore raw

PATCH 1/1 KVM: PPC: fix a sanity check

We use logical negate where bitwise negate was intended. It means that we never return -EINVAL here.

Fixes ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support')

Signed-off-by Dan Carpenter <[email protected]>

arch/powerpc/kvm/booke.c +1 -1

index 02b4672..df3f270 100644
@@ -2038,7 +2038,7 @@ int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu,
 		if (type = KVMPPC_DEBUG_NONE)
 			continue;
 
-		if (type & !(KVMPPC_DEBUG_WATCH_READ |
+		if (type & ~(KVMPPC_DEBUG_WATCH_READ |
 			     KVMPPC_DEBUG_WATCH_WRITE |
 			     KVMPPC_DEBUG_BREAKPOINT))
 			return -EINVAL;

Alexander Graf

Reviewed-by on v1 1/1

2016-07-14 11:10 UTC #1 lore raw

Quoted 5 lines · Dan Carpenter

We use logical negate where bitwise negate was intended. It means that we never return -EINVAL here.
Fixes ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support')
Signed-off-by Dan Carpenter <[email protected]>

Oops :).

Reviewed-by Alexander Graf <[email protected]>

Alex

Paul Mackerras

Applied

2016-09-27 05:46 UTC #2 lore raw

In reply to Dan Carpenter

Quoted 5 lines · Dan Carpenter

We use logical negate where bitwise negate was intended. It means that we never return -EINVAL here.
Fixes ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support')
Signed-off-by Dan Carpenter <[email protected]>

Thanks, applied to kvm-ppc-next.

Paul.