blackfin: check devm_pinctrl_get() for errors

PATCH New Dan Carpenter 1 participant 1 message Jul 14, 2016

Subsystems (2)

Media (V4L/DVB) Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2016-07-14 10:18 UTC #0 lore raw

PATCH 1/1 blackfin: check devm_pinctrl_get() for errors

devm_pinctrl_get() can fail so we should check for that.

Fixes 0a6824bc10de ('[media] v4l2: blackfin: select proper pinctrl state in ppi_set_params if CONFIG_PINCTRL is enabled')

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/platform/blackfin/ppi.c +2 -0

index cff63e5..b8f3d9f 100644
@@ -214,6 +214,8 @@ static int ppi_set_params(struct ppi_if *ppi, struct ppi_params *params)
 	if (params->dlen > 24 || params->dlen <= 0)
 		return -EINVAL;
 	pctrl = devm_pinctrl_get(ppi->dev);
+	if (IS_ERR(pctrl))
+		return PTR_ERR(pctrl);
 	pstate = pinctrl_lookup_state(pctrl,
 				      pin_state[(params->dlen + 7) / 8 - 1]);
 	if (pinctrl_select_state(pctrl, pstate))