fb: adv7393: off by one in probe function

PATCH New Dan Carpenter 1 participant 1 message Jul 15, 2016

Subsystems (2)

Kernel janitors Framebuffer layer

lore

Share & tools

lore

Dan Carpenter

author

2016-07-15 11:08 UTC #0 lore raw

PATCH 1/1 fb: adv7393: off by one in probe function

This should be >= instead of >. It's a little bit clearer if we just get rid of the temporary variable and just use ARRAY_SIZE() directly.

Signed-off-by Dan Carpenter <[email protected]>

drivers/video/fbdev/bfin_adv7393fb.c +1 -2

index 8fe41ca..c846021 100644
@@ -373,7 +373,6 @@ static int bfin_adv7393_fb_probe(struct i2c_client *client,
 {
 	int ret = 0;
 	struct proc_dir_entry *entry;
-	int num_modes = ARRAY_SIZE(known_modes);
 
 	struct adv7393fb_device *fbdev = NULL;

@@ -382,7 +381,7 @@ static int bfin_adv7393_fb_probe(struct i2c_client *client,
 		return -EINVAL;
 	}
 
-	if (mode > num_modes) {
+	if (mode >= ARRAY_SIZE(known_modes)) {
 		dev_err(&client->dev, "mode %d: not supported", mode);
 		return -EFAULT;
 	}