subsystem:linux-media CVE-2016-5400
Subsystems (2)
PATCH 1/1 subsystem:linux-media CVE-2016-5400
This patch addresses CVE-2016-5400, a local DOS vulnerability caused by a memory leak in the airspy usb device driver. The vulnerability is triggered when more than 64 usb devices register with v4l2 of type VFL_TYPE_SDR or VFL_TYPE_SUBDEV.A badusb device can emulate 64 of these devices then through continual emulated connect/disconnect of the 65th device, cause the kernel to run out of RAM and crash the kernel. The vulnerability exists in kernel versions from 3.17 to current 4.7. The memory leak is caused by the probe function of the airspy driver mishandeling errors and not freeing the corresponding control structures when an error occours registering the device to v4l2 core.
--- drivers/media/usb/airspy/airspy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/usb/airspy/airspy.c +1 -1
@@ -1072,7 +1072,7 @@ static int airspy_probe(struct usb_interface *intf,if (ret) {dev_err (s->dev,"Failed to register as video device (%d)\n" , ret); - goto err_unregister_v4l2_dev; + goto err_free_controls; }dev_info (s->dev,"Registered as %s\n" ,video_device_node_name (&s->vdev));
Signature · 1 line
1.9.1
Quoted 10 lines · James Patrick-Evans
This patch addresses CVE-2016-5400, a local DOS vulnerability caused by a memory leak in the airspy usb device driver. The vulnerability is triggered when more than 64 usb devices register with v4l2 of type
VFL_TYPE_SDRor VFL_TYPE_SUBDEV.A badusb device can emulate 64 of these devices then through continual emulated connect/disconnect of the 65th device, cause the kernel to run out of RAM and crash the kernel. The vulnerability exists in kernel versions from 3.17 to current 4.7.
The memory leak is caused by the probe function of the airspy driver mishandeling errors and not freeing the corresponding control structures when an error occours registering the device to v4l2 core.
Thanks for getting this fixed!
Quoted 1 line
Signed-off-by James Patrick-Evans <[email protected]>
Quoted 19 lines
--- drivers/media/usb/airspy/airspy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/usb/airspy/airspy.c +1
-2@@ -1072,7 +1072,7 @@ static int airspy_probe(struct usb_interface *intf,if (ret) {dev_err (s->dev,"Failed to register as video device (%d)\n" , ret); - goto err_unregister_v4l2_dev; + goto err_free_controls; }dev_info (s->dev,"Registered as %s\n" ,video_device_node_name (&s->vdev)); --
Quoted 2 lines
1.9.1
-Kees
Signature · 2 lines
Kees Cook Brillo & Chrome OS Security
[fixing Mauro's email...]
Quoted 45 lines · Kees Cook
Quoted 10 lines · James Patrick-Evans
This patch addresses CVE-2016-5400, a local DOS vulnerability caused by a memory leak in the airspy usb device driver. The vulnerability is triggered when more than 64 usb devices register with v4l2 of type
VFL_TYPE_SDRor VFL_TYPE_SUBDEV.A badusb device can emulate 64 of these devices then through continual emulated connect/disconnect of the 65th device, cause the kernel to run out of RAM and crash the kernel. The vulnerability exists in kernel versions from 3.17 to current 4.7.
The memory leak is caused by the probe function of the airspy driver mishandeling errors and not freeing the corresponding control structures when an error occours registering the device to v4l2 core.Thanks for getting this fixed!
Quoted 1 line
Signed-off-by James Patrick-Evans <[email protected]>Reviewed-by Kees Cook <[email protected]>Quoted 19 lines
--- drivers/media/usb/airspy/airspy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/usb/airspy/airspy.c +1
-2@@ -1072,7 +1072,7 @@ static int airspy_probe(struct usb_interface *intf,if (ret) {dev_err (s->dev,"Failed to register as video device (%d)\n" , ret); - goto err_unregister_v4l2_dev; + goto err_free_controls; }dev_info (s->dev,"Registered as %s\n" ,video_device_node_name (&s->vdev)); --Quoted 2 lines
1.9.1
-Kees
--
Kees Cook
Brillo & Chrome OS Security
Signature · 2 lines
Kees Cook Brillo & Chrome OS Security
Quoted 4 lines · James Patrick-Evans
The memory leak is caused by the probe function of the airspy driver mishandeling errors and not freeing the corresponding control structures when an error occours registering the device to v4l2 core.
The patch causes a warning about the now unused label.
I fixed that and cleaned up the commit message, and applied the end result.
Linus