crypto: nx - off by one bug in nx_of_update_msc()
PATCH 1/1 crypto: nx - off by one bug in nx_of_update_msc()
The props->ap[] array is defined like this:
struct alg_props ap[NX_MAX_FC][NX_MAX_MODE][3];
So we can see that if msc->fc and msc->mode are = to NX_MAX_FC or NX_MAX_MODE then we're off by one.
Fixes ae0222b7289d ('powerpc/crypto: nx driver code supporting nx encryption')
Signed-off-by Dan Carpenter <[email protected]>
drivers/crypto/nx/nx.c +1 -1
@@ -392,7 +392,7 @@ static void nx_of_update_msc(struct device *dev, ((bytes_so_far +sizeof (struct msc_triplet )) <= lenp) && i < msc->triplets; i++) { -if (msc->fc >NX_MAX_FC || msc->mode >NX_MAX_MODE ) { +if (msc->fc >=NX_MAX_FC || msc->mode >=NX_MAX_MODE ) {dev_err (dev,"unknown function code/mode " "combo: %d/%d (ignored)\n" , msc->fc, msc->mode);
Herbert Xu
maintainerQuoted 9 lines · Dan Carpenter
The props->ap[] array is defined like this:
struct alg_props ap[NX_MAX_FC][NX_MAX_MODE][3];So we can see that if
msc->fcandmsc->modeare = toNX_MAX_FCorNX_MAX_MODEthen we're off by one.Fixes ae0222b7289d ('powerpc/crypto: nx driver code supporting nx encryption')Signed-off-by Dan Carpenter <[email protected]>
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt