Skip to contentSkip to conversation

arm64: Kconfig: select ALPINE_MSI only if PCI is selected

PATCH New Sudeep Holla 2 participants 4 messages Jul 22, 2016 arm64

lore
Share & tools
lore

Sudeep Holla

author
#0 lore raw

PATCH 1/1 arm64: Kconfig: select ALPINE_MSI only if PCI is selected

Even when PCI is disabled, ARCH_ALPINE selects ALPINE_MSI triggerring the following config warning:

warning: (ARCH_ALPINE) selects ALPINE_MSI which has unmet direct dependencies (PCI)

This patch makes selection of ALPINE_MSI conditional on PCI.

Cc Antoine Tenart <[email protected]>
Cc Arnd Bergmann <[email protected]>
Signed-off-by Sudeep Holla <[email protected]>
---
 arch/arm64/Kconfig.platforms | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi Arnd,

I happened to end up with a config without PCI when switching between DT and ACPI and saw the config warnings. This is against today's next, not sure if you have some fix already queued. Also I am not sure if ALPINE_MSI is must for this platform to boot in which case it needs to select PCI.

Regards,
Sudeep

arch/arm64/Kconfig.platforms +1 -1
index bb2616b16157..fd3ee3a392be 100644
@@ -8,7 +8,7 @@ config ARCH_SUNXI
 
 config ARCH_ALPINE
 	bool "Annapurna Labs Alpine platform"
-	select ALPINE_MSI
+	select ALPINE_MSI if PCI
 	help
 	  This enables support for the Annapurna Labs Alpine
 	  Soc family.

--
2.7.4

#1 lore raw

PATCH 1/1 arm64: Kconfig: select ALPINE_MSI only if PCI is selected

Hello,

Quoted 6 lines · Sudeep Holla

Even when PCI is disabled, ARCH_ALPINE selects ALPINE_MSI triggerring the following config warning:

warning: (ARCH_ALPINE) selects ALPINE_MSI which has unmet direct dependencies (PCI)

This patch makes selection of ALPINE_MSI conditional on PCI.

[...]

arch/arm64/Kconfig.platforms config ARCH_SUNXI · line 14

Quoted 11 lines
arch/arm64/Kconfig.platforms +1 -1
@@ -8,7 +8,7 @@ config ARCH_SUNXI
 
 config ARCH_ALPINE
 	bool "Annapurna Labs Alpine platform"
-	select ALPINE_MSI
+	select ALPINE_MSI if PCI
 	help
 	  This enables support for the Annapurna Labs Alpine
 	  Soc family.

ALPINE_MSI also depends on PCI_MSI (which itself depends on PCI). PCI_MSI isn't necessarily selected when PCI is, so please make the ALPINE_MSI selection conditional on PCI_MSI instead.

Thanks!

Antoine

Signature · 10 lines
Antoine T?nart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160722/01287140/attachment.sig>
author
#2 lore raw

PATCH 1/1 arm64: Kconfig: select ALPINE_MSI only if PCI is selected

Quoted 16 lines · Antoine Tenart

Hello,

Quoted 6 lines · Sudeep Holla

Even when PCI is disabled, ARCH_ALPINE selects ALPINE_MSI triggerring the following config warning:

warning: (ARCH_ALPINE) selects ALPINE_MSI which has unmet direct dependencies (PCI)

This patch makes selection of ALPINE_MSI conditional on PCI.

[...]

Quoted 4 lines
arch/arm64/Kconfig.platforms +0 -0
@@ -8,7 +8,7 @@ config ARCH_SUNXI
Quoted 9 lines

arch/arm64/Kconfig.platforms config ARCH_SUNXI · line 14

Quoted 7 lines
arch/arm64/Kconfig.platforms +1 -1
 config ARCH_ALPINE
 	bool "Annapurna Labs Alpine platform"
-	select ALPINE_MSI
+	select ALPINE_MSI if PCI
 	help
 	  This enables support for the Annapurna Labs Alpine
 	  Soc family.

ALPINE_MSI also depends on PCI_MSI (which itself depends on PCI).

ALPINE_MSI now selects PCI_MSI

Quoted 1 line

PCI_MSI isn't necessarily selected when PCI is, so please make the

Yes but ALPINE_MSI does it now as I mentioned above.

Quoted 2 lines

ALPINE_MSI selection conditional on PCI_MSI instead.

I will wait for Arnd's response if that's OK as he seem to have made some changes around this recently.

Signature · 2 lines
Regards,
Sudeep
#3 lore raw

PATCH 1/1 arm64: Kconfig: select ALPINE_MSI only if PCI is selected

Quoted 26 lines · Sudeep Holla
Quoted 15 lines · Antoine Tenart
Quoted 6 lines · Sudeep Holla

Even when PCI is disabled, ARCH_ALPINE selects ALPINE_MSI triggerring the following config warning:

warning: (ARCH_ALPINE) selects ALPINE_MSI which has unmet direct dependencies (PCI)

This patch makes selection of ALPINE_MSI conditional on PCI.

[...]

Quoted 4 lines
arch/arm64/Kconfig.platforms +0 -0
@@ -8,7 +8,7 @@ config ARCH_SUNXI
Quoted 9 lines
Quoted 7 lines

config ARCH_ALPINE
bool "Annapurna Labs Alpine platform"

arch/arm64/Kconfig.platforms +1 -1
-	select ALPINE_MSI
+	select ALPINE_MSI if PCI

help
This enables support for the Annapurna Labs Alpine Soc family.

ALPINE_MSI also depends on PCI_MSI (which itself depends on PCI).

Quoted 1 line

ALPINE_MSI now selects PCI_MSI

You're right, I didn't look at -next. As you mentioned ALPINE_MSI now selects PCI_MSI.

So,

Acked-by Antoine Tenart <[email protected]>

Thanks!

Antoine

Signature · 10 lines
Antoine T?nart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160722/0d39e839/attachment-0001.sig>