Skip to contentSkip to conversation

mips builds failing in v3.18.38 and v4.1.29

DISCUSSION Guenter Roeck 3 participants 6 messages Jul 31, 2016 – Aug 1, 2016 Stable branch

lore
Share & tools
lore
#0 lore raw

Sorry I didn't notice earlier - my 3.18/4.1 build scripts were broken.

arch/mips/kernel/setup.c: In function 'arch_mem_init':
arch/mips/kernel/setup.c:689:2: error: implicit declaration of function 'reserve_bootmem_region'

Offending commit is 1dd0964204277108e ("MIPS: Reserve nosave data for hibernation"). It fixes a bug which does not exist in 3.18 / 4.1, in turn causing all mips builds in 3.18 and 4.1 to fail.

Guenter

#1 lore raw

Hi,

I have already told Sasha that "MIPS: Reserve nosave data for hibernation" should not be backported to 4.1/3.18. But he has no response.

Huacai

------------------ Original ------------------

From:  "Guenter Roeck"<[email protected]>;
Date:  Mon, Aug 1, 2016 07:57 AM
To:  "Sasha Levin"<[email protected]>;

Cc: "stable"<[email protected]>; "[email protected]"<[email protected]>; "Huacai Chen"<[email protected]>;
Subject: mips builds failing in v3.18.38 and v4.1.29

Sorry I didn't notice earlier - my 3.18/4.1 build scripts were broken.

arch/mips/kernel/setup.c: In function 'arch_mem_init':
arch/mips/kernel/setup.c:689:2: error: implicit declaration of function 'reserve_bootmem_region'

Offending commit is 1dd0964204277108e ("MIPS: Reserve nosave data for hibernation"). It fixes a bug which does not exist in 3.18 / 4.1, in turn causing all mips builds in 3.18 and 4.1 to fail.

Guenter

#2 lore raw
Quoted 15 lines · 陈华才

Hi,

I have already told Sasha that "MIPS: Reserve nosave data for hibernation" should not be backported to 4.1/3.18. But he has no response.

Huacai

------------------ Original ------------------

From:  "Guenter Roeck"<[email protected]>;
Date:  Mon, Aug 1, 2016 07:57 AM
To:  "Sasha Levin"<[email protected]>;

Cc: "stable"<[email protected]>; "[email protected]"<[email protected]>; "Huacai Chen"<[email protected]>;
Subject: mips builds failing in v3.18.38 and v4.1.29

Sorry I didn't notice earlier - my 3.18/4.1 build scripts were broken.

Quoted 9 lines

arch/mips/kernel/setup.c: In function 'arch_mem_init':
arch/mips/kernel/setup.c:689:2: error: implicit declaration of function 'reserve_bootmem_region'

Offending commit is 1dd0964204277108e ("MIPS: Reserve nosave data for hibernation"). It fixes a bug which does not exist in 3.18 / 4.1, in turn causing all mips builds in 3.18 and 4.1 to fail.

Guenter

I'm sorry, it mush have gotten lost in the email switch. I'll revert that commit for the next stable release and hurry that up.

Thanks,
Sasha

#3 lore raw

Hi Sasha,

On Mon, Aug 01, 2016 at 10:58:31AM -0400, Levin, Alexander wrote:
[ ... ]

Quoted 11 lines
Quoted 7 lines

Offending commit is 1dd0964204277108e ("MIPS: Reserve nosave data for hibernation"). It fixes a bug which does not exist in 3.18 / 4.1, in turn causing all mips builds in 3.18 and 4.1 to fail.

Guenter

I'm sorry, it mush have gotten lost in the email switch. I'll revert that commit for the next stable release and hurry that up.

It would be great if you can also address the sparc64 problem I reported in my second e-mail.

Any chance you can add [email protected] to your release candidate announcement e-mails ? This would help making sure that I don't miss a release.

Thanks,
Guenter

#4 lore raw
Quoted 12 lines · Guenter Roeck

Hi Sasha,

On Mon, Aug 01, 2016 at 10:58:31AM -0400, Levin, Alexander wrote:
[ ... ]

Quoted 8 lines
Quoted 7 lines

Offending commit is 1dd0964204277108e ("MIPS: Reserve nosave data for hibernation"). It fixes a bug which does not exist in 3.18 / 4.1, in turn causing all mips builds in 3.18 and 4.1 to fail.

Guenter

Quoted 6 lines
Quoted 3 lines

I'm sorry, it mush have gotten lost in the email switch. I'll revert that commit for the next stable release and hurry that up.

It would be great if you can also address the sparc64 problem I reported in my second e-mail.

Yup, I reverted that commit as well.

Quoted 3 lines

Any chance you can add [email protected] to your release candidate announcement e-mails ? This would help making sure that I don't miss a release.

I actually talked with Greg about it a while back and decided to stop doing "release candidates" because I never ended up getting any reports on those. I keep getting lots of feedback on the "Added to the x.y stable kernel" mails so I rely on those for now.

I'll add that mail to the cover letter I send out when I do those, which is essentially equivalent (and actually gives more time) if that sounds ok to you.

Thanks,
Sasha

#5 lore raw
Quoted 22 lines · Alexander
Quoted 12 lines · Guenter Roeck

Hi Sasha,

On Mon, Aug 01, 2016 at 10:58:31AM -0400, Levin, Alexander wrote:
[ ... ]

Quoted 8 lines
Quoted 7 lines

Offending commit is 1dd0964204277108e ("MIPS: Reserve nosave data for hibernation"). It fixes a bug which does not exist in 3.18 / 4.1, in turn causing all mips builds in 3.18 and 4.1 to fail.

Guenter

Quoted 6 lines
Quoted 3 lines

I'm sorry, it mush have gotten lost in the email switch. I'll revert that commit for the next stable release and hurry that up.

It would be great if you can also address the sparc64 problem I reported in my second e-mail.

Yup, I reverted that commit as well.

Quoted 9 lines
Quoted 3 lines

Any chance you can add [email protected] to your release candidate announcement e-mails ? This would help making sure that I don't miss a release.

I actually talked with Greg about it a while back and decided to stop doing "release candidates" because I never ended up getting any reports on those. I keep getting lots of feedback on the "Added to the x.y stable kernel" mails so I rely on those for now.

If you didn't get feedback from me, it was because I never got those e-mails ;-).

Quoted 4 lines

I'll add that mail to the cover letter I send out when I do those, which is essentially equivalent (and actually gives more time) if that sounds ok to you.

Sure, that would help.

Thanks,
Guenter