Replace numeric parameter like 0444 with macro

PATCH NAK Baole Ni 1 participant 1 message Aug 2, 2016 Media (V4L/DVB)

Share & tools

Baole Ni

author

2016-08-02 16:27 UTC #0 lore raw

PATCH 614/1285 Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by Chuansheng Liu <[email protected]>

Signed-off-by Baole Ni <[email protected]>

---
 drivers/media/usb/dvb-usb/technisat-usb2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/media/usb/dvb-usb/technisat-usb2.c +2 -2

index d9f3262..f53a861 100644
@@ -40,7 +40,7 @@
 DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr);
 
 static int debug;
-module_param(debug, int, 0644);
+module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(debug,
 		"set debugging level (bit-mask: 1=info,2=eeprom,4=i2c,8=rc)." \
 		DVB_USB_DEBUG_STATUS);

@@ -48,7 +48,7 @@ MODULE_PARM_DESC(debug,
 /* disables all LED control command and
  * also does not start the signal polling thread */
 static int disable_led_control;
-module_param(disable_led_control, int, 0444);
+module_param(disable_led_control, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(disable_led_control,
 		"disable LED control of the device "
 		"(default: 0 - LED control is active).");

Signature · 1 line

2.9.2