Skip to contentSkip to conversation

Replace numeric parameter like 0444 with macro

PATCH NAK Baole Ni 1 participant 1 message Aug 2, 2016

Subsystems (2)
x86 platform drivers Acer WMI laptop extras
lore
Share & tools
lore

Baole Ni

author
#0 lore raw

PATCH 840/1285 Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by Chuansheng Liu <[email protected]>
Signed-off-by Baole Ni <[email protected]>
---
 drivers/platform/x86/acer-wmi.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/platform/x86/acer-wmi.c +5 -5
index 79d64ea..be9b00a 100644
@@ -233,11 +233,11 @@ static bool has_type_aa;
 static u16 commun_func_bitmap;
 static u8 commun_fn_key_number;
 
-module_param(mailled, int, 0444);
-module_param(brightness, int, 0444);
-module_param(threeg, int, 0444);
-module_param(force_series, int, 0444);
-module_param(ec_raw_mode, bool, 0444);
+module_param(mailled, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(brightness, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(threeg, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(force_series, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(ec_raw_mode, bool, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(mailled, "Set initial state of Mail LED");
 MODULE_PARM_DESC(brightness, "Set initial LCD backlight brightness");
 MODULE_PARM_DESC(threeg, "Set initial state of 3G hardware");
Signature · 1 line
2.9.2