ALSA: hda: Fix krealloc() with __GFP_ZERO usage
PATCH 1/1 ALSA: hda: Fix krealloc() with __GFP_ZERO usage
krealloc() doesn't work always properly with __GFP_ZERO flag as expected. For clearing the reallocated area, we need to clear explicitly instead.
Reported-by Joe Perches <[email protected]>
Cc <[email protected]>
Signed-off-by Takashi Iwai <[email protected]>
--- sound/hda/array.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
sound/hda/array.c +3 -1
@@ -21,13 +21,15 @@ void *snd_array_new(struct snd_array *array)return NULL ;if (array->used >= array->alloced) {int num = array->alloced + array->alloc_align; +int oldsize = array->alloced * array->elem_size;int size = (num +1 ) * array->elem_size;void *nlist;if (snd_BUG_ON (num >=4096 ))return NULL ; - nlist =krealloc (array->list, size,GFP_KERNEL | __GFP_ZERO); + nlist =krealloc (array->list, size,GFP_KERNEL );if (!nlist)return NULL ; +memset (nlist + oldsize,0 , size - oldsize); array->list = nlist; array->alloced = num; }
Signature · 1 line
2.9.2