drm/amdgpu: Fix memory trashing if UVD ring test fails
Subsystems (2)
PATCH 1/1 drm/amdgpu: Fix memory trashing if UVD ring test fails
fence_put was called on an uninitialized variable.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +2 -1
@@ -1187,7 +1187,8 @@ int amdgpu_uvd_ring_test_ib(struct amdgpu_ring *ring, long timeout) r =0 ; } -error:fence_put (fence); + +error:return r; }
Signature · 6 lines
2.9.2 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20160803183942.5223-1-jay-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org
Am 03.08.2016 um 20:39 schrieb Jay Cornwall:
Quoted 3 lines
fence_putwas called on an uninitialized variable.Signed-off-by Jay Cornwall <[email protected]>
Good catch, patch is Reviewed-by: Christian König <[email protected]>
Regards,
Christian.
Quoted 9 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c int amdgpu_uvd_ring_test_ib(struct amdgpu_ring *ring, long timeout) · line 1194
Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +2
-1@@ -1187,7 +1187,8 @@ int amdgpu_uvd_ring_test_ib(struct amdgpu_ring *ring, long timeout) r =0 ; } -error:fence_put (fence); + +error:return r; }
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 3 lines · Jay Cornwall
fence_putwas called on an uninitialized variable.Signed-off-by Jay Cornwall <[email protected]>
Can you commit this internally or do you need one of us to?
Alex
Quoted 21 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +2
-2@@ -1187,7 +1187,8 @@ int amdgpu_uvd_ring_test_ib(struct amdgpu_ring *ring, long timeout) r =0 ; } -error:fence_put (fence); + +error:return r; } --2.9.2
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CADnq5_M6GO_=TNkOvnoP-2sUe+SK8Y8Za+FrY3+z=7Xc7fOQRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Quoted 8 lines · Alex Deucher
Quoted 3 lines · Jay Cornwall
fence_putwas called on an uninitialized variable.Signed-off-by Jay Cornwall <[email protected]>Can you commit this internally or do you need one of us to?
Alex
I'm less familiar with the amdgpu branches. You could point me to the right one or commit this from your side.
Quoted 26 lines
Quoted 26 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +2
-1@@ -1187,7 +1187,8 @@ int amdgpu_uvd_ring_test_ib(struct amdgpu_ring *ring, long timeout) r =0 ; } -error:fence_put (fence); + +error:return r;}
--
2.9.2_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Signature · 5 lines
Jay Cornwall _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): b89701da636205926be55f2bf0896190-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org
Quoted 12 lines
-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Jay Cornwall
Sent: Wednesday, August 10, 2016 12:49 PM
To: Alex Deucher
Cc: Kuehling, Felix; amd-gfx list
Subject: Re: [PATCH] drm/amdgpu: Fix memory trashing if UVD ring test failsQuoted 3 lines · Alex Deucher
Quoted 2 lines · Jay Cornwall
fence_putwas called on an uninitialized variable.
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Jay Cornwall <[email protected]>Can you commit this internally or do you need one of us to?
Alex
I'm less familiar with the amdgpu branches. You could point me to the right one or commit this from your side.
amd-staging-4.6
I'll commit this unless you beat me to it.
Alex
Quoted 25 lines
Quoted 11 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c int amdgpu_uvd_ring_test_ib(struct
Quoted 11 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +0
-0@@ -1187,7 +1187,8 @@ int amdgpu_uvd_ring_test_ib(struct
amdgpu_ringQuoted 13 lines
Quoted 13 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +2
-1*ring, long timeout) r =0 ; } -error:fence_put (fence); + +error:return r;}
--
2.9.2
Quoted 11 lines
Quoted 4 lines
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx--
Jay Cornwall
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx