Skip to contentSkip to conversation

i40e: remove a stray unlock

PATCH New Dan Carpenter 2 participants 2 messages Aug 3, 2016 – Aug 11, 2016

Subsystems (4)
Networking Network drivers Kernel janitors Intel Ethernet
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 i40e: remove a stray unlock

We shifted the locking around a bit but forgot to delete this unlock so now it can unlock twice.

Fixes cd3be169a5ff ('i40e: Move the mutex lock in i40e_client_unregister')
Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/intel/i40e/i40e_client.c +0 -1
index e1370c5..1a9682f 100644
@@ -990,7 +990,6 @@ int i40e_unregister_client(struct i40e_client *client)
 	if (!i40e_client_is_registered(client)) {
 		pr_info("i40e: Client %s has not been registered\n",
 			client->name);
-		mutex_unlock(&i40e_client_mutex);
 		ret = -ENODEV;
 		goto out;
 	}
#1 lore raw

PATCH 1/1 i40e: remove a stray unlock

Quoted 10 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Dan Carpenter
Sent: Wednesday, August 03, 2016 12:01 PM
To: Kirsher, Jeffrey T <[email protected]>; Catherine Sullivan <[email protected]>
Cc: netdev at vger.kernel.org; kernel-janitors at vger.kernel.org; intel-wired- lan at lists.osuosl.org
Subject: [Intel-wired-lan] [patch] i40e: remove a stray unlock

Quoted 5 lines

We shifted the locking around a bit but forgot to delete this unlock so now it can unlock twice.

Fixes cd3be169a5ff ('i40e: Move the mutex lock in i40e_client_unregister')
Signed-off-by Dan Carpenter <[email protected]>
Tested-by Andrew Bowers <[email protected]>