Skip to contentSkip to conversation

fcoe: use kfree_skb() to free an skb

PATCH In review Dan Carpenter 2 participants 2 messages Aug 4, 2016

Subsystems (3)
SCSI Kernel janitors FCoE subsystem (libfc, libfcoe, fcoe)
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 fcoe: use kfree_skb() to free an skb

This should be doing kfree_skb() instead of kfree().

Fixes 9a6cf881df02 ('fcoe: implement FIP VLAN responder')
Signed-off-by Dan Carpenter <[email protected]>
drivers/scsi/fcoe/fcoe_ctlr.c +1 -1
index a569c65..dcf3653 100644
@@ -2923,7 +2923,7 @@ static int fcoe_ctlr_vlan_recv(struct fcoe_ctlr *fip, struct sk_buff *skb)
 	mutex_unlock(&fip->ctlr_mutex);
 
 drop:
-	kfree(skb);
+	kfree_skb(skb);
 	return rc;
 }
#1 lore raw
Quoted 19 lines · Dan Carpenter

This should be doing kfree_skb() instead of kfree().

Fixes 9a6cf881df02 ('fcoe: implement FIP VLAN responder')
Signed-off-by Dan Carpenter <[email protected]>
drivers/scsi/fcoe/fcoe_ctlr.c +1 -2
index a569c65..dcf3653 100644
@@ -2923,7 +2923,7 @@ static int fcoe_ctlr_vlan_recv(struct fcoe_ctlr *fip, struct sk_buff *skb)
 	mutex_unlock(&fip->ctlr_mutex);
 
 drop:
-	kfree(skb);
+	kfree_skb(skb);
 	return rc;
 }
 
--
Quoted 3 lines

To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Hi Dan,

This was already sent by Wei Yongjun and is
https://patchwork.kernel.org/patch/9245273/. Should be queued in Martin's tree already.

Thanks,
Johannes

Signature · 10 lines
Johannes Thumshirn                                          Storage
[email protected]                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html