Skip to contentSkip to conversation

Drop last two remaining omap3 legacy board files

PATCH New Tony Lindgren 6 participants 21 messages Jun 15, 2016 – Aug 6, 2016

Subsystems (3)
lore
Share & tools
lore

Tony Lindgren

author maintainer
#0 lore raw

cover Drop last two remaining omap3 legacy board files

Hi all,

Here are two patches to drop the last remaining omap3 legacy boot files. We have device tree based booting working for these boards, and the legacy booting has been mostly kept around to validate against regressions.

Let's not touch the rest of the platform init code until around v4.9 so we can revert these two patches if needed.

Cheers,

Tony

Tony Lindgren (2):
ARM: OMAP2+: Drop legacy board file for n900
ARM: OMAP2+: Drop legacy board file for LDP

 arch/arm/mach-omap2/Kconfig                  |   12 -
 arch/arm/mach-omap2/Makefile                 |    4 -
 arch/arm/mach-omap2/board-ldp.c              |  429 ---------
 arch/arm/mach-omap2/board-rx51-peripherals.c | 1317 --------------------------
 arch/arm/mach-omap2/board-rx51-video.c       |   67 --
 arch/arm/mach-omap2/board-rx51.c             |  141 ---
 arch/arm/mach-omap2/board-rx51.h             |   11 -
 7 files changed, 1981 deletions(-)
 delete mode 100644 arch/arm/mach-omap2/board-ldp.c
 delete mode 100644 arch/arm/mach-omap2/board-rx51-peripherals.c
 delete mode 100644 arch/arm/mach-omap2/board-rx51-video.c
 delete mode 100644 arch/arm/mach-omap2/board-rx51.c
 delete mode 100644 arch/arm/mach-omap2/board-rx51.h
Signature · 1 line
2.8.1
author maintainer
#1 lore raw

PATCH 1/2 ARM: OMAP2+: Drop legacy board file for n900

Let's drop the last two remaining omap3 legacy boot board files. Let's only use the device tree based booting known to work for these two boards.

We still have two omap3 boards booting in legacy mode in addition to device tree based booting. All the other ten or so omap2+ SoCs have been booting using device tree mode only for years now. This has allowed us to get rid of quite a bit of arch/arm/mach-omap2 related platform init code in favor of dts and driver changes.

Pretty much the only remaining known users for omap3 legacy boot board files are Kevin's and Russell's boot test systems, and N900 kernel tree maintained by Pali and Ivaylo. And all of them are also supporting the device tree based booting. The legacy booting mode has been kept around mostly to verify against regressions.

As there is still a slim chance of possible other uses of the mainline kernel for these boards, let's just drop the board files for v4.8, and let's not touch the related platform init code until around v4.9 time if no issues are found. This makes it trivial for us to add back the board files with a simple revert.

---
 arch/arm/mach-omap2/Kconfig                  |    6 -
 arch/arm/mach-omap2/Makefile                 |    3 -
 arch/arm/mach-omap2/board-rx51-peripherals.c | 1317 --------------------------
 arch/arm/mach-omap2/board-rx51-video.c       |   67 --
 arch/arm/mach-omap2/board-rx51.c             |  141 ---
 arch/arm/mach-omap2/board-rx51.h             |   11 -
 6 files changed, 1545 deletions(-)
 delete mode 100644 arch/arm/mach-omap2/board-rx51-peripherals.c
 delete mode 100644 arch/arm/mach-omap2/board-rx51-video.c
 delete mode 100644 arch/arm/mach-omap2/board-rx51.c
 delete mode 100644 arch/arm/mach-omap2/board-rx51.h
arch/arm/mach-omap2/Kconfig +0 -6
index 0517f0c..3c6b070 100644
@@ -218,12 +218,6 @@ config MACH_NOKIA_N8X0
 	select MACH_NOKIA_N810
 	select MACH_NOKIA_N810_WIMAX
 
-config MACH_NOKIA_RX51
-	bool "Nokia N900 (RX-51) phone"
-	depends on ARCH_OMAP3
-	default y
-	select OMAP_PACKAGE_CBB
-
 config OMAP3_SDRC_AC_TIMING
 	bool "Enable SDRC AC timing register changes"
 	depends on ARCH_OMAP3
arch/arm/mach-omap2/Makefile +0 -3
index 04e276c..8660889 100644
@@ -230,9 +230,6 @@ obj-$(CONFIG_SOC_OMAP2420)		+= msdi.o
 obj-$(CONFIG_MACH_OMAP_GENERIC)		+= board-generic.o pdata-quirks.o
 obj-$(CONFIG_MACH_OMAP_LDP)		+= board-ldp.o
 obj-$(CONFIG_MACH_NOKIA_N8X0)		+= board-n8x0.o
-obj-$(CONFIG_MACH_NOKIA_RX51)		+= board-rx51.o sdram-nokia.o
-obj-$(CONFIG_MACH_NOKIA_RX51)		+= board-rx51-peripherals.o
-obj-$(CONFIG_MACH_NOKIA_RX51)		+= board-rx51-video.o
 
 # Platform specific device init code
 
arch/arm/mach-omap2/board-rx51-peripherals.c deleted +0 -1317

1,317 lines not on this page · raw message

arch/arm/mach-omap2/board-rx51-video.c deleted +0 -67

67 lines not on this page · raw message

arch/arm/mach-omap2/board-rx51.c deleted +0 -141

141 lines not on this page · raw message

arch/arm/mach-omap2/board-rx51.h deleted +0 -11
deleted file mode 100644
index b76f49e..0000000
@@ -1,11 +0,0 @@
-/*
- * Defines for rx51 boards
- */
-
-#ifndef _OMAP_BOARD_RX51_H
-#define _OMAP_BOARD_RX51_H
-
-extern void __init rx51_peripherals_init(void);
-extern void __init rx51_video_mem_init(void);
-
-#endif
Signature · 1 line
2.8.1
#2 lore raw

PATCH 1/2 ARM: OMAP2+: Drop legacy board file for n900

Quoted 23 lines · On Wednesday 15 June 2016 03:48:08 Tony Lindgren wrote:

Let's drop the last two remaining omap3 legacy boot board files. Let's only use the device tree based booting known to work for these two boards.

We still have two omap3 boards booting in legacy mode in addition to device tree based booting. All the other ten or so omap2+ SoCs have been booting using device tree mode only for years now. This has allowed us to get rid of quite a bit of arch/arm/mach-omap2 related platform init code in favor of dts and driver changes.

Pretty much the only remaining known users for omap3 legacy boot board files are Kevin's and Russell's boot test systems, and N900 kernel tree maintained by Pali and Ivaylo. And all of them are also supporting the device tree based booting. The legacy booting mode has been kept around mostly to verify against regressions.

As there is still a slim chance of possible other uses of the mainline kernel for these boards, let's just drop the board files for v4.8, and let's not touch the related platform init code until around v4.9 time if no issues are found. This makes it trivial for us to add back the board files with a simple revert.

Quoted 12 lines
---
 arch/arm/mach-omap2/Kconfig                  |    6 -
 arch/arm/mach-omap2/Makefile                 |    3 -
 arch/arm/mach-omap2/board-rx51-peripherals.c | 1317 --------------------------
 arch/arm/mach-omap2/board-rx51-video.c       |   67 --
 arch/arm/mach-omap2/board-rx51.c             |  141 ---
 arch/arm/mach-omap2/board-rx51.h             |   11 -
 6 files changed, 1545 deletions(-)
 delete mode 100644 arch/arm/mach-omap2/board-rx51-peripherals.c
 delete mode 100644 arch/arm/mach-omap2/board-rx51-video.c
 delete mode 100644 arch/arm/mach-omap2/board-rx51.c
 delete mode 100644 arch/arm/mach-omap2/board-rx51.h

Hi! I just quickly looked at N900 status matrix https://elinux.org/N900
and there is still one thing not finished in DT: It is slot-name for omap_hsmmc driver. So switch from legacy board code to DT is regression.

Signature · 2 lines
Pali Roh?r
pali.rohar at gmail.com
author maintainer
#3 lore raw

PATCH 1/2 ARM: OMAP2+: Drop legacy board file for n900

Hi,

Quoted 3 lines · Pali Roh?r

Hi! I just quickly looked at N900 status matrix https://elinux.org/N900
and there is still one thing not finished in DT: It is slot-name for omap_hsmmc driver. So switch from legacy board code to DT is regression.

That's fixed with the following in v4.7-rc series:

db863d896681 ("mmc: omap_hsmmc: Check if MMC slot name is passed in pdata") 10c1f7d32bf4 ("ARM: OMAP2+: n900 needs MMC slot names for legacy user space")

I think Ivaylo already also backported those to the N900 tree?

Regards,

Tony

#4 lore raw

PATCH 1/2 ARM: OMAP2+: Drop legacy board file for n900

Quoted 11 lines · On Wednesday 15 June 2016 04:02:02 Tony Lindgren wrote:

Hi,

Quoted 3 lines · Pali Roh?r

Hi! I just quickly looked at N900 status matrix https://elinux.org/N900
and there is still one thing not finished in DT: It is slot-name for omap_hsmmc driver. So switch from legacy board code to DT is regression.

That's fixed with the following in v4.7-rc series:

db863d896681 ("mmc: omap_hsmmc: Check if MMC slot name is passed in pdata") 10c1f7d32bf4 ("ARM: OMAP2+: n900 needs MMC slot names for legacy user space")

Great! Sorry, but now wiki is not fully updated with last changes and I do not have in my mind what was finished/merged and what not. It is going hard for me to track everything.

Signature · 2 lines
Pali Roh?r
pali.rohar at gmail.com
author maintainer
#5 lore raw

PATCH 1/2 ARM: OMAP2+: Drop legacy board file for n900

Quoted 8 lines · Pali Roh?r
Quoted 7 lines · On Wednesday 15 June 2016 04:02:02 Tony Lindgren wrote:

Hi,

Quoted 3 lines · Pali Roh?r

Hi! I just quickly looked at N900 status matrix https://elinux.org/N900
and there is still one thing not finished in DT: It is slot-name for omap_hsmmc driver. So switch from legacy board code to DT is regression.

Quoted 8 lines
Quoted 4 lines

That's fixed with the following in v4.7-rc series:

db863d896681 ("mmc: omap_hsmmc: Check if MMC slot name is passed in pdata") 10c1f7d32bf4 ("ARM: OMAP2+: n900 needs MMC slot names for legacy user space")

Great! Sorry, but now wiki is not fully updated with last changes and I do not have in my mind what was finished/merged and what not. It is going hard for me to track everything.

OK well maybe take one more look and then ack if no more issues.

Cheers,

Tony

author maintainer
#6 lore raw

PATCH 1/2 ARM: OMAP2+: Drop legacy board file for n900

Quoted 11 lines · Tony Lindgren
Quoted 10 lines · Pali Roh?r
Quoted 9 lines · On Wednesday 15 June 2016 04:02:02 Tony Lindgren wrote:

Hi,

Quoted 3 lines · Pali Roh?r

Hi! I just quickly looked at N900 status matrix https://elinux.org/N900
and there is still one thing not finished in DT: It is slot-name for omap_hsmmc driver. So switch from legacy board code to DT is regression.

That's fixed with the following in v4.7-rc series:

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

db863d896681 ("mmc: omap_hsmmc: Check if MMC slot name is passed in pdata") 10c1f7d32bf4 ("ARM: OMAP2+: n900 needs MMC slot names for legacy user space")

Great! Sorry, but now wiki is not fully updated with last changes and I do not have in my mind what was finished/merged and what not. It is going hard for me to track everything.

OK well maybe take one more look and then ack if no more issues.

Pali, any news on this?

Regards,

Tony

#7 lore raw

PATCH 1/2 ARM: OMAP2+: Drop legacy board file for n900

Quoted 15 lines · On Tuesday 21 June 2016 04:25:36 Tony Lindgren wrote:
Quoted 14 lines · Tony Lindgren
Quoted 13 lines · Pali Roh?r
Quoted 11 lines · On Wednesday 15 June 2016 04:02:02 Tony Lindgren wrote:

Hi,

Quoted 3 lines · Pali Roh?r

Hi! I just quickly looked at N900 status matrix https://elinux.org/N900
and there is still one thing not finished in DT: It is slot-name for omap_hsmmc driver. So switch from legacy board code to DT is regression.

That's fixed with the following in v4.7-rc series:

db863d896681 ("mmc: omap_hsmmc: Check if MMC slot name is passed in pdata") 10c1f7d32bf4 ("ARM: OMAP2+: n900 needs MMC slot names for legacy user space")

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Great! Sorry, but now wiki is not fully updated with last changes and I do not have in my mind what was finished/merged and what not. It is going hard for me to track everything.

OK well maybe take one more look and then ack if no more issues.

Pali, any news on this?

I have not looked at this deeply yet. Please give me some more time.

Signature · 2 lines
Pali Roh?r
pali.rohar at gmail.com
author maintainer
#8 lore raw

PATCH 1/2 ARM: OMAP2+: Drop legacy board file for n900

Quoted 20 lines · Pali Roh?r
Quoted 19 lines · On Tuesday 21 June 2016 04:25:36 Tony Lindgren wrote:
Quoted 18 lines · Tony Lindgren
Quoted 16 lines · Pali Roh?r
Quoted 11 lines · On Wednesday 15 June 2016 04:02:02 Tony Lindgren wrote:

Hi,

Quoted 3 lines · Pali Roh?r

Hi! I just quickly looked at N900 status matrix https://elinux.org/N900
and there is still one thing not finished in DT: It is slot-name for omap_hsmmc driver. So switch from legacy board code to DT is regression.

That's fixed with the following in v4.7-rc series:

db863d896681 ("mmc: omap_hsmmc: Check if MMC slot name is passed in pdata") 10c1f7d32bf4 ("ARM: OMAP2+: n900 needs MMC slot names for legacy user space")

Great! Sorry, but now wiki is not fully updated with last changes and I do not have in my mind what was finished/merged and what not. It is going hard for me to track everything.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

OK well maybe take one more look and then ack if no more issues.

Pali, any news on this?

I have not looked at this deeply yet. Please give me some more time.

OK I'd like to apply this series by Monday if no issues to have enough time for it in Linux next. Does that sound OK to you?

Regards,

Tony

#9 lore raw

PATCH 1/2 ARM: OMAP2+: Drop legacy board file for n900

Quoted 32 lines · On Tuesday 21 June 2016 13:32:16 Tony Lindgren wrote:
Quoted 23 lines · Pali Roh?r
Quoted 22 lines · On Tuesday 21 June 2016 04:25:36 Tony Lindgren wrote:
Quoted 21 lines · Tony Lindgren
Quoted 19 lines · Pali Roh?r
Quoted 8 lines · On Wednesday 15 June 2016 04:02:02 Tony Lindgren wrote:

Hi,

Quoted 4 lines · Pali Roh?r

Hi! I just quickly looked at N900 status matrix
https://elinux.org/N900 and there is still one thing not finished in DT: It is slot-name for omap_hsmmc driver. So switch from legacy board code to DT is regression.

Quoted 5 lines

That's fixed with the following in v4.7-rc series:

db863d896681 ("mmc: omap_hsmmc: Check if MMC slot name is passed in pdata") 10c1f7d32bf4 ("ARM: OMAP2+: n900 needs MMC slot names for legacy user space")

Great! Sorry, but now wiki is not fully updated with last changes and I do not have in my mind what was finished/merged and what not. It is going hard for me to track everything.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

OK well maybe take one more look and then ack if no more issues.

Pali, any news on this?

I have not looked at this deeply yet. Please give me some more time.

Quoted 6 lines

OK I'd like to apply this series by Monday if no issues to have enough time for it in Linux next. Does that sound OK to you?

Regards,

Tony

Ok, now I looked at it and tested current version from torvalds tree.

There is still missing fixed support for IR, but that is waiting in media tree queue for next merge window.

So after IR patches land in torvalds tree, I'm fine with dropping legacy board code for n900 and you can add my Acked-by.

Sorry that it look so long time, but Nokia N900 is omap3 device with most features & drivers.

I need to say that Nokia N900 support has good support in mainline kernel, probably the best from all mobile phones. It is almost feature complete, missing parts are: DSP, both cameras, bluetooth and RM radio.

So thanks everybody for this big improvement!

Signature · 9 lines
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160622/cd656435/attachment-0001.sig>
#10 lore raw

PATCH 1/2 ARM: OMAP2+: Drop legacy board file for n900

Hi!

Quoted 15 lines
Quoted 6 lines

OK I'd like to apply this series by Monday if no issues to have enough time for it in Linux next. Does that sound OK to you?

Regards,

Tony

Ok, now I looked at it and tested current version from torvalds tree.

There is still missing fixed support for IR, but that is waiting in media tree queue for next merge window.

So after IR patches land in torvalds tree, I'm fine with dropping legacy board code for n900 and you can add my Acked-by.

Quoted 7 lines

Sorry that it look so long time, but Nokia N900 is omap3 device with most features & drivers.

I need to say that Nokia N900 support has good support in mainline kernel, probably the best from all mobile phones. It is almost feature complete, missing parts are: DSP, both cameras, bluetooth and RM radio.

...and graphics acceleration and power management. But who needs accelerated graphics, and power management will be solved. So yes, N900 is the best phone :-).

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#11 lore raw

PATCH 1/2 ARM: OMAP2+: Drop legacy board file for n900

Quoted 5 lines · Pavel Machek

...and graphics acceleration and power management. But who needs accelerated graphics, and power management will be solved. So yes, N900 is the best phone :-).

Well, actually we have SGX out-of-tree driver working (with some glitches) with 4.7-rc, Maemo 5 needs it :)

Ivo

#12 lore raw

PATCH 1/2 ARM: OMAP2+: Drop legacy board file for n900

Quoted 9 lines · Ivaylo Dimitrov
Quoted 5 lines · Pavel Machek

...and graphics acceleration and power management. But who needs accelerated graphics, and power management will be solved. So yes, N900 is the best phone :-).

Well, actually we have SGX out-of-tree driver working (with some glitches) with 4.7-rc, Maemo 5 needs it :)

Good :-).

I'm currently playing with the camera... and I can't get the 5MPx code to work. I can only capture the photos after the resizer. Capturing small picture, resizing it to 5MPx using the resizer, and then reading that from linux works, but capturing 5MPx picture, resizing it to whatever size results in 4 copies.

I tried disabling the 5Mpx modes in the et8* driver, hoping one of them works, but it does not.

Does 5Mpx capture work for you?

Thanks,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#13 lore raw

PATCH 1/2 ARM: OMAP2+: Drop legacy board file for n900

In reply to Pali Rohár
Quoted 40 lines · Pali Roh?r
Quoted 32 lines · On Tuesday 21 June 2016 13:32:16 Tony Lindgren wrote:
Quoted 23 lines · Pali Roh?r
Quoted 22 lines · On Tuesday 21 June 2016 04:25:36 Tony Lindgren wrote:
Quoted 21 lines · Tony Lindgren
Quoted 19 lines · Pali Roh?r
Quoted 8 lines · On Wednesday 15 June 2016 04:02:02 Tony Lindgren wrote:

Hi,

Quoted 4 lines · Pali Roh?r

Hi! I just quickly looked at N900 status matrix
https://elinux.org/N900 and there is still one thing not finished in DT: It is slot-name for omap_hsmmc driver. So switch from legacy board code to DT is regression.

Quoted 5 lines

That's fixed with the following in v4.7-rc series:

db863d896681 ("mmc: omap_hsmmc: Check if MMC slot name is passed in pdata") 10c1f7d32bf4 ("ARM: OMAP2+: n900 needs MMC slot names for legacy user space")

Great! Sorry, but now wiki is not fully updated with last changes and I do not have in my mind what was finished/merged and what not. It is going hard for me to track everything.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

OK well maybe take one more look and then ack if no more issues.

Pali, any news on this?

I have not looked at this deeply yet. Please give me some more time.

Quoted 6 lines

OK I'd like to apply this series by Monday if no issues to have enough time for it in Linux next. Does that sound OK to you?

Regards,

Tony

Quoted 8 lines

Ok, now I looked at it and tested current version from torvalds tree.

There is still missing fixed support for IR, but that is waiting in media tree queue for next merge window.

So after IR patches land in torvalds tree, I'm fine with dropping legacy board code for n900 and you can add my Acked-by.

Tony asked me to repost the driver so to be included in 4.7 (or 4.8), but I am too busy lately to do it, will try to find time the next week. In the meanwhile, if somebody has time and will, feel free to repost the series for me.

Ivo

#14 lore raw

PATCH 1/2 ARM: OMAP2+: Drop legacy board file for n900

Quoted 10 lines
Quoted 4 lines

So after IR patches land in torvalds tree, I'm fine with dropping legacy board code for n900 and you can add my Acked-by.

Tony asked me to repost the driver so to be included in 4.7 (or 4.8), but I am too busy lately to do it, will try to find time the next week. In the meanwhile, if somebody has time and will, feel free to repost the series for me.

Somehow I manage to put myself together and resend the series

Ivo

author maintainer
#15 lore raw

PATCH 1/2 ARM: OMAP2+: Drop legacy board file for n900

In reply to Pali Rohár
Quoted 7 lines · Pali Roh?r

Ok, now I looked at it and tested current version from torvalds tree.

There is still missing fixed support for IR, but that is waiting in media tree queue for next merge window.

So after IR patches land in torvalds tree, I'm fine with dropping legacy board code for n900 and you can add my Acked-by.

OK thanks for looking, I'll wait until the IR patches are merged.

Quoted 8 lines

Sorry that it look so long time, but Nokia N900 is omap3 device with most features & drivers.

I need to say that Nokia N900 support has good support in mainline kernel, probably the best from all mobile phones. It is almost feature complete, missing parts are: DSP, both cameras, bluetooth and RM radio.

So thanks everybody for this big improvement!

Thank you for fixing up a big chunk of the issues!

Tony

#16 lore raw

PATCH 1/2 ARM: OMAP2+: Drop legacy board file for n900

In reply to Tony Lindgren

Hi,

Quoted 16 lines · Tony Lindgren

Let's drop the last two remaining omap3 legacy boot board files. Let's only use the device tree based booting known to work for these two boards.

We still have two omap3 boards booting in legacy mode in addition to device tree based booting. All the other ten or so omap2+ SoCs have been booting using device tree mode only for years now. This has allowed us to get rid of quite a bit of arch/arm/mach-omap2 related platform init code in favor of dts and driver changes.

Pretty much the only remaining known users for omap3 legacy boot board files are Kevin's and Russell's boot test systems, and N900 kernel tree maintained by Pali and Ivaylo. And all of them are also supporting the device tree based booting. The legacy booting mode has been kept around mostly to verify against regressions.

Quoted 7 lines

As there is still a slim chance of possible other uses of the mainline kernel for these boards, let's just drop the board files for v4.8, and let's not touch the related platform init code until around v4.9 time if no issues are found. This makes it trivial for us to add back the board files with a simple revert.

I don't remember when I last booted N900 without DT, must have been a couple of years :)

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160615/c3040af6/attachment.sig>

maintainer
#17 lore raw

PATCH 1/2 ARM: OMAP2+: Drop legacy board file for n900

In reply to Tony Lindgren

Hi,

Quoted 16 lines · Tony Lindgren

Let's drop the last two remaining omap3 legacy boot board files. Let's only use the device tree based booting known to work for these two boards.

We still have two omap3 boards booting in legacy mode in addition to device tree based booting. All the other ten or so omap2+ SoCs have been booting using device tree mode only for years now. This has allowed us to get rid of quite a bit of arch/arm/mach-omap2 related platform init code in favor of dts and driver changes.

Pretty much the only remaining known users for omap3 legacy boot board files are Kevin's and Russell's boot test systems, and N900 kernel tree maintained by Pali and Ivaylo. And all of them are also supporting the device tree based booting. The legacy booting mode has been kept around mostly to verify against regressions.

Quoted 7 lines

As there is still a slim chance of possible other uses of the mainline kernel for these boards, let's just drop the board files for v4.8, and let's not touch the related platform init code until around v4.9 time if no issues are found. This makes it trivial for us to add back the board files with a simple revert.

A.

Quoted 12 lines
---
 arch/arm/mach-omap2/Kconfig                  |    6 -
 arch/arm/mach-omap2/Makefile                 |    3 -
 arch/arm/mach-omap2/board-rx51-peripherals.c | 1317 --------------------------
 arch/arm/mach-omap2/board-rx51-video.c       |   67 --
 arch/arm/mach-omap2/board-rx51.c             |  141 ---
 arch/arm/mach-omap2/board-rx51.h             |   11 -
 6 files changed, 1545 deletions(-)
 delete mode 100644 arch/arm/mach-omap2/board-rx51-peripherals.c
 delete mode 100644 arch/arm/mach-omap2/board-rx51-video.c
 delete mode 100644 arch/arm/mach-omap2/board-rx51.c
 delete mode 100644 arch/arm/mach-omap2/board-rx51.h
author maintainer
#18 lore raw

PATCH 2/2 ARM: OMAP2+: Drop legacy board file for LDP

In reply to Tony Lindgren

Let's drop the last two remaining omap3 legacy boot board files. Let's only use the device tree based booting known to work for these two boards.

We still have two omap3 boards booting in legacy mode in addition to device tree based booting. All the other ten or so omap2+ SoCs have been booting using device tree mode only for years now. This has allowed us to get rid of quite a bit of arch/arm/mach-omap2 related platform init code in favor of dts and driver changes.

Pretty much the only remaining known users for omap3 legacy boot board files are Kevin's and Russell's boot test systems, and N900 kernel tree maintained by Pali and Ivaylo. And all of them are also supporting the device tree based booting. The legacy booting mode has been kept around mostly to verify against regressions.

As there is still a slim chance of possible other uses of the mainline kernel for these boards, let's just drop the board files for v4.8, and let's not touch the related platform init code until around v4.9 time if no issues are found. This makes it trivial for us to add back the board files with a simple revert.

---
 arch/arm/mach-omap2/Kconfig     |   6 -
 arch/arm/mach-omap2/Makefile    |   1 -
 arch/arm/mach-omap2/board-ldp.c | 429 ----------------------------------------
 3 files changed, 436 deletions(-)
 delete mode 100644 arch/arm/mach-omap2/board-ldp.c
arch/arm/mach-omap2/Kconfig +0 -6
index 3c6b070..9f15235 100644
@@ -188,12 +188,6 @@ config MACH_OMAP2_TUSB6010
 	depends on ARCH_OMAP2 && SOC_OMAP2420
 	default y if MACH_NOKIA_N8X0
 
-config MACH_OMAP_LDP
-	bool "OMAP3 LDP board"
-	depends on ARCH_OMAP3
-	default y
-	select OMAP_PACKAGE_CBB
-
 config MACH_OMAP3517EVM
 	bool "OMAP3517/ AM3517 EVM board"
 	depends on ARCH_OMAP3
arch/arm/mach-omap2/Makefile +0 -1
index 8660889..7ab35eb 100644
@@ -228,7 +228,6 @@ obj-$(CONFIG_SOC_OMAP2420)		+= msdi.o
 
 # Specific board support
 obj-$(CONFIG_MACH_OMAP_GENERIC)		+= board-generic.o pdata-quirks.o
-obj-$(CONFIG_MACH_OMAP_LDP)		+= board-ldp.o
 obj-$(CONFIG_MACH_NOKIA_N8X0)		+= board-n8x0.o
 
 # Platform specific device init code
arch/arm/mach-omap2/board-ldp.c deleted +0 -429

429 lines not on this page · raw message

Signature · 1 line
2.8.1
#19 lore raw

cover Drop last two remaining omap3 legacy board files

In reply to Tony Lindgren

Hi Tony,

Quoted 8 lines · Tony Lindgren

Here are two patches to drop the last remaining omap3 legacy boot files. We have device tree based booting working for these boards, and the legacy booting has been mostly kept around to validate against regressions.

Let's not touch the rest of the platform init code until around v4.9 so we can revert these two patches if needed.

Quoted 7 lines

Cheers,

Tony

Tony Lindgren (2):
ARM: OMAP2+: Drop legacy board file for n900
ARM: OMAP2+: Drop legacy board file for LDP

I wonder what happened to these patches. I see, that you have a omap-for-v4.8/legacy branch, which contains them. But as far as I can see its not in linux-next and it was not included in the ARM pull request.

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160805/333d6a68/attachment.sig>

author maintainer
#20 lore raw

cover Drop last two remaining omap3 legacy board files

Quoted 15 lines · Sebastian Reichel

Hi Tony,

Quoted 12 lines · Tony Lindgren

Here are two patches to drop the last remaining omap3 legacy boot files. We have device tree based booting working for these boards, and the legacy booting has been mostly kept around to validate against regressions.

Let's not touch the rest of the platform init code until around v4.9 so we can revert these two patches if needed.

Cheers,

Tony

Quoted 8 lines
Quoted 3 lines

Tony Lindgren (2):
ARM: OMAP2+: Drop legacy board file for n900
ARM: OMAP2+: Drop legacy board file for LDP

I wonder what happened to these patches. I see, that you have a omap-for-v4.8/legacy branch, which contains them. But as far as I can see its not in linux-next and it was not included in the ARM pull request.

Well I took some time off and wanted to see v4.8-rc1 work with legacy mode as we have it in few automated test systems. So I did not add them to Linux next yet. My plan is to send them right after v4.8-rc1 and wait on any further legacy code removal until v4.9.

Regards,

Tony