Skip to contentSkip to conversation

blktrace: add missing dependency on Config.in comment

PATCH New Thomas Petazzoni 2 participants 5 messages Aug 6, 2016 – Aug 7, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 blktrace: add missing dependency on Config.in comment

The BR2_PACKAGE_BLKTRACE option "depends on BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS", but this architecture dependency was not replicated in the Config.in comment. This commit fixes this inconsistency.

---
 package/blktrace/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/blktrace/Config.in +1 -0
index 958f004..c17de80 100644
@@ -12,4 +12,5 @@ config BR2_PACKAGE_BLKTRACE
 	  http://git.kernel.dk/?p=blktrace.git;a=summary
 
 comment "blktrace needs a glibc or musl toolchain"
+	depends on BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS
 	depends on !(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/2 blktrace: add missing dependency on Config.in comment

Hello,

Quoted 9 lines · Thomas Petazzoni

The BR2_PACKAGE_BLKTRACE option "depends on BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS", but this architecture dependency was not replicated in the Config.in comment. This commit fixes this inconsistency.

---
 package/blktrace/Config.in | 1 +
 1 file changed, 1 insertion(+)

Both applied.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/2 blktrace: add missing dependency on Config.in comment

In reply to Thomas Petazzoni

Thomas, All,

On 2016-08-07 00:11 +0200, Thomas Petazzoni spake thusly:

Quoted 6 lines

The BR2_PACKAGE_BLKTRACE option "depends on BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS", but this architecture dependency was not replicated in the Config.in comment. This commit fixes this inconsistency.

Regards,
Yann E. MORIN.

Quoted 21 lines
---
 package/blktrace/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/blktrace/Config.in +1 -0
index 958f004..c17de80 100644
@@ -12,4 +12,5 @@ config BR2_PACKAGE_BLKTRACE
 	  http://git.kernel.dk/?p=blktrace.git;a=summary
 
 comment "blktrace needs a glibc or musl toolchain"
+	depends on BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS
 	depends on !(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL)
Signature · 6 lines
2.7.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 2/2 blktrace: disable on PowerPC

In reply to Thomas Petazzoni

This package has been failing to build on PowerPC since March 2016, with nobody taking care of the problem, so let's disable this package on PowerPC for the time being. PowerPC is the only architecture on which blktrace fails to build currently.

Fixes:

http://autobuild.buildroot.net/results/5a673c692aeb957cd8beb2c2c10ce5fd882ba4b5/

---
 package/blktrace/Config.in | 3 +++
 1 file changed, 3 insertions(+)
package/blktrace/Config.in +3 -0
index c17de80..1b8212d 100644
@@ -3,6 +3,8 @@ config BR2_PACKAGE_BLKTRACE
 	# Uses posix_spawn()
 	depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL
 	depends on BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS
+	# issue: hidden symbol `_rest32gpr_30_x` is referenced by DSO
+	depends on !BR2_powerpc
 	select BR2_PACKAGE_LIBAIO
 	help
 	  blktrace is a block layer IO tracing mechanism which provides
@@ -13,4 +15,5 @@ config BR2_PACKAGE_BLKTRACE
 
 comment "blktrace needs a glibc or musl toolchain"
 	depends on BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS
+	depends on !BR2_powerpc
 	depends on !(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL)
Signature · 1 line
2.7.4
#4 lore raw

PATCH 2/2 blktrace: disable on PowerPC

Thomas, All,

On 2016-08-07 00:11 +0200, Thomas Petazzoni spake thusly:

Quoted 10 lines

This package has been failing to build on PowerPC since March 2016, with nobody taking care of the problem, so let's disable this package on PowerPC for the time being. PowerPC is the only architecture on which blktrace fails to build currently.

Fixes:

http://autobuild.buildroot.net/results/5a673c692aeb957cd8beb2c2c10ce5fd882ba4b5/

Regards,
Yann E. MORIN.

Quoted 30 lines
---
 package/blktrace/Config.in | 3 +++
 1 file changed, 3 insertions(+)
package/blktrace/Config.in +3 -0
index c17de80..1b8212d 100644
@@ -3,6 +3,8 @@ config BR2_PACKAGE_BLKTRACE
 	# Uses posix_spawn()
 	depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL
 	depends on BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS
+	# issue: hidden symbol `_rest32gpr_30_x` is referenced by DSO
+	depends on !BR2_powerpc
 	select BR2_PACKAGE_LIBAIO
 	help
 	  blktrace is a block layer IO tracing mechanism which provides
@@ -13,4 +15,5 @@ config BR2_PACKAGE_BLKTRACE
 
 comment "blktrace needs a glibc or musl toolchain"
 	depends on BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS
+	depends on !BR2_powerpc
 	depends on !(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL)
Signature · 6 lines
2.7.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'