Skip to contentSkip to conversation

libcofi: disable for static-only builds

PATCH New Thomas Petazzoni 2 participants 3 messages Aug 7, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libcofi: disable for static-only builds

The libcofi package unconditionally builds a shared library, so we need to make it unavailable on BR2_STATIC_LIBS=y configurations.

Fixes:

http://autobuild.buildroot.net/results/329c09bf123cd5b6dbcfff6251ba7a2c7cce50b8/

---
 package/libcofi/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)
package/libcofi/Config.in +6 -0
index e9914d6..df9ab71 100644
@@ -1,8 +1,14 @@
 config BR2_PACKAGE_LIBCOFI
 	bool "libcofi"
 	depends on BR2_arm
+	# builds a shared library
+	depends on !BR2_STATIC_LIBS
 	help
 	  A replacement for memcpy and memset functionality for the
 	  Raspberry Pi with the intention of gaining greater performance.
 
 	  https://github.com/simonjhall/copies-and-fills
+
+comment "libcofi needs a toolchain w/ dynamic library"
+	depends on BR2_arm
+	depends on BR2_STATIC_LIBS
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 libcofi: disable for static-only builds

Thomas, All,

On 2016-08-07 10:20 +0200, Thomas Petazzoni spake thusly:

Quoted 2 lines

The libcofi package unconditionally builds a shared library, so we need to make it unavailable on BR2_STATIC_LIBS=y configurations.

Given that the expected use of libcofi is via LD_PRELOAD, this makes sense.

(Technically, nothing would prevent linking with it at build time, though.)

Quoted 5 lines

Fixes:

http://autobuild.buildroot.net/results/329c09bf123cd5b6dbcfff6251ba7a2c7cce50b8/

Regards,
Yann E. MORIN.

Quoted 30 lines
---
 package/libcofi/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)
package/libcofi/Config.in +6 -0
index e9914d6..df9ab71 100644
@@ -1,8 +1,14 @@
 config BR2_PACKAGE_LIBCOFI
 	bool "libcofi"
 	depends on BR2_arm
+	# builds a shared library
+	depends on !BR2_STATIC_LIBS
 	help
 	  A replacement for memcpy and memset functionality for the
 	  Raspberry Pi with the intention of gaining greater performance.
 
 	  https://github.com/simonjhall/copies-and-fills
+
+comment "libcofi needs a toolchain w/ dynamic library"
+	depends on BR2_arm
+	depends on BR2_STATIC_LIBS
Signature · 6 lines
2.7.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author Applied
#2 lore raw

PATCH 1/1 libcofi: disable for static-only builds

In reply to Thomas Petazzoni

Hello,

Quoted 11 lines · Thomas Petazzoni

The libcofi package unconditionally builds a shared library, so we need to make it unavailable on BR2_STATIC_LIBS=y configurations.

Fixes:

http://autobuild.buildroot.net/results/329c09bf123cd5b6dbcfff6251ba7a2c7cce50b8/

---
 package/libcofi/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com