Skip to contentSkip to conversation

gcc: rename option for ARC gcc

PATCH New Thomas Petazzoni 4 participants 5 messages Aug 11, 2016 – Sep 20, 2016

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 gcc: rename option for ARC gcc

The ARC gcc version is now based on gcc 6.x and no longer gcc 4.8.x, which makes the option BR2_GCC_VERSION_4_8_ARC a bit irrelevant, as is the prompt of this option.

This commit therefore renames this option to BR2_GCC_VERSION_ARC, and adjust its prompt as well.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 Config.in.legacy                       |  7 +++++++
 package/gcc/Config.in.host             | 10 +++++-----
 package/gcc/gcc-initial/gcc-initial.mk |  2 +-
 3 files changed, 13 insertions(+), 6 deletions(-)
Config.in.legacy +7 -0
index 746b80a..892a836 100644
@@ -145,6 +145,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2016.08"
 
+config BR2_GCC_VERSION_4_8_ARC
+	bool "gcc arc option renamed"
+	select BR2_LEGACY
+	help
+	  The option is select the gcc version for the ARC
+	  architecture has been renamed to BR2_GCC_VERSION_ARC.
+
 config BR2_PACKAGE_SYSTEMD_COMPAT
 	bool "systemd compatibility libraries have been removed"
 	select BR2_LEGACY
package/gcc/Config.in.host +5 -5
index 8b2b00a..38902fe 100644
@@ -8,7 +8,7 @@ config BR2_GCC_SUPPORTS_GRAPHITE
 
 choice
 	prompt "GCC compiler Version"
-	default BR2_GCC_VERSION_4_8_ARC if BR2_arc
+	default BR2_GCC_VERSION_ARC if BR2_arc
 	default BR2_GCC_VERSION_4_9_X
 	help
 	  Select the version of gcc you wish to use.

@@ -50,12 +50,12 @@ choice
 		select BR2_GCC_SUPPORTS_GRAPHITE
 		select BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
 
-	config BR2_GCC_VERSION_4_8_ARC
-		bool "gcc 4.8-arc"
+	config BR2_GCC_VERSION_ARC
+		bool "gcc arc (6.x)"
 		# Only supported architecture
 		depends on BR2_arc
 		select BR2_GCC_NEEDS_MPC
-		select BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+		select BR2_TOOLCHAIN_GCC_AT_LEAST_6
 
 
 	config BR2_GCC_VERSION_4_9_X

@@ -107,7 +107,7 @@ config BR2_GCC_VERSION
 	default "4.9.4"     if BR2_GCC_VERSION_4_9_X
 	default "5.4.0"     if BR2_GCC_VERSION_5_X
 	default "6.1.0" if BR2_GCC_VERSION_6_X
-	default "arc-2016.09-eng008" if BR2_GCC_VERSION_4_8_ARC
+	default "arc-2016.09-eng008" if BR2_GCC_VERSION_ARC
 
 config BR2_EXTRA_GCC_CONFIG_OPTIONS
 	string "Additional gcc options"
package/gcc/gcc-initial/gcc-initial.mk +1 -1
index 1e58d8b..aa88a68 100644
@@ -29,7 +29,7 @@ HOST_GCC_INITIAL_PRE_CONFIGURE_HOOKS += HOST_GCC_CONFIGURE_SYMLINK
 # available (--with-newlib is passed, and therefore inhibit_libc is
 # defined), it tries to use the C library for the libgmon
 # library. Since it's not needed in gcc-initial, we disabled it here.
-ifeq ($(BR2_GCC_VERSION_4_8_ARC),y)
+ifeq ($(BR2_GCC_VERSION_ARC),y)
 define HOST_GCC_INITIAL_DISABLE_LIBGMON
 	$(SED) 's/crtbeginS.o libgmon.a crtg.o/crtbeginS.o crtg.o/' \
 		$(@D)/libgcc/config.host
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 gcc: rename option for ARC gcc

Hi Thomas,

Config.in.legacy endif · line 152

Quoted 5 lines · Thomas Petazzoni
Config.in.legacy +5 -0
+config BR2_GCC_VERSION_4_8_ARC
+	bool "gcc arc option renamed"
+	select BR2_LEGACY
+	help
+	  The option is select the gcc version for the ARC

Maybe: "The option that selects..."

baruch

Quoted 1 line
Config.in.legacy +1 -0
+	  architecture has been renamed to BR2_GCC_VERSION_ARC.
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 gcc: rename option for ARC gcc

In reply to Thomas Petazzoni

All seems to be ok.

Thank you for this contribution.?

Signature · 2 lines
Best regards,
Vlad Zakharov <[email protected]>
Quoted 83 lines · Thomas Petazzoni

The ARC gcc version is now based on gcc 6.x and no longer gcc 4.8.x, which makes the option BR2_GCC_VERSION_4_8_ARC a bit irrelevant, as is the prompt of this option.

This commit therefore renames this option to BR2_GCC_VERSION_ARC, and adjust its prompt as well.

Signed-off-by Thomas Petazzoni <[email protected]>

---

?Config.in.legacy???????????????????????|??7 +++++++
?package/gcc/Config.in.host?????????????| 10 +++++-----
?package/gcc/gcc-initial/gcc-initial.mk |??2 +-

?3 files changed, 13 insertions(+), 6 deletions(-)

Config.in.legacy +0 -0
index 746b80a..892a836 100644
@@ -145,6 +145,13 @@ endif

?############################################################################### ?comment "Legacy options removed in 2016.08"
?

Config.in.legacy +7 -0
+config BR2_GCC_VERSION_4_8_ARC
+	bool "gcc arc option renamed"
+	select BR2_LEGACY
+	help
+	??The option is select the gcc version for the ARC
+	??architecture has been renamed to BR2_GCC_VERSION_ARC.
+

?config BR2_PACKAGE_SYSTEMD_COMPAT
? bool "systemd compatibility libraries have been removed"
? select BR2_LEGACY

package/gcc/Config.in.host +0 -0
index 8b2b00a..38902fe 100644
@@ -8,7 +8,7 @@ config BR2_GCC_SUPPORTS_GRAPHITE

?
?choice
? prompt "GCC compiler Version"

package/gcc/Config.in.host +1 -1
-	default BR2_GCC_VERSION_4_8_ARC if BR2_arc
+	default BR2_GCC_VERSION_ARC if BR2_arc

? default BR2_GCC_VERSION_4_9_X
? help
? ??Select the version of gcc you wish to use.

package/gcc/Config.in.host +0 -0
@@ -50,12 +50,12 @@ choice

? select BR2_GCC_SUPPORTS_GRAPHITE
? select BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
?

package/gcc/Config.in.host +2 -2
-	config BR2_GCC_VERSION_4_8_ARC
-		bool "gcc 4.8-arc"
+	config BR2_GCC_VERSION_ARC
+		bool "gcc arc (6.x)"

? # Only supported architecture
? depends on BR2_arc
? select BR2_GCC_NEEDS_MPC

package/gcc/Config.in.host +1 -1
-		select BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+		select BR2_TOOLCHAIN_GCC_AT_LEAST_6

?
?
? config BR2_GCC_VERSION_4_9_X

package/gcc/Config.in.host +0 -0
@@ -107,7 +107,7 @@ config BR2_GCC_VERSION

? default "4.9.4"?????if BR2_GCC_VERSION_4_9_X
? default "5.4.0"?????if BR2_GCC_VERSION_5_X
? default "6.1.0" if BR2_GCC_VERSION_6_X

package/gcc/Config.in.host +1 -1
-	default "arc-2016.09-eng008" if BR2_GCC_VERSION_4_8_ARC
+	default "arc-2016.09-eng008" if BR2_GCC_VERSION_ARC

?
?config BR2_EXTRA_GCC_CONFIG_OPTIONS
? string "Additional gcc options"

package/gcc/gcc-initial/gcc-initial.mk +0 -0
index 1e58d8b..aa88a68 100644
@@ -29,7 +29,7 @@ HOST_GCC_INITIAL_PRE_CONFIGURE_HOOKS += HOST_GCC_CONFIGURE_SYMLINK

?# available (--with-newlib is passed, and therefore inhibit_libc is ?# defined), it tries to use the C library for the libgmon ?# library. Since it's not needed in gcc-initial, we disabled it here.

package/gcc/gcc-initial/gcc-initial.mk +1 -1
-ifeq ($(BR2_GCC_VERSION_4_8_ARC),y)
+ifeq ($(BR2_GCC_VERSION_ARC),y)

?define HOST_GCC_INITIAL_DISABLE_LIBGMON
? $(SED) 's/crtbeginS.o libgmon.a crtg.o/crtbeginS.o crtg.o/' \
? $(@D)/libgcc/config.host

#3 lore raw

PATCH 1/1 gcc: rename option for ARC gcc

In reply to Thomas Petazzoni
Quoted 19 lines · Thomas Petazzoni

The ARC gcc version is now based on gcc 6.x and no longer gcc 4.8.x, which makes the option BR2_GCC_VERSION_4_8_ARC a bit irrelevant, as is the prompt of this option.

This commit therefore renames this option to BR2_GCC_VERSION_ARC, and adjust its prompt as well.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 Config.in.legacy                       |  7 +++++++
 package/gcc/Config.in.host             | 10 +++++-----
 package/gcc/gcc-initial/gcc-initial.mk |  2 +-
 3 files changed, 13 insertions(+), 6 deletions(-)
Config.in.legacy +0 -0
index 746b80a..892a836 100644

Config.in.legacy endif · line 150

Quoted 6 lines
Config.in.legacy +3 -0
@@ -145,6 +145,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2016.08"
 
+config BR2_GCC_VERSION_4_8_ARC
+	bool "gcc arc option renamed"
+	select BR2_LEGACY

You forgot to select BR2_GCC_VERSION_ARC.

Otherwise: Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 7 lines
Config.in.legacy +4 -0
+	help
+	  The option is select the gcc version for the ARC
+	  architecture has been renamed to BR2_GCC_VERSION_ARC.
+
 config BR2_PACKAGE_SYSTEMD_COMPAT
 	bool "systemd compatibility libraries have been removed"
 	select BR2_LEGACY

[snip]

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
author
#4 lore raw

PATCH 1/1 gcc: rename option for ARC gcc

In reply to Thomas Petazzoni

Hello,

Quoted 7 lines · Thomas Petazzoni

The ARC gcc version is now based on gcc 6.x and no longer gcc 4.8.x, which makes the option BR2_GCC_VERSION_4_8_ARC a bit irrelevant, as is the prompt of this option.

This commit therefore renames this option to BR2_GCC_VERSION_ARC, and adjust its prompt as well.

Quoted 6 lines
Signed-off-by Thomas Petazzoni <[email protected]>
---
 Config.in.legacy                       |  7 +++++++
 package/gcc/Config.in.host             | 10 +++++-----
 package/gcc/gcc-initial/gcc-initial.mk |  2 +-
 3 files changed, 13 insertions(+), 6 deletions(-)

I've applied to master, after taking into account the comments made by Arnout and Baruch.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com