Skip to contentSkip to conversation

barebox: fix ARCH value for arm64

PATCH New Raphael Poggi 2 participants 5 messages Aug 12, 2016

lore
Share & tools
lore

Raphael Poggi

author
#0 lore raw

PATCH 1/1 barebox: fix ARCH value for arm64

Signed-off-by Raphael Poggi <[email protected]>
---
 boot/barebox/barebox.mk | 2 ++
 1 file changed, 2 insertions(+)
boot/barebox/barebox.mk +2 -0
index 832297e..b02751d 100644
@@ -61,6 +61,8 @@ else ifeq ($$(KERNEL_ARCH),x86_64)
 $(1)_ARCH = x86
 else ifeq ($$(KERNEL_ARCH),powerpc)
 $(1)_ARCH = ppc
+else ifeq ($$(KERNEL_ARCH), arm64)
+$(1)_ARCH = arm
 else
 $(1)_ARCH = $$(KERNEL_ARCH)
 endif
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 barebox: fix ARCH value for arm64

Hi Raphael,

Quoted 10 lines · Raphael Poggi
Signed-off-by Raphael Poggi <[email protected]>
---
 boot/barebox/barebox.mk | 2 ++
 1 file changed, 2 insertions(+)
boot/barebox/barebox.mk +0 -0
index 832297e..b02751d 100644

boot/barebox/barebox.mk else ifeq ($$(KERNEL_ARCH),x86_64) · line 64

Quoted 4 lines
boot/barebox/barebox.mk +1 -0
@@ -61,6 +61,8 @@ else ifeq ($$(KERNEL_ARCH),x86_64)
 $(1)_ARCH = x86
 else ifeq ($$(KERNEL_ARCH),powerpc)
 $(1)_ARCH = ppc
+else ifeq ($$(KERNEL_ARCH), arm64)

Redundant space before "arm64".

Also, this is only applicable to version v2016.08.0 that adds initial support for aarch64
(http://lists.infradead.org/pipermail/barebox/2016-August/027849.html). A user may set BR2_TARGET_BAREBOX_CUSTOM_VERSION to v2016.08.0+, so this may be applicable to Buildroot master.

baruch

Quoted 4 lines
boot/barebox/barebox.mk +1 -0
+$(1)_ARCH = arm
 else
 $(1)_ARCH = $$(KERNEL_ARCH)
 endif
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
author
#2 lore raw

PATCH 1/1 barebox: fix ARCH value for arm64

Hi,

2016-08-12 14:32 GMT+02:00 Baruch Siach <[email protected]>:

Quoted 8 lines

Hi Raphael,

Quoted 5 lines · Raphael Poggi
Signed-off-by Raphael Poggi <[email protected]>
---
 boot/barebox/barebox.mk | 2 ++
 1 file changed, 2 insertions(+)
Quoted 11 lines

boot/barebox/barebox.mk else ifeq ($$(KERNEL_ARCH),x86_64) · line 64

Quoted 9 lines
boot/barebox/barebox.mk +1 -0
index 832297e..b02751d 100644
@@ -61,6 +61,8 @@ else ifeq ($$(KERNEL_ARCH),x86_64)
 $(1)_ARCH = x86
 else ifeq ($$(KERNEL_ARCH),powerpc)
 $(1)_ARCH = ppc
+else ifeq ($$(KERNEL_ARCH), arm64)

Redundant space before "arm64".

Oops, will fix it.

Quoted 6 lines

Also, this is only applicable to version v2016.08.0 that adds initial support for aarch64
(http://lists.infradead.org/pipermail/barebox/2016-August/027849.html). A user may set BR2_TARGET_BAREBOX_CUSTOM_VERSION to v2016.08.0+, so this may be applicable to Buildroot master.

You mean, test ($$(KERNEL_ARCH), arm64) and also the barebox version ?

Rapha?l

Quoted 12 lines

baruch

boot/barebox/barebox.mk else ifeq ($$(KERNEL_ARCH),x86_64) · line 68

Quoted 4 lines
boot/barebox/barebox.mk +1 -0
+$(1)_ARCH = arm
 else
 $(1)_ARCH = $$(KERNEL_ARCH)
 endif

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

#3 lore raw

PATCH 1/1 barebox: fix ARCH value for arm64

Hi Rapha?l,

Quoted 3 lines · Rapha?l Poggi

2016-08-12 14:32 GMT+02:00 Baruch Siach <[email protected]>:

Quoted 2 lines · Raphael Poggi
Quoted 1 line
Signed-off-by Raphael Poggi <[email protected]>

[...]

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

+else ifeq ($$(KERNEL_ARCH), arm64)

Redundant space before "arm64".

Oops, will fix it.

Quoted 7 lines
Quoted 5 lines

Also, this is only applicable to version v2016.08.0 that adds initial support for aarch64
(http://lists.infradead.org/pipermail/barebox/2016-August/027849.html). A user may set BR2_TARGET_BAREBOX_CUSTOM_VERSION to v2016.08.0+, so this may be applicable to Buildroot master.

You mean, test ($$(KERNEL_ARCH), arm64) and also the barebox version ?

No. This patch doesn't break older Barebox versions, AFAICS. I was only wondering whether it is master stuff, or -next, since we are now post -rc1. I tend to think this patch is safe for master.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
author
#4 lore raw

PATCH 1/1 barebox: fix ARCH value for arm64

Hi,

2016-08-12 16:12 GMT+02:00 Baruch Siach <[email protected]>:

Quoted 21 lines

Hi Rapha?l,

Quoted 3 lines · Rapha?l Poggi

2016-08-12 14:32 GMT+02:00 Baruch Siach <[email protected]>:

Quoted 2 lines · Raphael Poggi
Quoted 1 line
Signed-off-by Raphael Poggi <[email protected]>

[...]

Quoted 12 lines
Quoted 3 lines
Quoted 1 line

+else ifeq ($$(KERNEL_ARCH), arm64)

Redundant space before "arm64".

Oops, will fix it.

Quoted 5 lines

Also, this is only applicable to version v2016.08.0 that adds initial support for aarch64
(http://lists.infradead.org/pipermail/barebox/2016-August/027849.html). A user may set BR2_TARGET_BAREBOX_CUSTOM_VERSION to v2016.08.0+, so this may be applicable to Buildroot master.

Quoted 5 lines
Quoted 1 line

You mean, test ($$(KERNEL_ARCH), arm64) and also the barebox version ?

No. This patch doesn't break older Barebox versions, AFAICS. I was only wondering whether it is master stuff, or -next, since we are now post -rc1. I tend to think this patch is safe for master.

Ok, I understand. I will send v2 to fix the redundant space.

Rapha?l

Quoted 7 lines

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -