Skip to contentSkip to conversation

Fix warning appearing in newer autoconf/libtool version

PATCH In review David Sommerseth 3 participants 3 messages Aug 12, 2016

lore
Share & tools
lore

David Sommerseth

author
#0 lore raw

PATCH 1/1 Fix warning appearing in newer autoconf/libtool version

The warning which appears with autoconf-2.69 with libtool-2.4.2 is:

libtoolize: Remember to add 'LT_INIT' to configure.ac.

Signed-off-by David Sommerseth <[email protected]...>
---
 configure.ac | 1 +
 1 file changed, 1 insertion(+)
configure.ac +1 -0
index 4f14ebd..69fdd99 100644
@@ -58,6 +58,7 @@ m4_define([serial_tests], [
 AM_INIT_AUTOMAKE(foreign serial_tests) dnl NB: Do not [quote] this parameter.
 AC_CANONICAL_HOST
 AC_USE_SYSTEM_EXTENSIONS
+LT_INIT
 
 AC_ARG_ENABLE(
 	[lzo],
Signature · 1 line
1.8.3.1
#1 lore raw

Hi,

Quoted 14 lines · David Sommerseth

The warning which appears with autoconf-2.69 with libtool-2.4.2 is:

libtoolize: Remember to add 'LT_INIT' to configure.ac.

Signed-off-by David Sommerseth <[email protected]...>
---
 configure.ac | 1 +
 1 file changed, 1 insertion(+)
configure.ac +0 -0
index 4f14ebd..69fdd99 100644

configure.ac m4_define([serial_tests], [ · line 61

Quoted 4 lines
configure.ac +1 -0
@@ -58,6 +58,7 @@ m4_define([serial_tests], [
 AM_INIT_AUTOMAKE(foreign serial_tests) dnl NB: Do not [quote] this parameter.
 AC_CANONICAL_HOST
 AC_USE_SYSTEM_EXTENSIONS
+LT_INIT

What does that *do*? I'm a bit wary of adding stuff to autoconf that just appears because a computer says so, especially if it smells like "more libtool", as we want *less* libtool for all but src/plugins/...

gert

Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             [email protected]...
fax: +49-89-35655025                        [email protected]...
#2 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 11 lines · Gert Doering

Hi,

Quoted 8 lines · David Sommerseth

The warning which appears with autoconf-2.69 with libtool-2.4.2 is:

libtoolize: Remember to add 'LT_INIT' to configure.ac.

Signed-off-by David Sommerseth <[email protected]...> ---

configure.ac | 1 + 1 file changed, 1 insertion(+)

Quoted 10 lines
Quoted 5 lines
configure.ac index 4f14ebd..69fdd99 renamed from configure.ac +0 -0

100644 --- a/configure.ac +++ b/configure.ac @@ -58,6 +58,7 @@ m4_define([serial_tests], [ AM_INIT_AUTOMAKE(foreign serial_tests) dnl NB: Do not [quote] this parameter. AC_CANONICAL_HOST AC_USE_SYSTEM_EXTENSIONS +LT_INIT

What does that *do*? I'm a bit wary of adding stuff to autoconf that just appears because a computer says so, especially if it smells like "more libtool", as we want *less* libtool for all but src/plugins/...

Basically a lot of basic initialization which doesn't seem to be that intrusive ... from /usr/share/aclocal/libtool.m4:

- --------------------------------------------
# LT_INIT([OPTIONS])
# ------------------
AC_DEFUN([LT_INIT],
[AC_PREREQ([2.58])dnl We use AC_INCLUDES_DEFAULT
AC_REQUIRE([AC_CONFIG_AUX_DIR_DEFAULT])dnl
AC_BEFORE([$0], [LT_LANG])dnl
AC_BEFORE([$0], [LT_OUTPUT])dnl
AC_BEFORE([$0], [LTDL_INIT])dnl
m4_require([_LT_CHECK_BUILDDIR])dnl

dnl Autoconf doesn't catch unexpanded LT_ macros by default:
m4_pattern_forbid([^_?LT_[A-Z_]+$])dnl m4_pattern_allow([^(_LT_EOF|LT_DLGLOBAL|LT_DLLAZY_OR_NOW|LT_MULTI_MODULE )$])dnl
dnl aclocal doesn't pull ltoptions.m4, ltsugar.m4, or ltversion.m4 dnl unless we require an AC_DEFUNed macro:
AC_REQUIRE([LTOPTIONS_VERSION])dnl AC_REQUIRE([LTSUGAR_VERSION])dnl AC_REQUIRE([LTVERSION_VERSION])dnl AC_REQUIRE([LTOBSOLETE_VERSION])dnl m4_require([_LT_PROG_LTMAIN])dnl

_LT_SHELL_INIT([SHELL=${CONFIG_SHELL-/bin/sh}])

dnl Parse OPTIONS
_LT_SET_OPTIONS([$0], [$1])

# This can be used to rebuild libtool when needed
LIBTOOL_DEPS="$ltmain"

# Always use our own libtool.
LIBTOOL='$(SHELL) $(top_builddir)/libtool'
AC_SUBST(LIBTOOL)dnl

_LT_SETUP

# Only expand once:
m4_define([LT_INIT])
])# LT_INIT
- --------------------------------------------

Requiring autoconf-2.58 is okay (RHEL5 ships 2.59), otherwise it sets some variables, some sanity checking and ensures other files with macros gets loaded.

I'm not stressing this patch, so if anyone wants to test them on various platforms, please do! I've tested this on CentOS 5.11, Scientific Linux 7.2 and Fedora 23.

- --
kind regards,

David Sommerseth
OpenVPN Technologies, Inc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iEYEARECAAYFAleuI1oACgkQDC186MBRfro1pgCgog1tQbATeFm6WxevXILqkLvK U+8AoI+Xh1vNx3rVE39Ez+FJt8H7EEhG
=gwjT
-----END PGP SIGNATURE-----