Skip to contentSkip to conversation

drm/amd/amdgpu: Add more config data for debugfs

PATCH In review Tom St Denis 3 participants 3 messages Aug 12, 2016 – Aug 15, 2016 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/amdgpu: Add more config data for debugfs

Adds rev_id as well as cg/pg flags to help debug runtime.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +6 -1
index 53763614c6e0..bbd3173cc5ea 100644
@@ -2653,7 +2653,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
 		return -ENOMEM;
 
 	/* version, increment each time something is added */
-	config[no_regs++] = 0;
+	config[no_regs++] = 1;
 	config[no_regs++] = adev->gfx.config.max_shader_engines;
 	config[no_regs++] = adev->gfx.config.max_tile_pipes;
 	config[no_regs++] = adev->gfx.config.max_cu_per_sh;
@@ -2678,6 +2678,11 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
 	config[no_regs++] = adev->gfx.config.gb_addr_config;
 	config[no_regs++] = adev->gfx.config.num_rbs;
 
+	/* rev==1 */
+	config[no_regs++] = adev->rev_id;
+	config[no_regs++] = adev->pg_flags;
+	config[no_regs++] = adev->cg_flags;
+
 	while (size && (*pos < no_regs * 4)) {
 		uint32_t value;
 
Signature · 6 lines
2.9.2

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Hi all,

If I could get an ACK/NAK that would be appreciated. I have a commit pending on the debug tool (that reads these) that I'd like to get out.

Thanks,

Tom

________________________________
From: Tom St Denis <[email protected]>
Sent: Friday, August 12, 2016 15:28
To: [email protected]
Cc: StDenis, Tom
Subject: [PATCH] drm/amd/amdgpu: Add more config data for debugfs

Adds rev_id as well as cg/pg flags to help debug runtime.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +6 -1
index 53763614c6e0..bbd3173cc5ea 100644
@@ -2653,7 +2653,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
                 return -ENOMEM;
 
         /* version, increment each time something is added */
-       config[no_regs++] = 0;
+       config[no_regs++] = 1;
         config[no_regs++] = adev->gfx.config.max_shader_engines;
         config[no_regs++] = adev->gfx.config.max_tile_pipes;
         config[no_regs++] = adev->gfx.config.max_cu_per_sh;
@@ -2678,6 +2678,11 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
         config[no_regs++] = adev->gfx.config.gb_addr_config;
         config[no_regs++] = adev->gfx.config.num_rbs;
 
+       /* rev==1 */
+       config[no_regs++] = adev->rev_id;
+       config[no_regs++] = adev->pg_flags;
+       config[no_regs++] = adev->cg_flags;
+
         while (size && (*pos < no_regs * 4)) {
                 uint32_t value;
 

--
2.9.2

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): DM5PR12MB1132BE10BFA7B652BD16A3E2F7120-2J9CzHegvk+UzrhdoDeimQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

#4 lore raw

Am 15.08.2016 um 14:26 schrieb StDenis, Tom:

Quoted 21 lines

Hi all,

If I could get an ACK/NAK that would be appreciated. I have a commit pending on the debug tool (that reads these) that I'd like to get out.

Thanks,

Tom

------------------------------------------------------------------------
*From:* Tom St Denis <[email protected]> *Sent:* Friday, August 12, 2016 15:28
*To:* [email protected] *Cc:* StDenis, Tom
*Subject:* [PATCH] drm/amd/amdgpu: Add more config data for debugfs Adds rev_id as well as cg/pg flags to help debug runtime.

Quoted 1 line
Quoted 40 lines
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
index 53763614c6e0..bbd3173cc5ea 100644
@@ -2653,7 +2653,7 @@ static ssize_t 
 amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
                 return -ENOMEM;
 
         /* version, increment each time something is added */
-       config[no_regs++] = 0;
+       config[no_regs++] = 1;
         config[no_regs++] = adev->gfx.config.max_shader_engines;
         config[no_regs++] = adev->gfx.config.max_tile_pipes;
         config[no_regs++] = adev->gfx.config.max_cu_per_sh;
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +5 -0
@@ -2678,6 +2678,11 @@ static ssize_t 
 amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
         config[no_regs++] = adev->gfx.config.gb_addr_config;
         config[no_regs++] = adev->gfx.config.num_rbs;
 
+       /* rev==1 */
+       config[no_regs++] = adev->rev_id;
+       config[no_regs++] = adev->pg_flags;
+       config[no_regs++] = adev->cg_flags;
+
         while (size && (*pos < no_regs * 4)) {
                 uint32_t value;
Signature · 9 lines
-- 
2.9.2



_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx