whci: Remove deprecated create_singlethread_workqueue

PATCH In review Bhaktipriya Shridhar 2 participants 2 messages Aug 13, 2016 – Aug 15, 2016 USB

lore

Share & tools

lore

Bhaktipriya Shridhar

author

2016-08-13 15:50 UTC #0 lore raw

PATCH 1/1 whci: Remove deprecated create_singlethread_workqueue

alloc_ordered_workqueue replaces the deprecated
create_singlethread_workqueue.

The workqueue "workqueue" has multiple workitems which may require ordering. Hence, a dedicated ordered workqueue has been used. Since the workqueue is not being used on a memory reclaim path, WQ_MEM_RECLAIM has not been set.

Signed-off-by Bhaktipriya Shridhar <[email protected]>

---
 drivers/usb/host/whci/init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/usb/host/whci/init.c +1 -1

index e363723..ad8eb57 100644
@@ -65,7 +65,7 @@ int whc_init(struct whc *whc)
 	init_waitqueue_head(&whc->cmd_wq);
 	init_waitqueue_head(&whc->async_list_wq);
 	init_waitqueue_head(&whc->periodic_list_wq);
-	whc->workqueue = create_singlethread_workqueue(dev_name(&whc->umc->dev));
+	whc->workqueue = alloc_ordered_workqueue(dev_name(&whc->umc->dev), 0);
 	if (whc->workqueue == NULL) {
 		ret = -ENOMEM;
 		goto error;

--
2.1.4

Tejun Heo

Acked-by on v1 1/1

2016-08-15 22:55 UTC #1 lore raw

Quoted 9 lines · Bhaktipriya Shridhar

alloc_ordered_workqueue replaces the deprecated
create_singlethread_workqueue.
The workqueue "workqueue" has multiple workitems which may require ordering. Hence, a dedicated ordered workqueue has been used. Since the workqueue is not being used on a memory reclaim path, WQ_MEM_RECLAIM has not been set.
Signed-off-by Bhaktipriya Shridhar <[email protected]>

Acked-by Tejun Heo <[email protected]>

Thanks.

Signature · 1 line

tejun