Skip to contentSkip to conversation

edac: wq: Remove deprecated create_singlethread_workqueue

PATCH Applied Bhaktipriya Shridhar 2 participants 2 messages Aug 13, 2016 – Aug 15, 2016 EDAC-core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 edac: wq: Remove deprecated create_singlethread_workqueue

alloc_ordered_workqueue() with WQ_MEM_RECLAIM set replaces deprecated create_singlethread_workqueue(). This is the identity conversion.

wq has been identity converted since it is used to detect things like ECC memory errors. It's not recommended to stall it from memory pressure. Hence, WQ_MEM_RECLAIM has been set to ensure forward progress under memory pressure.

---
 drivers/edac/wq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/edac/wq.c +1 -1
index 1b8c07e..2a9a11a 100644
@@ -27,7 +27,7 @@ EXPORT_SYMBOL_GPL(edac_stop_work);
 
 int edac_workqueue_setup(void)
 {
-	wq = create_singlethread_workqueue("edac-poller");
+	wq = alloc_ordered_workqueue("edac-poller", WQ_MEM_RECLAIM);
 	if (!wq)
 		return -ENODEV;
 	else

--
2.1.4

maintainer Applied
#1 lore raw
Quoted 9 lines · Bhaktipriya Shridhar

alloc_ordered_workqueue() with WQ_MEM_RECLAIM set replaces deprecated create_singlethread_workqueue(). This is the identity conversion.

wq has been identity converted since it is used to detect things like ECC memory errors. It's not recommended to stall it from memory pressure. Hence, WQ_MEM_RECLAIM has been set to ensure forward progress under memory pressure.

Quoted 4 lines
---
 drivers/edac/wq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Signature · 5 lines
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--