Skip to contentSkip to conversation

ARM: mach-imx: pm-imx6: add missing BM_CLPCR_BYP_MMDC_CH0_LPM_HS setting for imx6ul

PATCH New Peter Chen 3 participants 4 messages Aug 9, 2016 – Aug 15, 2016

Subsystems (4)
Stable branch Arm (32-bit) Arm sub-architectures Arm i.MX and Layerscape
lore
Share & tools
lore

Peter Chen

author
#0 lore raw

PATCH 1/1 ARM: mach-imx: pm-imx6: add missing BM_CLPCR_BYP_MMDC_CH0_LPM_HS setting for imx6ul

There is a missing BM_CLPCR_BYP_MMDC_CH0_LPM_HS setting for imx6ul, without it, the "standby" mode can't work well, the system can't be resumed.

With this commit, the "standby" mode works well.

Cc Anson Huang <[email protected]>
Cc <[email protected]>
Fixes ee4a5f838c84 ("ARM: imx: add suspend/resume support for i.mx6ul")
Signed-off-by Peter Chen <[email protected]>
---
 arch/arm/mach-imx/pm-imx6.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/pm-imx6.c +1 -1
index 58924b3..67bab74 100644
@@ -295,7 +295,7 @@ int imx6_set_lpm(enum mxc_cpu_pwr_mode mode)
 		val &= ~BM_CLPCR_SBYOS;
 		if (cpu_is_imx6sl())
 			val |= BM_CLPCR_BYPASS_PMIC_READY;
-		if (cpu_is_imx6sl() || cpu_is_imx6sx())
+		if (cpu_is_imx6sl() || cpu_is_imx6sx() || cpu_is_imx6ul())
 			val |= BM_CLPCR_BYP_MMDC_CH0_LPM_HS;
 		else
 			val |= BM_CLPCR_BYP_MMDC_CH1_LPM_HS;
Signature · 1 line
1.9.1
reviewer
#1 lore raw

PATCH 1/1 ARM: mach-imx: pm-imx6: add missing BM_CLPCR_BYP_MMDC_CH0_LPM_HS setting for imx6ul

Hi Peter,

Quoted 5 lines · Peter Chen

There is a missing BM_CLPCR_BYP_MMDC_CH0_LPM_HS setting for imx6ul, without it, the "standby" mode can't work well, the system can't be resumed.

With this commit, the "standby" mode works well.

Have you tested 'echo mem > /sys/power/state' as well?

On my tests it does a reboot rather than going to suspend.

Thanks

author
#2 lore raw

PATCH 1/1 ARM: mach-imx: pm-imx6: add missing BM_CLPCR_BYP_MMDC_CH0_LPM_HS setting for imx6ul

Quoted 7 lines · Peter Chen
Quoted 4 lines

There is a missing BM_CLPCR_BYP_MMDC_CH0_LPM_HS setting for imx6ul, without it, the "standby" mode can't work well, the system can't be resumed.

Quoted 6 lines
Quoted 1 line

With this commit, the "standby" mode works well.

Have you tested 'echo mem > /sys/power/state' as well?

On my tests it does a reboot rather than going to suspend.

It is another issue, current both 6sx and 6ul can't work for mem mode. But I just can't wake up system, reboot is not observed.

Peter

Applied
#3 lore raw

PATCH 1/1 ARM: mach-imx: pm-imx6: add missing BM_CLPCR_BYP_MMDC_CH0_LPM_HS setting for imx6ul

In reply to Peter Chen
Quoted 10 lines · Peter Chen

There is a missing BM_CLPCR_BYP_MMDC_CH0_LPM_HS setting for imx6ul, without it, the "standby" mode can't work well, the system can't be resumed.

With this commit, the "standby" mode works well.

Cc Anson Huang <[email protected]>
Cc <[email protected]>
Fixes ee4a5f838c84 ("ARM: imx: add suspend/resume support for i.mx6ul")
Signed-off-by Peter Chen <[email protected]>

Applied, thanks.