platform: intel_pmic: make gpio explicitly non-modular

PATCH Applied Paul Gortmaker 2 participants 2 messages Aug 15, 2016 – Aug 17, 2016 x86 platform drivers

lore

Share & tools

lore

Paul Gortmaker

author

2016-08-15 22:25 UTC #0 lore raw

PATCH 1/1 platform: intel_pmic: make gpio explicitly non-modular

The Kconfig entry controlling compilation of this code is:

drivers/platform/x86/Kconfig:config GPIO_INTEL_PMIC
drivers/platform/x86/Kconfig: bool "Intel PMIC GPIO support"

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple traces of modular infrastructure use, so that when reading the driver there is no doubt it is builtin-only.

We delete the MODULE_LICENSE tag etc. since all that information was (or is now) contained at the top of the file in the comments.

We don't replace module.h with init.h since the file already has that.

Cc Darren Hart <[email protected]>

Cc Alek Du <[email protected]>

Cc [email protected]

Signed-off-by Paul Gortmaker <[email protected]>

---
 drivers/platform/x86/intel_pmic_gpio.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

drivers/platform/x86/intel_pmic_gpio.c +2 -6

index 63b371d6ee55..91ae58510d92 100644
@@ -1,6 +1,8 @@
 /* Moorestown PMIC GPIO (access through IPC) driver
  * Copyright (c) 2008 - 2009, Intel Corporation.
  *
+ * Author: Alek Du <[email protected]>
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.

@@ -21,7 +23,6 @@
 
 #define pr_fmt(fmt) "%s: " fmt, __func__
 
-#include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/interrupt.h>
 #include <linux/delay.h>

@@ -322,9 +323,4 @@ static int __init platform_pmic_gpio_init(void)
 {
 	return platform_driver_register(&platform_pmic_gpio_driver);
 }
-
 subsys_initcall(platform_pmic_gpio_init);
-
-MODULE_AUTHOR("Alek Du <[email protected]>");
-MODULE_DESCRIPTION("Intel Moorestown PMIC GPIO driver");
-MODULE_LICENSE("GPL v2");

Signature · 1 line

2.8.4

Darren Hart

Applied

2016-08-17 00:23 UTC #1 lore raw

Quoted 13 lines · Paul Gortmaker

The Kconfig entry controlling compilation of this code is:
drivers/platform/x86/Kconfig:config GPIO_INTEL_PMIC
drivers/platform/x86/Kconfig: bool "Intel PMIC GPIO support"
...meaning that it currently is not being built as a module by anyone.
Lets remove the couple traces of modular infrastructure use, so that when reading the driver there is no doubt it is builtin-only.
We delete the MODULE_LICENSE tag etc. since all that information was (or is now) contained at the top of the file in the comments.

Quoted 6 lines

We don't replace module.h with init.h since the file already has that.
Cc Darren Hart <[email protected]>
Cc Alek Du <[email protected]>
Cc [email protected]
Signed-off-by Paul Gortmaker <[email protected]>

Queued to fixes for 4.8, thank you.

Signature · 2 lines

Darren Hart
Intel Open Source Technology Center