Skip to contentSkip to conversation

staging: lustre: fix bare use of 'unsigned'

PATCH In review Anson Jacob 2 participants 2 messages Aug 16, 2016 – Aug 21, 2016 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: lustre: fix bare use of 'unsigned'

fix checkpatch.pl warning
Prefer 'unsigned int' to bare use of 'unsigned'

---
 drivers/staging/lustre/lustre/include/cl_object.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/lustre/lustre/include/cl_object.h +7 -7
index 3cd4a25..db910ea 100644
@@ -367,7 +367,7 @@ struct cl_object_operations {
 	 * cl_object_operations::coo_attr_get() is used.
 	 */
 	int (*coo_attr_set)(const struct lu_env *env, struct cl_object *obj,
-			    const struct cl_attr *attr, unsigned valid);
+			    const struct cl_attr *attr, unsigned int valid);
 	/**
 	 * Update object configuration. Called top-to-bottom to modify object
 	 * configuration.
@@ -757,7 +757,7 @@ struct cl_page {
 	/** Link to a queue, for debugging. */
 	struct lu_ref_link       cp_queue_ref;
 	/** Per-page flags from enum cl_page_flags. Protected by a VM lock. */
-	unsigned                 cp_flags;
+	unsigned int             cp_flags;
 	/** Assigned if doing a sync_io */
 	struct cl_sync_io       *cp_sync_io;
 };
@@ -1316,7 +1316,7 @@ do {								    \
  * @{
  */
 struct cl_page_list {
-	unsigned	     pl_nr;
+	unsigned int	     pl_nr;
 	struct list_head	   pl_pages;
 	struct task_struct	*pl_owner;
 };
@@ -1834,7 +1834,7 @@ struct cl_io {
 	/**
 	 * Number of pages owned by this IO. For invariant checking.
 	 */
-	unsigned	     ci_owned_nr;
+	unsigned int	     ci_owned_nr;
 };
 
 /** @} cl_io */
@@ -1992,11 +1992,11 @@ struct cl_req {
 	/** A list of pages being transferred */
 	struct list_head	    crq_pages;
 	/** Number of pages in cl_req::crq_pages */
-	unsigned	      crq_nrpages;
+	unsigned int	      crq_nrpages;
 	/** An array of objects which pages are in ->crq_pages */
 	struct cl_req_obj    *crq_o;
 	/** Number of elements in cl_req::crq_objs[] */
-	unsigned	      crq_nrobjs;
+	unsigned int	      crq_nrobjs;
 	struct list_head	    crq_layers;
 };
 
@@ -2177,7 +2177,7 @@ void cl_object_attr_unlock(struct cl_object *o);
 int  cl_object_attr_get(const struct lu_env *env, struct cl_object *obj,
 			struct cl_attr *attr);
 int  cl_object_attr_set(const struct lu_env *env, struct cl_object *obj,
-			const struct cl_attr *attr, unsigned valid);
+			const struct cl_attr *attr, unsigned int valid);
 int  cl_object_glimpse(const struct lu_env *env, struct cl_object *obj,
 		       struct ost_lvb *lvb);
 int  cl_conf_set(const struct lu_env *env, struct cl_object *obj,
Signature · 1 line
2.7.4
#1 lore raw
Quoted 7 lines · Anson Jacob

fix checkpatch.pl warning
Prefer 'unsigned int' to bare use of 'unsigned'

---
 drivers/staging/lustre/lustre/include/cl_object.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Patch does not apply to my tree, can you rebase it against the latest staging-testing branch and resend?

thanks,

greg k-h