Skip to contentSkip to conversation

lib/Kconfig.debug: fix typo in select statement

PATCH In review Valentin Rothberg 3 participants 3 messages Aug 20, 2016 – Aug 21, 2016 Library code

lore
Share & tools
lore

Valentin Rothberg

author
#0 lore raw

PATCH 1/1 lib/Kconfig.debug: fix typo in select statement

Commit 484f29c7430b3 ("bug: Provide toggle for BUG on data corruption") added a Kconfig select statement on CONFIG_DEBUG_LIST, but the CONFIG_ prefix is only used in Make and C(PP) syntax. Remove the CONFIG_ prefix to correctly select the Kconfig option DEBUG_LIST.

Signed-off-by Valentin Rothberg <[email protected]>

---
I detected the issue with scripts/checkkconfigsymbols.py

 lib/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Kconfig.debug +1 -1
index 5dea4d0a5a07..c2bbaae13d04 100644
@@ -2009,7 +2009,7 @@ config TEST_STATIC_KEYS
 
 config BUG_ON_DATA_CORRUPTION
 	bool "Trigger a BUG when data corruption is detected"
-	select CONFIG_DEBUG_LIST
+	select DEBUG_LIST
 	help
 	  Select this option if the kernel should BUG when it encounters
 	  data corruption in kernel memory structures when they get checked
Signature · 1 line
2.9.3
#1 lore raw
Quoted 6 lines · Valentin Rothberg

Commit 484f29c7430b3 ("bug: Provide toggle for BUG on data corruption") added a Kconfig select statement on CONFIG_DEBUG_LIST, but the CONFIG_ prefix is only used in Make and C(PP) syntax. Remove the CONFIG_ prefix to correctly select the Kconfig option DEBUG_LIST.

Signed-off-by Valentin Rothberg <[email protected]>

Well, color me blind!

Good catch, queued for review and testing.

Kees, Steve, Rik, any objections?

Thanx, Paul

Quoted 22 lines

---
I detected the issue with scripts/checkkconfigsymbols.py

 lib/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Kconfig.debug +1 -1
index 5dea4d0a5a07..c2bbaae13d04 100644
@@ -2009,7 +2009,7 @@ config TEST_STATIC_KEYS
 
 config BUG_ON_DATA_CORRUPTION
 	bool "Trigger a BUG when data corruption is detected"
-	select CONFIG_DEBUG_LIST
+	select DEBUG_LIST
 	help
 	  Select this option if the kernel should BUG when it encounters
 	  data corruption in kernel memory structures when they get checked
Signature · 1 line
2.9.3
Acked-by
#2 lore raw
Quoted 6 lines · Paul E. McKenney
Quoted 5 lines · Valentin Rothberg

Commit 484f29c7430b3 ("bug: Provide toggle for BUG on data corruption") added a Kconfig select statement on CONFIG_DEBUG_LIST, but the CONFIG_ prefix is only used in Make and C(PP) syntax. Remove the CONFIG_ prefix to correctly select the Kconfig option DEBUG_LIST.

Quoted 7 lines
Quoted 1 line
Signed-off-by Valentin Rothberg <[email protected]>

Well, color me blind!

Good catch, queued for review and testing.

Kees, Steve, Rik, any objections?

Argh, thank you. Yes, this is correct.

Acked-by Kees Cook <[email protected]>

-Kees

Quoted 26 lines

Thanx, Paul

Quoted 22 lines

---
I detected the issue with scripts/checkkconfigsymbols.py

 lib/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Kconfig.debug +1 -2
index 5dea4d0a5a07..c2bbaae13d04 100644
@@ -2009,7 +2009,7 @@ config TEST_STATIC_KEYS
 
 config BUG_ON_DATA_CORRUPTION
      bool "Trigger a BUG when data corruption is detected"
-     select CONFIG_DEBUG_LIST
+     select DEBUG_LIST
      help
        Select this option if the kernel should BUG when it encounters
        data corruption in kernel memory structures when they get checked
--

2.9.3

Signature · 2 lines
Kees Cook
Nexus Security