Skip to contentSkip to conversation

Fix indentation in dce_v8_0_audio_write_sad_regs()

PATCH In review Alexandre Demers 4 participants 5 messages Aug 22, 2016 3 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix indentation in dce_v8_0_audio_write_sad_regs()

Fixed indentation for readability.

---
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +7 -7
index 3ff1258..c7e5d5f 100644
@@ -1501,13 +1501,13 @@ static void dce_v8_0_audio_write_sad_regs(struct drm_encoder *encoder)
 
 			if (sad->format == eld_reg_to_type[i][1]) {
 				if (sad->channels > max_channels) {
-				value = (sad->channels <<
-				 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__MAX_CHANNELS__SHIFT) |
-				(sad->byte2 <<
-				 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__DESCRIPTOR_BYTE_2__SHIFT) |
-				(sad->freq <<
-				 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__SUPPORTED_FREQUENCIES__SHIFT);
-				max_channels = sad->channels;
+					value = (sad->channels <<
+						 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__MAX_CHANNELS__SHIFT) |
+					        (sad->byte2 <<
+						 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__DESCRIPTOR_BYTE_2__SHIFT) |
+					        (sad->freq <<
+						 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__SUPPORTED_FREQUENCIES__SHIFT);
+					max_channels = sad->channels;
 				}
 
 				if (sad->format == HDMI_AUDIO_CODING_TYPE_PCM)
Signature · 6 lines
2.9.3

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20160822003826.16418-1-alexandre.f.demers-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 3 lines · Alexandre Demers

Fixed indentation for readability.

Quoted 20 lines
---
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +0 -7
index 3ff1258..c7e5d5f 100644
@@ -1501,13 +1501,13 @@ static void dce_v8_0_audio_write_sad_regs(struct drm_encoder *encoder)
 
 			if (sad->format == eld_reg_to_type[i][1]) {
 				if (sad->channels > max_channels) {
-				value = (sad->channels <<
-				 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__MAX_CHANNELS__SHIFT) |
-				(sad->byte2 <<
-				 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__DESCRIPTOR_BYTE_2__SHIFT) |
-				(sad->freq <<
-				 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__SUPPORTED_FREQUENCIES__SHIFT);
-				max_channels = sad->channels;

drivers/gpu/drm/amd/amdgpu/dce_v8_0.c static void dce_v8_0_audio_write_sad_regs(struct drm_encoder *encoder) · line 1513

Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +7 -0
+					value = (sad->channels <<
+						 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__MAX_CHANNELS__SHIFT) |
+					        (sad->byte2 <<
+						 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__DESCRIPTOR_BYTE_2__SHIFT) |
+					        (sad->freq <<
+						 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__SUPPORTED_FREQUENCIES__SHIFT);
+					max_channels = sad->channels;
 				}
 
 				if (sad->format == HDMI_AUDIO_CODING_TYPE_PCM)

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): c67885c8-c2dc-3628-75b2-800384a43a96-dczkZgxz+BNUPWh3PAxdjQ@public.gmane.org

Reviewed-by
#4 lore raw

Am 22.08.2016 um 02:41 schrieb Edward O'Callaghan:

Quoted 5 lines · Alexandre Demers
Quoted 3 lines

Fixed indentation for readability.

Quoted 29 lines
Quoted 29 lines
---
  drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 14 +++++++-------
  1 file changed, 7 insertions(+), 7 deletions(-)
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +7 -7
index 3ff1258..c7e5d5f 100644
@@ -1501,13 +1501,13 @@ static void dce_v8_0_audio_write_sad_regs(struct drm_encoder *encoder)
 
  			if (sad->format == eld_reg_to_type[i][1]) {
  				if (sad->channels > max_channels) {
-				value = (sad->channels <<
-				 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__MAX_CHANNELS__SHIFT) |
-				(sad->byte2 <<
-				 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__DESCRIPTOR_BYTE_2__SHIFT) |
-				(sad->freq <<
-				 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__SUPPORTED_FREQUENCIES__SHIFT);
-				max_channels = sad->channels;
+					value = (sad->channels <<
+						 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__MAX_CHANNELS__SHIFT) |
+					        (sad->byte2 <<
+						 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__DESCRIPTOR_BYTE_2__SHIFT) |
+					        (sad->freq <<
+						 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__SUPPORTED_FREQUENCIES__SHIFT);
+					max_channels = sad->channels;
  				}
 
Quoted 8 lines

drivers/gpu/drm/amd/amdgpu/dce_v8_0.c static void dce_v8_0_audio_write_sad_regs(struct drm_encoder *encoder) · line 1513

Quoted 2 lines
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +0 -0
  				if (sad->format == HDMI_AUDIO_CODING_TYPE_PCM)

_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#5 lore raw
In reply to a message not in the archive
Quoted 7 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Alexandre Demers
Sent: Sunday, August 21, 2016 8:38 PM
To: [email protected]
Subject: [PATCH drm/amdgpu] Fix indentation in dce_v8_0_audio_write_sad_regs()

For these and future patches, please include drm/amdgpu: in the patch title.

Alex

Quoted 51 lines

Fixed indentation for readability.

---
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +0 -2
index 3ff1258..c7e5d5f 100644
@@ -1501,13 +1501,13 @@ static void
 dce_v8_0_audio_write_sad_regs(struct drm_encoder *encoder)
 
 			if (sad->format == eld_reg_to_type[i][1]) {
 				if (sad->channels > max_channels) {
-				value = (sad->channels <<
-

AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__MAX_CHANNEL S__SHIFT) |

drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +0 -2
-				(sad->byte2 <<
-

AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__DESCRIPTOR_BY TE_2__SHIFT) |

drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +0 -2
-				(sad->freq <<
-

AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__SUPPORTED_FR EQUENCIES__SHIFT);

drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +2 -1
-				max_channels = sad->channels;
+					value = (sad->channels <<
+

AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__MAX_CHANNEL S__SHIFT) |

drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +2 -0
+					        (sad->byte2 <<
+

AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__DESCRIPTOR_BY TE_2__SHIFT) |

drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +2 -0
+					        (sad->freq <<
+

AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__SUPPORTED_FR EQUENCIES__SHIFT);

drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +1 -0
+					max_channels = sad->channels;
 				}
 
 				if (sad->format ==

HDMI_AUDIO_CODING_TYPE_PCM)
--
2.9.3

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): MWHPR12MB169478C874EB12F1821F3BD0F7E80-Gy0DoCVfaSW4WA4dJ5YXGAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

#7 lore raw

Will do, thanks!

I'll make the change for the others already baking for DCE6. I still have a thing or two to clean up, but it's almost there.

Quoted 64 lines · Alexander
Quoted 7 lines

-----Original Message-----
From: amd-gfx [mailto:amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org] On Behalf Of Alexandre Demers
Sent: Sunday, August 21, 2016 8:38 PM
To: [email protected]
Subject: [PATCH drm/amdgpu] Fix indentation in
dce_v8_0_audio_write_sad_regs()

For these and future patches, please include drm/amdgpu: in the patch title.

Alex

Quoted 51 lines

Fixed indentation for readability.

---
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +0 -2
index 3ff1258..c7e5d5f 100644
@@ -1501,13 +1501,13 @@ static void
 dce_v8_0_audio_write_sad_regs(struct drm_encoder *encoder)
 
                      if (sad->format == eld_reg_to_type[i][1]) {
                              if (sad->channels > max_channels) {
-                             value = (sad->channels <<
-

AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__MAX_CHANNEL S__SHIFT) |

drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +0 -2
-                             (sad->byte2 <<
-

AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__DESCRIPTOR_BY TE_2__SHIFT) |

drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +0 -2
-                             (sad->freq <<
-

AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__SUPPORTED_FR EQUENCIES__SHIFT);

drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +2 -1
-                             max_channels = sad->channels;
+                                     value = (sad->channels <<
+

AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__MAX_CHANNEL S__SHIFT) |

drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +2 -0
+                                             (sad->byte2 <<
+

AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__DESCRIPTOR_BY TE_2__SHIFT) |

drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +2 -0
+                                             (sad->freq <<
+

AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0__SUPPORTED_FR EQUENCIES__SHIFT);

+                                     max_channels = sad->channels;
                              }

                              if (sad->format ==

HDMI_AUDIO_CODING_TYPE_PCM)
--
2.9.3

Quoted 5 lines
Quoted 4 lines

_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx