Skip to contentSkip to conversation

Add R8A7792/Blanche PFC support

PATCH Superseded Sergei Shtylyov 3 participants 24 messages Jul 14, 2016 – Sep 6, 2016 Device tree bindings

lore
Share & tools
lore

Sergei Shtylyov

author
#0 lore raw

v2 cover Add R8A7792/Blanche PFC support

Hello.

Here's the set of 3 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-20160711-v4.7-rc7' tag. We're adding the R8A7792 PFC node and then describe the pins for the SCIFs and SMSC LAN89218 Ethernet chip found on the Blanche board. These patches depend on the R8A7792 PFC driver patchset in order to work properly.

[1/3] ARM: dts: r8a7792: add PFC support
[2/3] ARM: dts: blanche: add SCIF0/3 pins
[3/3] ARM: dts: blanche: add Ethernet pins

WBR, Sergei

author
#1 lore raw

PATCH v3 1/3 ARM: dts: r8a7792: add PFC support

Define the generic R8A7792 part of the PFC device node.

Signed-off-by Sergei Shtylyov <[email protected]>
Reviewed-by Geert Uytterhoeven <[email protected]>

---
Changes in version 2:
- killed extra empty line;
- added Geert's tag.

 arch/arm/boot/dts/r8a7792.dtsi |    5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/r8a7792.dtsi +5 -0
Index: renesas/arch/arm/boot/dts/r8a7792.dtsi
===================================================================
@@ -108,6 +108,11 @@
 			#power-domain-cells = <1>;
 		};
 
+		pfc: pin-controller at e6060000 {
+			compatible = "renesas,pfc-r8a7792";
+			reg = <0 0xe6060000 0 0x144>;
+		};
+
 		dmac0: dma-controller at e6700000 {
 			compatible = "renesas,dmac-r8a7792",
 				     "renesas,rcar-dmac";
author
#2 lore raw

PATCH v3 2/3 ARM: dts: blanche: add SCIF0/3 pins

In reply to Sergei Shtylyov

Add the (previously omitted) SCIF0/3 pin data to the Blanche board's device tree.

Signed-off-by Sergei Shtylyov <[email protected]>
Reviewed-by Geert Uytterhoeven <[email protected]>

---
Changes in version 2:
- added Geert's tag.

 arch/arm/boot/dts/r8a7792-blanche.dts |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
arch/arm/boot/dts/r8a7792-blanche.dts +18 -0
Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================
@@ -57,10 +57,28 @@
 	clock-frequency = <20000000>;
 };
 
+&pfc {
+	scif0_pins: scif0 {
+		groups = "scif0_data";
+		function = "scif0";
+	};
+
+	scif3_pins: scif3 {
+		groups = "scif3_data";
+		function = "scif3";
+	};
+};
+
 &scif0 {
+	pinctrl-0 = <&scif0_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 };
 
 &scif3 {
+	pinctrl-0 = <&scif3_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 };
author
#3 lore raw

PATCH v3 3/3 ARM: dts: blanche: add Ethernet pins

In reply to Sergei Shtylyov

Add the (previously omitted) pin data for the SMSC LAN89218 Ethernet chip to the Blanche board's device tree: the chip's IRQ output is connected to the SoC's IRQ0 pin and its nCS input is connected to the SoC's EX_CS0# pin.

Signed-off-by Sergei Shtylyov <[email protected]>

---
Changes in version 3:
- killed extra empty line;
- reformatted the changelog.

 arch/arm/boot/dts/r8a7792-blanche.dts |   14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/r8a7792-blanche.dts +14 -0
Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================
@@ -50,6 +50,9 @@
 		reg-io-width = <4>;
 		vddvario-supply = <&d3_3v>;
 		vdd33a-supply = <&d3_3v>;
+
+		pinctrl-0 = <&lan89218_pins>;
+		pinctrl-names = "default";
 	};
 };
 

@@ -67,6 +70,17 @@
 		groups = "scif3_data";
 		function = "scif3";
 	};
+
+	lan89218_pins: lan89218 {
+		intc {
+			groups = "intc_irq0";
+			function = "intc";
+		};
+		lbsc {
+			groups = "lbsc_ex_cs0";
+			function = "lbsc";
+		};
+	};
 };
 
 &scif0 {
#4 lore raw

v2 cover Add R8A7792/Blanche PFC support

In reply to Sergei Shtylyov
Quoted 11 lines · Sergei Shtylyov

Hello.

Here's the set of 3 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-20160711-v4.7-rc7' tag. We're adding the R8A7792 PFC node and then describe the pins for the SCIFs and SMSC LAN89218 Ethernet chip found on the Blanche board. These patches depend on the R8A7792 PFC driver patchset in order to work properly.

[1/3] ARM: dts: r8a7792: add PFC support
[2/3] ARM: dts: blanche: add SCIF0/3 pins
[3/3] ARM: dts: blanche: add Ethernet pins

Thanks, I have queued this up.

author
#5 lore raw

PATCH 1/1 ARM: dts: blanche: add support for general purpose switches

In reply to Sergei Shtylyov

Add support for the general purpose software switches SW2 and tactile switches SW24/25 as a virtual keyboard (like it was done with the Lager/ Koelsch boards).

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's 'renesas.git' repo.

 arch/arm/boot/dts/r8a7792-blanche.dts |   49 ++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)
arch/arm/boot/dts/r8a7792-blanche.dts +49 -0
Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================
@@ -11,6 +11,8 @@
 
 /dts-v1/;
 #include "r8a7792.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
 
 / {
 	model = "Blanche";

@@ -54,6 +56,53 @@
 		pinctrl-0 = <&lan89218_pins>;
 		pinctrl-names = "default";
 	};
+
+	keyboard {
+		compatible = "gpio-keys";
+
+		key-1 {
+			linux,code = <KEY_1>;
+			label = "SW2-1";
+			wakeup-source;
+			debounce-interval = <20>;
+			gpios = <&gpio3 10 GPIO_ACTIVE_LOW>;
+		};
+		key-2 {
+			linux,code = <KEY_2>;
+			label = "SW2-2";
+			wakeup-source;
+			debounce-interval = <20>;
+			gpios = <&gpio3 11 GPIO_ACTIVE_LOW>;
+		};
+		key-3 {
+			linux,code = <KEY_3>;
+			label = "SW2-3";
+			wakeup-source;
+			debounce-interval = <20>;
+			gpios = <&gpio3 12 GPIO_ACTIVE_LOW>;
+		};
+		key-4 {
+			linux,code = <KEY_4>;
+			label = "SW2-4";
+			wakeup-source;
+			debounce-interval = <20>;
+			gpios = <&gpio3 15 GPIO_ACTIVE_LOW>;
+		};
+		key-a {
+			linux,code = <KEY_A>;
+			label = "SW24";
+			wakeup-source;
+			debounce-interval = <20>;
+			gpios = <&gpio3 20 GPIO_ACTIVE_LOW>;
+		};
+		key-b {
+			linux,code = <KEY_B>;
+			label = "SW25";
+			wakeup-source;
+			debounce-interval = <20>;
+			gpios = <&gpio11 2 GPIO_ACTIVE_LOW>;
+		};
+	};
 };
 
 &extal_clk {
#6 lore raw

PATCH 1/1 ARM: dts: blanche: add support for general purpose switches

Quoted 5 lines · Sergei Shtylyov

Add support for the general purpose software switches SW2 and tactile switches SW24/25 as a virtual keyboard (like it was done with the Lager/ Koelsch boards).

Signed-off-by Sergei Shtylyov <[email protected]>

Thanks, I have queued this up.

author
#7 lore raw

PATCH 1/1 ARM: dts: blanche: add SDHI0 support

In reply to Sergei Shtylyov

Define the Blanche board dependent part of the SDHI0 (connected to the micro-SD slot) device node along with the necessary voltage regulator.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's 'renesas.git' repo plus the general purpose switches patch posted yesterday.

 arch/arm/boot/dts/r8a7792-blanche.dts |   25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
arch/arm/boot/dts/r8a7792-blanche.dts +25 -0
Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================
@@ -103,6 +103,17 @@
 			gpios = <&gpio11 2 GPIO_ACTIVE_LOW>;
 		};
 	};
+
+	vcc_sdhi0: regulator-vcc-sdhi0 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "SDHI0 Vcc";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&gpio11 12 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
 };
 
 &extal_clk {

@@ -139,6 +150,11 @@
 		groups = "can0_data", "can_clk";
 		function = "can0";
 	};
+
+	sdhi0_pins: sdhi0 {
+		groups = "sdhi0_data4", "sdhi0_ctrl";
+		function = "sdhi0";
+	};
 };
 
 &scif0 {

@@ -161,3 +177,12 @@
 
 	status = "okay";
 };
+
+&sdhi0 {
+	pinctrl-0 = <&sdhi0_pins>;
+	pinctrl-names = "default";
+
+	vmmc-supply = <&vcc_sdhi0>;
+	cd-gpios = <&gpio11 11 GPIO_ACTIVE_LOW>;
+	status = "okay";
+};
#8 lore raw

PATCH 1/1 ARM: dts: blanche: add SDHI0 support

Hi Sergei,

Quoted 22 lines · Sergei Shtylyov

Define the Blanche board dependent part of the SDHI0 (connected to the micro-SD slot) device node along with the necessary voltage regulator.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's 'renesas.git' repo plus the general purpose switches patch posted yesterday.

 arch/arm/boot/dts/r8a7792-blanche.dts |   25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================

arch/arm/boot/dts/r8a7792-blanche.dts +2 -0
@@ -103,6 +103,17 @@
 			gpios = <&gpio11 2 GPIO_ACTIVE_LOW>;
 		};
 	};
+
+	vcc_sdhi0: regulator-vcc-sdhi0 {

arch/arm/boot/dts/r8a7792-blanche.dts line 117

Quoted 10 lines
arch/arm/boot/dts/r8a7792-blanche.dts +9 -0
+		compatible = "regulator-fixed";
+
+		regulator-name = "SDHI0 Vcc";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&gpio11 12 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
 };

Is it intentional that there is no vccq_sdhi0 ?

Quoted 28 lines
arch/arm/boot/dts/r8a7792-blanche.dts +14 -0
 &extal_clk {

@@ -139,6 +150,11 @@
 		groups = "can0_data", "can_clk";
 		function = "can0";
 	};
+
+	sdhi0_pins: sdhi0 {
+		groups = "sdhi0_data4", "sdhi0_ctrl";
+		function = "sdhi0";
+	};
 };
 
 &scif0 {

@@ -161,3 +177,12 @@
 
 	status = "okay";
 };
+
+&sdhi0 {
+	pinctrl-0 = <&sdhi0_pins>;
+	pinctrl-names = "default";
+
+	vmmc-supply = <&vcc_sdhi0>;
+	cd-gpios = <&gpio11 11 GPIO_ACTIVE_LOW>;
+	status = "okay";
+};
author
#9 lore raw

PATCH 1/1 ARM: dts: blanche: add SDHI0 support

Quoted 26 lines · Simon Horman
Quoted 26 lines

Define the Blanche board dependent part of the SDHI0 (connected to the micro-SD slot) device node along with the necessary voltage regulator.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's 'renesas.git' repo plus the general purpose switches patch posted yesterday.

 arch/arm/boot/dts/r8a7792-blanche.dts |   25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================

arch/arm/boot/dts/r8a7792-blanche.dts +6 -0
@@ -103,6 +103,17 @@
 			gpios = <&gpio11 2 GPIO_ACTIVE_LOW>;
 		};
 	};
+
+	vcc_sdhi0: regulator-vcc-sdhi0 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "SDHI0 Vcc";
+		regulator-min-microvolt = <3300000>;
Quoted 8 lines

arch/arm/boot/dts/r8a7792-blanche.dts line 117

Quoted 6 lines
arch/arm/boot/dts/r8a7792-blanche.dts +5 -0
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&gpio11 12 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
 };

Is it intentional that there is no vccq_sdhi0 ?

Yes, it's fixed at 3.3V.

[...]

MBR, Sergei

#10 lore raw

PATCH 1/1 ARM: dts: blanche: add SDHI0 support

Quoted 37 lines · Sergei Shtylyov
Quoted 26 lines · Simon Horman
Quoted 26 lines

Define the Blanche board dependent part of the SDHI0 (connected to the micro-SD slot) device node along with the necessary voltage regulator.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's 'renesas.git' repo plus the general purpose switches patch posted yesterday.

arch/arm/boot/dts/r8a7792-blanche.dts | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================

arch/arm/boot/dts/r8a7792-blanche.dts +6 -0
@@ -103,6 +103,17 @@
 			gpios = <&gpio11 2 GPIO_ACTIVE_LOW>;
 		};
 	};
+
+	vcc_sdhi0: regulator-vcc-sdhi0 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "SDHI0 Vcc";
+		regulator-min-microvolt = <3300000>;
Quoted 8 lines

arch/arm/boot/dts/r8a7792-blanche.dts line 117

Quoted 6 lines
arch/arm/boot/dts/r8a7792-blanche.dts +5 -0
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&gpio11 12 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
 };

Is it intentional that there is no vccq_sdhi0 ?

Quoted 1 line

Yes, it's fixed at 3.3V.

Thanks, I have queued this up.

author
#11 lore raw

PATCH 1/1 ARM: dts: blanche: add DU support

In reply to Sergei Shtylyov

Define the Blanche board dependent part of the DU device node. Add the device nodes for the Analog Devices ADV7511W HDMI transmitter (connected to DU0) and ADV7123 video DAC (connected to DU1). Add the necessary subnodes to interconnect DU, HDMI/VDAC devices, and HDMI/VGA connectors.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's 'renesas.git' repo plus the general purpose switches patch and the SDHI0 patch posted earlier.

 arch/arm/boot/dts/r8a7792-blanche.dts |  125 ++++++++++++++++++++++++++++++++++
 1 file changed, 125 insertions(+)
arch/arm/boot/dts/r8a7792-blanche.dts +125 -0
Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================
@@ -57,6 +57,61 @@
 		pinctrl-names = "default";
 	};
 
+	vga-encoder {
+		compatible = "adi,adv7123";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port at 0 {
+				reg = <0>;
+				adv7123_in: endpoint {
+					remote-endpoint = <&du_out_rgb1>;
+				};
+			};
+			port at 1 {
+				reg = <1>;
+				adv7123_out: endpoint {
+					remote-endpoint = <&vga_in>;
+				};
+			};
+		};
+	};
+
+	hdmi-out {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi_con: endpoint {
+				remote-endpoint = <&adv7511_out>;
+			};
+		};
+	};
+
+	vga {
+		compatible = "vga-connector";
+
+		port {
+			vga_in: endpoint {
+				remote-endpoint = <&adv7123_out>;
+			};
+		};
+	};
+
+	x1_clk: x1 {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <74250000>;
+	};
+
+	x2_clk: x2 {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <65000000>;
+	};
+
 	keyboard {
 		compatible = "gpio-keys";
 

@@ -155,6 +210,16 @@
 		groups = "sdhi0_data4", "sdhi0_ctrl";
 		function = "sdhi0";
 	};
+
+	du0_pins: du0 {
+		groups = "du0_rgb888", "du0_sync", "du0_disp";
+		function = "du0";
+	};
+
+	du1_pins: du1 {
+		groups = "du1_rgb666", "du1_sync", "du1_disp";
+		function = "du1";
+	};
 };
 
 &scif0 {

@@ -186,3 +251,63 @@
 	cd-gpios = <&gpio11 11 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
+
+&i2c1 {
+	status = "okay";
+	clock-frequency = <400000>;
+
+	hdmi at 39 {
+		compatible = "adi,adv7511w";
+		reg = <0x39>;
+		interrupt-parent = <&irqc>;
+		interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
+
+		adi,input-depth = <8>;
+		adi,input-colorspace = "rgb";
+		adi,input-clock = "1x";
+		adi,input-style = <1>;
+		adi,input-justification = "evenly";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port at 0 {
+				reg = <0>;
+				adv7511_in: endpoint {
+					remote-endpoint = <&du_out_rgb0>;
+				};
+			};
+
+			port at 1 {
+				reg = <1>;
+				adv7511_out: endpoint {
+					remote-endpoint = <&hdmi_con>;
+				};
+			};
+		};
+	};
+};
+
+&du {
+	pinctrl-0 = <&du0_pins &du1_pins>;
+	pinctrl-names = "default";
+
+	clocks = <&mstp7_clks R8A7792_CLK_DU0>, <&mstp7_clks R8A7792_CLK_DU1>,
+		 <&x1_clk>, <&x2_clk>;
+	clock-names = "du.0", "du.1", "dclkin.0", "dclkin.1";
+	status = "okay";
+
+	ports {
+		port at 0 {
+			endpoint {
+				remote-endpoint = <&adv7511_in>;
+			};
+		};
+		port at 1 {
+			endpoint {
+				remote-endpoint = <&adv7123_in>;
+			};
+		};
+	};
+};
#12 lore raw

PATCH 1/1 ARM: dts: blanche: add DU support

Hi Sergei,

Quoted 20 lines · Sergei Shtylyov

Define the Blanche board dependent part of the DU device node. Add the device nodes for the Analog Devices ADV7511W HDMI transmitter (connected to DU0) and ADV7123 video DAC (connected to DU1). Add the necessary subnodes to interconnect DU, HDMI/VDAC devices, and HDMI/VGA connectors.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's 'renesas.git' repo plus the general purpose switches patch and the SDHI0 patch posted earlier.

 arch/arm/boot/dts/r8a7792-blanche.dts |  125 ++++++++++++++++++++++++++++++++++
 1 file changed, 125 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================

arch/arm/boot/dts/r8a7792-blanche.dts +0 -0

...

arch/arm/boot/dts/r8a7792-blanche.dts line 257

Quoted 8 lines
arch/arm/boot/dts/r8a7792-blanche.dts +4 -0
@@ -186,3 +251,63 @@
 	cd-gpios = <&gpio11 11 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
+
+&i2c1 {
+	status = "okay";
+	clock-frequency = <400000>;

Is it intentional that there are no pinctrl properties here?

...

#13 lore raw

PATCH 1/1 ARM: dts: blanche: add DU support

Hi Simon,

Quoted 8 lines · Simon Horman
Quoted 4 lines · Sergei Shtylyov

Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================

arch/arm/boot/dts/r8a7792-blanche.dts +0 -0

...

Quoted 10 lines

arch/arm/boot/dts/r8a7792-blanche.dts line 257

Quoted 8 lines
arch/arm/boot/dts/r8a7792-blanche.dts +4 -0
@@ -186,3 +251,63 @@
      cd-gpios = <&gpio11 11 GPIO_ACTIVE_LOW>;
      status = "okay";
 };
+
+&i2c1 {
+     status = "okay";
+     clock-frequency = <400000>;

Is it intentional that there are no pinctrl properties here?

$ git grep -w I2C arch/arm/boot/dts/r8a7792.dtsi
arch/arm/boot/dts/r8a7792.dtsi:         /* I2C doesn't need pinmux */
$

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

author
#14 lore raw

PATCH 1/1 ARM: dts: blanche: add DU support

In reply to Simon Horman

Hello.

Quoted 23 lines · Simon Horman
Quoted 20 lines

Define the Blanche board dependent part of the DU device node. Add the device nodes for the Analog Devices ADV7511W HDMI transmitter (connected to DU0) and ADV7123 video DAC (connected to DU1). Add the necessary subnodes to interconnect DU, HDMI/VDAC devices, and HDMI/VGA connectors.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's 'renesas.git' repo plus the general purpose switches patch and the SDHI0 patch posted earlier.

 arch/arm/boot/dts/r8a7792-blanche.dts |  125 ++++++++++++++++++++++++++++++++++
 1 file changed, 125 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================

arch/arm/boot/dts/r8a7792-blanche.dts +0 -0

...

Quoted 10 lines

arch/arm/boot/dts/r8a7792-blanche.dts line 257

Quoted 8 lines
arch/arm/boot/dts/r8a7792-blanche.dts +4 -0
@@ -186,3 +251,63 @@
 	cd-gpios = <&gpio11 11 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
+
+&i2c1 {
+	status = "okay";
+	clock-frequency = <400000>;

Is it intentional that there are no pinctrl properties here?

Yes, as I commented in r8a7792.dtsi, all I2C pins are not multiplexed.

MBR, Sergei

#15 lore raw

PATCH 1/1 ARM: dts: blanche: add DU support

Quoted 38 lines · Sergei Shtylyov

Hello.

Quoted 23 lines · Simon Horman
Quoted 20 lines

Define the Blanche board dependent part of the DU device node. Add the device nodes for the Analog Devices ADV7511W HDMI transmitter (connected to DU0) and ADV7123 video DAC (connected to DU1). Add the necessary subnodes to interconnect DU, HDMI/VDAC devices, and HDMI/VGA connectors.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's 'renesas.git' repo plus the general purpose switches patch and the SDHI0 patch posted earlier.

arch/arm/boot/dts/r8a7792-blanche.dts | 125 ++++++++++++++++++++++++++++++++++

1 file changed, 125 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================

arch/arm/boot/dts/r8a7792-blanche.dts +0 -0

...

Quoted 10 lines

arch/arm/boot/dts/r8a7792-blanche.dts line 257

Quoted 8 lines
arch/arm/boot/dts/r8a7792-blanche.dts +4 -0
@@ -186,3 +251,63 @@
 	cd-gpios = <&gpio11 11 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
+
+&i2c1 {
+	status = "okay";
+	clock-frequency = <400000>;

Is it intentional that there are no pinctrl properties here?

Quoted 1 line

Yes, as I commented in r8a7792.dtsi, all I2C pins are not multiplexed.

Thanks for satisfying my curiosity.
I have queued this up.

author
#16 lore raw

PATCH 1/1 ARM: dts: blanche: add support for general purpose LEDs

In reply to Sergei Shtylyov

Add support for the general purpose LEDs on the Blanche board.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20160822-v4.8-rc3' of Simon Horman's 'renesas.git' repo plus the SDHI0/DU patches posted earlier.

 arch/arm/boot/dts/r8a7792-blanche.dts |   21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
arch/arm/boot/dts/r8a7792-blanche.dts +21 -0
Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================
@@ -159,6 +159,27 @@
 		};
 	};
 
+	leds {
+		compatible = "gpio-leds";
+
+		led17 {
+			gpios = <&gpio10 10 GPIO_ACTIVE_HIGH>;
+			label = "LED17";
+		};
+		led18 {
+			gpios = <&gpio10 11 GPIO_ACTIVE_HIGH>;
+			label = "LED18";
+		};
+		led19 {
+			gpios = <&gpio10 12 GPIO_ACTIVE_HIGH>;
+			label = "LED19";
+		};
+		led20 {
+			gpios = <&gpio10 23 GPIO_ACTIVE_HIGH>;
+			label = "LED20";
+		};
+	};
+
 	vcc_sdhi0: regulator-vcc-sdhi0 {
 		compatible = "regulator-fixed";
#17 lore raw

PATCH 1/1 ARM: dts: blanche: add support for general purpose LEDs

Quoted 16 lines · Sergei Shtylyov

Add support for the general purpose LEDs on the Blanche board.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20160822-v4.8-rc3' of Simon Horman's 'renesas.git' repo plus the SDHI0/DU patches posted earlier.

 arch/arm/boot/dts/r8a7792-blanche.dts |   21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================

arch/arm/boot/dts/r8a7792-blanche.dts line 167

Quoted 9 lines
arch/arm/boot/dts/r8a7792-blanche.dts +6 -0
@@ -159,6 +159,27 @@
 		};
 	};
 
+	leds {
+		compatible = "gpio-leds";
+
+		led17 {
+			gpios = <&gpio10 10 GPIO_ACTIVE_HIGH>;
+			label = "LED17";

I am unclear of the motivation for using the label property when its value is so similar to the name of the node.

The reason I noticed this is that it appears to differ from led nodes for other Renesas ARM SoCs. I'm not opposed to using the label property if there is some value to it. But I would prefer to use it consistently. And I'd prefer not to add it to all the other SoCs unless there is a reason to.

Quoted 19 lines
arch/arm/boot/dts/r8a7792-blanche.dts +15 -0
+		};
+		led18 {
+			gpios = <&gpio10 11 GPIO_ACTIVE_HIGH>;
+			label = "LED18";
+		};
+		led19 {
+			gpios = <&gpio10 12 GPIO_ACTIVE_HIGH>;
+			label = "LED19";
+		};
+		led20 {
+			gpios = <&gpio10 23 GPIO_ACTIVE_HIGH>;
+			label = "LED20";
+		};
+	};
+
 	vcc_sdhi0: regulator-vcc-sdhi0 {
 		compatible = "regulator-fixed";
author
#18 lore raw

PATCH 1/1 ARM: dts: blanche: add support for general purpose LEDs

Quoted 29 lines · Simon Horman
Quoted 16 lines

Add support for the general purpose LEDs on the Blanche board.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20160822-v4.8-rc3' of Simon Horman's 'renesas.git' repo plus the SDHI0/DU patches posted earlier.

 arch/arm/boot/dts/r8a7792-blanche.dts |   21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================

arch/arm/boot/dts/r8a7792-blanche.dts line 167

Quoted 9 lines
arch/arm/boot/dts/r8a7792-blanche.dts +6 -0
@@ -159,6 +159,27 @@
 		};
 	};
 
+	leds {
+		compatible = "gpio-leds";
+
+		led17 {
+			gpios = <&gpio10 10 GPIO_ACTIVE_HIGH>;
+			label = "LED17";

I am unclear of the motivation for using the label property when its value is so similar to the name of the node.

Quoted 2 lines

The reason I noticed this is that it appears to differ from led nodes for other Renesas ARM SoCs.

I was looking at the Koelsch's DT as an example (and Gose's DT also had
labels).

Quoted 4 lines

I'm not opposed to using the label property
if there is some value to it. But I would prefer to use it consistently. And I'd prefer not to add it to all the other SoCs unless there is a reason to.

Looks like the driver can infer the LED names from the device node names.
I'll recast.

[...]

MBR, Sergei

author
#19 lore raw

PATCH v2 1/1 ARM: dts: blanche: add support for general purpose LEDs

In reply to Sergei Shtylyov

Add support for the general purpose LEDs on the Blanche board.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20160824-v4.8-rc3' of Simon Horman's 'renesas.git'.

Changes in version 2:
- removed the "label" props.

 arch/arm/boot/dts/r8a7792-blanche.dts |   17 +++++++++++++++++
 1 file changed, 17 insertions(+)
arch/arm/boot/dts/r8a7792-blanche.dts +17 -0
Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================
@@ -159,6 +159,23 @@
 		};
 	};
 
+	leds {
+		compatible = "gpio-leds";
+
+		led17 {
+			gpios = <&gpio10 10 GPIO_ACTIVE_HIGH>;
+		};
+		led18 {
+			gpios = <&gpio10 11 GPIO_ACTIVE_HIGH>;
+		};
+		led19 {
+			gpios = <&gpio10 12 GPIO_ACTIVE_HIGH>;
+		};
+		led20 {
+			gpios = <&gpio10 23 GPIO_ACTIVE_HIGH>;
+		};
+	};
+
 	vcc_sdhi0: regulator-vcc-sdhi0 {
 		compatible = "regulator-fixed";
#20 lore raw

PATCH v2 1/1 ARM: dts: blanche: add support for general purpose LEDs

Quoted 3 lines · Sergei Shtylyov

Add support for the general purpose LEDs on the Blanche board.

Signed-off-by Sergei Shtylyov <[email protected]>

Thanks, I have queued this up.

author
#21 lore raw

PATCH 1/1 ARM: dts: wheat: add support for tactile switches

In reply to Sergei Shtylyov

Add support for the tactile switches SW2/3 (on the debug board) as a virtual keyboard like it was done with the Blanche board).

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against the 'renesas-devel-20160905-v4.8-rc5' of Simon Horman's 'renesas.git' repo plus the Wheat DU patch...

 arch/arm/boot/dts/r8a7792-wheat.dts |   20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
arch/arm/boot/dts/r8a7792-wheat.dts +20 -0
Index: renesas/arch/arm/boot/dts/r8a7792-wheat.dts
===================================================================
@@ -12,6 +12,7 @@
 /dts-v1/;
 #include "r8a7792.dtsi"
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
 
 / {
 	model = "Wheat";

@@ -56,6 +57,25 @@
 		pinctrl-names = "default";
 	};
 
+	keyboard {
+		compatible = "gpio-keys";
+
+		key-a {
+			linux,code = <KEY_A>;
+			label = "SW2";
+			wakeup-source;
+			debounce-interval = <20>;
+			gpios = <&gpio3 20 GPIO_ACTIVE_LOW>;
+		};
+		key-b {
+			linux,code = <KEY_B>;
+			label = "SW3";
+			wakeup-source;
+			debounce-interval = <20>;
+			gpios = <&gpio11 2 GPIO_ACTIVE_LOW>;
+		};
+	};
+
 	vcc_sdhi0: regulator-vcc-sdhi0 {
 		compatible = "regulator-fixed";
#22 lore raw

PATCH 1/1 ARM: dts: wheat: add support for tactile switches

Quoted 4 lines · Sergei Shtylyov

Add support for the tactile switches SW2/3 (on the debug board) as a virtual keyboard like it was done with the Blanche board).

Signed-off-by Sergei Shtylyov <[email protected]>
Acked-by Geert Uytterhoeven <[email protected]>

DT syntax looks OK to me, I have no board schematics or documentation.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#23 lore raw

PATCH 1/1 ARM: dts: wheat: add support for tactile switches

Quoted 10 lines · Geert Uytterhoeven
Quoted 4 lines · Sergei Shtylyov

Add support for the tactile switches SW2/3 (on the debug board) as a virtual keyboard like it was done with the Blanche board).

Signed-off-by Sergei Shtylyov <[email protected]>
Acked-by Geert Uytterhoeven <[email protected]>

DT syntax looks OK to me, I have no board schematics or documentation.

Thanks, I have queued this up.